mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 04:37:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2371 from lorenzosaino/fix-http3-client-close

Browse source 
Make http3.client.Close() succeed if session was not started
This commit is contained in:
Marten Seemann 2020-02-28 12:00:50 +07:00 • committed by GitHub
commit 3b1e6118da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
http3/client.go
View file

@ -127,6 +127,9 @@ func (c *client) setupSession() error {
}
func (c *client) Close() error {
if c.session == nil {
return nil
}
return c.session.CloseWithError(quic.ErrorCode(errorNoError), "")
}

6
http3/client_test.go
View file

@ -146,6 +146,12 @@ var _ = Describe("Client", func() {
Expect(err).To(MatchError(testErr))
})
It("closes correctly if session was not created", func() {
client = newClient("localhost:1337", nil, &roundTripperOpts{}, nil, nil)
err := client.Close()
Expect(err).ToNot(HaveOccurred())
})
Context("Doing requests", func() {
var (
request *http.Request