mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 04:37:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

surface connection error as connection context cancelation cause (#3961)

Browse source 
* connection: surface connection error as connection context cancellation cause

* docs: add note about connection context canellation cause
This commit is contained in:
Ferdinand Holzer 2023-07-18 06:31:31 +02:00 • committed by GitHub
parent ab192a084d
commit 4378283f95
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
connection_test.go
View file

@ -395,6 +395,7 @@ var _ = Describe("Connection", func() {
}
Expect(conn.handleFrame(ccf, protocol.Encryption1RTT, protocol.ConnectionID{})).To(Succeed())
Eventually(conn.Context().Done()).Should(BeClosed())
Expect(context.Cause(conn.Context())).To(MatchError(testErr))
})
It("errors on HANDSHAKE_DONE frames", func() {
@ -499,6 +500,7 @@ var _ = Describe("Connection", func() {
conn.CloseWithError(0x1337, "test error")
Eventually(areConnsRunning).Should(BeFalse())
Expect(conn.Context().Done()).To(BeClosed())
Expect(context.Cause(conn.Context())).To(MatchError(expectedErr))
})
It("includes the frame type in transport-level close frames", func() {
@ -566,6 +568,7 @@ var _ = Describe("Connection", func() {
tracer.EXPECT().Close()
conn.shutdown()
Eventually(returned).Should(BeClosed())
Expect(context.Cause(conn.Context())).To(MatchError(context.Canceled))
})
It("doesn't send any more packets after receiving a CONNECTION_CLOSE", func() {
@ -2010,19 +2013,21 @@ var _ = Describe("Connection", func() {
tracer.EXPECT().Close()
conn.shutdown()
Eventually(done).Should(BeClosed())
Expect(context.Cause(conn.Context())).To(MatchError(context.Canceled))
})
It("passes errors to the connection runner", func() {
testErr := errors.New("handshake error")
expectedErr := &qerr.ApplicationError{
ErrorCode: 0x1337,
ErrorMessage: testErr.Error(),
}
done := make(chan struct{})
go func() {
defer GinkgoRecover()
cryptoSetup.EXPECT().StartHandshake().MaxTimes(1)
err := conn.run()
Expect(err).To(MatchError(&qerr.ApplicationError{
ErrorCode: 0x1337,
ErrorMessage: testErr.Error(),
}))
Expect(err).To(MatchError(expectedErr))
close(done)
}()
streamManager.EXPECT().CloseWithError(gomock.Any())
@ -2034,6 +2039,7 @@ var _ = Describe("Connection", func() {
tracer.EXPECT().Close()
Expect(conn.CloseWithError(0x1337, testErr.Error())).To(Succeed())
Eventually(done).Should(BeClosed())
Expect(context.Cause(conn.Context())).To(MatchError(expectedErr))
})
Context("transport parameters", func() {