mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

avoid recursion when skipping unknown HTTP/3 frames (#3354)

Browse source
This commit is contained in:
Marten Seemann 2022-03-22 16:48:17 +01:00 • committed by GitHub
parent 2661c2807d
commit 4725ddebf3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

61
http3/frames.go
View file

@ -14,38 +14,39 @@ type frame interface{}
func parseNextFrame(r io.Reader) (frame, error) { func parseNextFrame(r io.Reader) (frame, error) {
qr := quicvarint.NewReader(r) qr := quicvarint.NewReader(r)
t, err := quicvarint.Read(qr) for {
if err != nil { t, err := quicvarint.Read(qr)
return nil, err if err != nil {
}
l, err := quicvarint.Read(qr)
if err != nil {
return nil, err
}
switch t {
case 0x0:
return &dataFrame{Length: l}, nil
case 0x1:
return &headersFrame{Length: l}, nil
case 0x4:
return parseSettingsFrame(r, l)
case 0x3: // CANCEL_PUSH
fallthrough
case 0x5: // PUSH_PROMISE
fallthrough
case 0x7: // GOAWAY
fallthrough
case 0xd: // MAX_PUSH_ID
fallthrough
case 0xe: // DUPLICATE_PUSH
fallthrough
default:
// skip over unknown frames
if _, err := io.CopyN(ioutil.Discard, qr, int64(l)); err != nil {
return nil, err return nil, err
} }
return parseNextFrame(qr) l, err := quicvarint.Read(qr)
if err != nil {
return nil, err
}
switch t {
case 0x0:
return &dataFrame{Length: l}, nil
case 0x1:
return &headersFrame{Length: l}, nil
case 0x4:
return parseSettingsFrame(r, l)
case 0x3: // CANCEL_PUSH
fallthrough
case 0x5: // PUSH_PROMISE
fallthrough
case 0x7: // GOAWAY
fallthrough
case 0xd: // MAX_PUSH_ID
fallthrough
case 0xe: // DUPLICATE_PUSH
fallthrough
default:
// skip over unknown frames
if _, err := io.CopyN(ioutil.Discard, qr, int64(l)); err != nil {
return nil, err
}
}
} }
} }