mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

trace dropped packets in the packet handler map

Browse source
This commit is contained in:
Marten Seemann 2020-07-10 15:39:56 +07:00
parent 2f63bc0731
commit 48e15aed92
2 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packet_handler_map.go
View file

@ -274,6 +274,9 @@ func (h *packetHandlerMap) handlePacket(
connID, err := wire.ParseConnectionID(data, h.connIDLen)
if err != nil {
h.logger.Debugf("error parsing connection ID on packet from %s: %s", addr, err)
if h.tracer != nil {
h.tracer.DroppedPacket(addr, logging.PacketTypeNotDetermined, protocol.ByteCount(len(data)), logging.PacketDropHeaderParseError)
}
return
}
rcvTime := time.Now()

14
packet_handler_map_test.go
View file

@ -7,10 +7,14 @@ import (
"net"
"time"
"github.com/golang/mock/gomock"
"github.com/lucas-clemente/quic-go/internal/mocks"
"github.com/lucas-clemente/quic-go/internal/protocol"
"github.com/lucas-clemente/quic-go/internal/utils"
"github.com/lucas-clemente/quic-go/internal/wire"
"github.com/lucas-clemente/quic-go/logging"
"github.com/golang/mock/gomock"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)
@ -19,6 +23,7 @@ var _ = Describe("Packet Handler Map", func() {
var (
handler *packetHandlerMap
conn *mockPacketConn
tracer *mocks.MockTracer
connIDLen int
statelessResetKey []byte
@ -46,11 +51,12 @@ var _ = Describe("Packet Handler Map", func() {
BeforeEach(func() {
statelessResetKey = nil
connIDLen = 0
tracer = mocks.NewMockTracer(mockCtrl)
})
JustBeforeEach(func() {
conn = newMockPacketConn()
handler = newPacketHandlerMap(conn, connIDLen, statelessResetKey, nil, utils.DefaultLogger).(*packetHandlerMap)
handler = newPacketHandlerMap(conn, connIDLen, statelessResetKey, tracer, utils.DefaultLogger).(*packetHandlerMap)
})
AfterEach(func() {
@ -122,7 +128,9 @@ var _ = Describe("Packet Handler Map", func() {
})
It("drops unparseable packets", func() {
handler.handlePacket(nil, nil, []byte{0, 1, 2, 3})
addr := &net.UDPAddr{IP: net.IPv4(9, 8, 7, 6), Port: 1234}
tracer.EXPECT().DroppedPacket(addr, logging.PacketTypeNotDetermined, protocol.ByteCount(4), logging.PacketDropHeaderParseError)
handler.handlePacket(addr, nil, []byte{0, 1, 2, 3})
})
It("deletes removed sessions immediately", func() {