From 5504c47ca50b3fa89efa0f6ae6b546b71199c690 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Wed, 18 Oct 2017 13:55:57 +0700 Subject: [PATCH] reduce the maximum packet size of sent packets to 1200 bytes This is the value the IETF draft mandates for implementations that don't do PMTUD. --- integrationtests/tools/proxy/proxy.go | 4 ++-- internal/protocol/server_parameters.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/integrationtests/tools/proxy/proxy.go b/integrationtests/tools/proxy/proxy.go index a9d0d4cf..5b1dc21d 100644 --- a/integrationtests/tools/proxy/proxy.go +++ b/integrationtests/tools/proxy/proxy.go @@ -164,7 +164,7 @@ func (p *QuicProxy) newConnection(cliAddr *net.UDPAddr) (*connection, error) { // runProxy listens on the proxy address and handles incoming packets. func (p *QuicProxy) runProxy() error { for { - buffer := make([]byte, protocol.MaxPacketSize) + buffer := make([]byte, protocol.MaxReceivePacketSize) n, cliaddr, err := p.conn.ReadFromUDP(buffer) if err != nil { return err @@ -211,7 +211,7 @@ func (p *QuicProxy) runProxy() error { // runConnection handles packets from server to a single client func (p *QuicProxy) runConnection(conn *connection) error { for { - buffer := make([]byte, protocol.MaxPacketSize) + buffer := make([]byte, protocol.MaxReceivePacketSize) n, err := conn.ServerConn.Read(buffer) if err != nil { return err diff --git a/internal/protocol/server_parameters.go b/internal/protocol/server_parameters.go index 69ee039f..8472fe8d 100644 --- a/internal/protocol/server_parameters.go +++ b/internal/protocol/server_parameters.go @@ -2,9 +2,9 @@ package protocol import "time" -// MaxPacketSize is the maximum packet size, including the public header, that we use for sending packets -// This is the value used by Chromium for a QUIC packet sent using IPv6 (for IPv4 it would be 1370) -const MaxPacketSize ByteCount = 1350 +// MaxPacketSize is the maximum packet size that we use for sending packets. +// It includes the QUIC packet header, but excludes the UDP and IP header. +const MaxPacketSize ByteCount = 1200 // NonForwardSecurePacketSizeReduction is the number of bytes a non forward-secure packet has to be smaller than a forward-secure packet // This makes sure that those packets can always be retransmitted without splitting the contained StreamFrames