ci: run linter on all supported platforms (#3816)

* only define packetInfo.ifIndex on platforms where it's actually used

* fix comment and stylecheck for IP_DONTFRAGMENT on Windows

* fix build flags on test file

* ci: run golangci-lint on multiple platforms

.github/workflows/lint.yml

@@ -7,6 +7,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
+          skip-pkg-cache: true
           go-version: "1.20.x"
       - name: Check that no non-test files import Ginkgo or Gomega
         run: .github/workflows/no_ginkgo.sh
@@ -28,8 +29,45 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: "1.20.x"
-      - name: golangci-lint
+      - name: golangci-lint (Linux)
         uses: golangci/golangci-lint-action@v3
         with:
+          skip-pkg-cache: true
+          args: --timeout=3m
+          version: v1.52.2
+      - name: golangci-lint (Windows)
+        if: success() || failure() # run this step even if the previous one failed
+        uses: golangci/golangci-lint-action@v3
+        env:
+          GOOS: "windows"
+        with:
+          skip-pkg-cache: true
+          args: --timeout=3m
+          version: v1.52.2
+      - name: golangci-lint (OSX)
+        if: success() || failure() # run this step even if the previous one failed
+        uses: golangci/golangci-lint-action@v3
+        env:
+          GOOS: "darwin"
+        with:
+          skip-pkg-cache: true
+          args: --timeout=3m
+          version: v1.52.2
+      - name: golangci-lint (FreeBSD)
+        if: success() || failure() # run this step even if the previous one failed
+        uses: golangci/golangci-lint-action@v3
+        env:
+          GOOS: "freebsd"
+        with:
+          skip-pkg-cache: true
+          args: --timeout=3m
+          version: v1.52.2
+      - name: golangci-lint (others)
+        if: success() || failure() # run this step even if the previous one failed
+        uses: golangci/golangci-lint-action@v3
+        env:
+          GOOS: "solaris" # some OS that we don't have any build tags for
+        with:
+          skip-pkg-cache: true
           args: --timeout=3m
           version: v1.52.2

connection.go

@@ -61,11 +61,6 @@ type cryptoStreamHandler interface {
 	ConnectionState() handshake.ConnectionState
 }
 
-type packetInfo struct {
-	addr    net.IP
-	ifIndex uint32
-}
-
 type receivedPacket struct {
 	buffer *packetBuffer
 

sys_conn_df_windows.go

@@ -12,18 +12,21 @@ import (
 )
 
 const (
-	// same for both IPv4 and IPv6 on Windows
+	// IP_DONTFRAGMENT controls the Don't Fragment (DF) bit.
+	//
+	// It's the same code point for both IPv4 and IPv6 on Windows.
 	// https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Networking/WinSock/constant.IP_DONTFRAG.html
 	// https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Networking/WinSock/constant.IPV6_DONTFRAG.html
+	//
+	//nolint:stylecheck
 	IP_DONTFRAGMENT = 14
-	IPV6_DONTFRAG   = 14
 )
 
 func setDF(rawConn syscall.RawConn) (bool, error) {
 	var errDFIPv4, errDFIPv6 error
 	if err := rawConn.Control(func(fd uintptr) {
 		errDFIPv4 = windows.SetsockoptInt(windows.Handle(fd), windows.IPPROTO_IP, IP_DONTFRAGMENT, 1)
-		errDFIPv6 = windows.SetsockoptInt(windows.Handle(fd), windows.IPPROTO_IPV6, IPV6_DONTFRAG, 1)
+		errDFIPv6 = windows.SetsockoptInt(windows.Handle(fd), windows.IPPROTO_IPV6, IP_DONTFRAGMENT, 1)
 	}); err != nil {
 		return false, err
 	}

sys_conn_no_oob.go

@@ -11,4 +11,8 @@ func newConn(c net.PacketConn, supportsDF bool) (*basicConn, error) {
 func inspectReadBuffer(any) (int, error)  { return 0, nil }
 func inspectWriteBuffer(any) (int, error) { return 0, nil }
 
+type packetInfo struct {
+	addr net.IP
+}
+
 func (i *packetInfo) OOB() []byte { return nil }

sys_conn_oob.go

@@ -264,6 +264,11 @@ func (c *oobConn) capabilities() connCapabilities {
 	return c.cap
 }
 
+type packetInfo struct {
+	addr    net.IP
+	ifIndex uint32
+}
+
 func (info *packetInfo) OOB() []byte {
 	if info == nil {
 		return nil

sys_conn_oob_test.go

@@ -1,4 +1,4 @@
-//go:build !windows
+//go:build darwin || linux || freebsd
 
 package quic
 

sys_conn_windows.go

@@ -3,6 +3,7 @@
 package quic
 
 import (
+	"net"
 	"syscall"
 
 	"golang.org/x/sys/windows"
@@ -34,4 +35,8 @@ func inspectWriteBuffer(c syscall.RawConn) (int, error) {
 	return size, serr
 }
 
+type packetInfo struct {
+	addr net.IP
+}
+
 func (i *packetInfo) OOB() []byte { return nil }