mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 04:37:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

qlog: fix logging of packets_in_flight on the metrics_updated event (#4895)

Browse source 
Resetting this value to 0 needs to be logged.
This commit is contained in:
Marten Seemann 2025-01-20 08:18:29 -08:00 • committed by GitHub
parent 88501cc02a
commit 5c545cac23
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
qlog/connection_tracer_test.go
View file

@ -624,7 +624,7 @@ func TestUpdatedMetrics(t *testing.T) {
require.Equal(t, float64(42), ev["packets_in_flight"])
}
func TestDiffForOnlyChangedMetrics(t *testing.T) {
func TestUpdatedMetricsDiff(t *testing.T) {
var rttStats utils.RTTStats
rttStats.UpdateRTT(15*time.Millisecond, 0)
rttStats.UpdateRTT(20*time.Millisecond, 0)
@ -638,9 +638,10 @@ func TestDiffForOnlyChangedMetrics(t *testing.T) {
tracer, buf := newConnectionTracer()
tracer.UpdatedMetrics(&rttStats, 4321, 1234, 42)
tracer.UpdatedMetrics(&rttStats2, 4321, 12345 /* changed */, 42)
tracer.UpdatedMetrics(&rttStats2, 0, 0, 0)
tracer.Close()
entries := exportAndParse(t, buf)
require.Len(t, entries, 2)
require.Len(t, entries, 3)
require.WithinDuration(t, time.Now(), entries[0].Time, scaleDuration(10*time.Millisecond))
require.Equal(t, "recovery:metrics_updated", entries[0].Name)
require.Len(t, entries[0].Event, 7)
@ -652,6 +653,13 @@ func TestDiffForOnlyChangedMetrics(t *testing.T) {
require.NotContains(t, ev, "packets_in_flight")
require.Equal(t, float64(12345), ev["bytes_in_flight"])
require.Equal(t, float64(15), ev["smoothed_rtt"])
ev = entries[2].Event
require.Contains(t, ev, "congestion_window")
require.Contains(t, ev, "packets_in_flight")
require.Contains(t, ev, "bytes_in_flight")
require.Zero(t, ev["bytes_in_flight"])
require.Zero(t, ev["packets_in_flight"])
require.Zero(t, ev["congestion_window"])
}
func TestLostPackets(t *testing.T) {

2
qlog/event.go
View file

@ -336,7 +336,7 @@ func (e eventMetricsUpdated) MarshalJSONObject(enc *gojay.Encoder) {
enc.Uint64Key("bytes_in_flight", uint64(e.Current.BytesInFlight))
}
if e.Last == nil || e.Last.PacketsInFlight != e.Current.PacketsInFlight {
enc.Uint64KeyOmitEmpty("packets_in_flight", uint64(e.Current.PacketsInFlight))
enc.Uint64Key("packets_in_flight", uint64(e.Current.PacketsInFlight))
}
}