mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-05 13:17:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix flaky client test

Browse source 
fixes #528
This commit is contained in:
Marten Seemann 2017-04-14 23:07:00 +07:00
parent 130620d18c
commit 7104604086
No known key found for this signature in database
GPG key ID: 3603F40B121FCDEA
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
client_test.go
View file

@ -120,15 +120,15 @@ var _ = Describe("Client", func() {
Expect(err.(*qerr.QuicError).ErrorCode).To(Equal(qerr.InvalidPacketHeader)) Expect(err.(*qerr.QuicError).ErrorCode).To(Equal(qerr.InvalidPacketHeader))
}) })
// this test requires a real session (because it calls the close callback) and a real UDP conn (because it unblocks and errors when it is closed) // this test requires a real session (because it calls the close callback)
// and a real UDP conn (because it unblocks and errors when it is closed)
It("properly closes", func(done Done) { It("properly closes", func(done Done) {
Eventually(areSessionsRunning).Should(BeFalse()) Eventually(areSessionsRunning).Should(BeFalse())
udpConn, err := net.ListenUDP("udp", &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1)}) udpConn, err := net.ListenUDP("udp", &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1)})
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
cl.conn = &conn{pconn: udpConn} cl.conn = &conn{pconn: udpConn, currentAddr: &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 1337}}
err = cl.createNewSession(nil) err = cl.createNewSession(nil)
Expect(err).NotTo(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
testErr := errors.New("test error")
Eventually(areSessionsRunning).Should(BeTrue()) Eventually(areSessionsRunning).Should(BeTrue())
var stoppedListening bool var stoppedListening bool
@ -137,6 +137,7 @@ var _ = Describe("Client", func() {
stoppedListening = true stoppedListening = true
}() }()
testErr := errors.New("test error")
err = cl.session.Close(testErr) err = cl.session.Close(testErr)
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
Eventually(func() bool { return stoppedListening }).Should(BeTrue()) Eventually(func() bool { return stoppedListening }).Should(BeTrue())