mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-06 13:47:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

don't enqueue send stream for sending on duplicate Close calls (#4815)

Browse source
This commit is contained in:
Marten Seemann 2024-12-28 16:43:16 +08:00 • committed by GitHub
parent 810ef27db5
commit 72a934f375
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
send_stream.go
View file

@ -398,7 +398,7 @@ func (s *sendStream) isNewlyCompleted() bool {
func (s *sendStream) Close() error {
s.mutex.Lock()
if s.closeForShutdownErr != nil {
if s.closeForShutdownErr != nil || s.finishedWriting {
s.mutex.Unlock()
return nil
}

2
send_stream_test.go
View file

@ -431,8 +431,6 @@ func TestSendStreamClose(t *testing.T) {
require.False(t, hasMore)
// further calls to Close don't do anything
// TODO(#4800): there shouldn't be any calls to mockSender
mockSender.EXPECT().onHasStreamData(streamID, str)
require.NoError(t, str.Close())
_, ok, hasMore = str.popStreamFrame(protocol.MaxByteCount, protocol.Version1)
require.False(t, ok)