re-add support for version 30

fixes #72

README.md

@@ -11,7 +11,7 @@ This is very much an incomplete, buggy, unperformant and insecure work in progre
 
 Done:
 
-- Basic protocol with support for QUIC version 31 and 32
+- Basic protocol with support for QUIC version 30, 31 and 32
 - HTTP/2 support
 - Crypto (RSA for signing, curve25519 for KEX, chacha20-poly1305 as cipher)
 - Basic loss detection (currently only fast retransmission) & retransmission

handshake/crypto_setup.go

@@ -165,7 +165,12 @@ func (h *CryptoSetup) isInchoateCHLO(cryptoData map[Tag][]byte) bool {
 }
 
 func (h *CryptoSetup) handleInchoateCHLO(sni string, data []byte) ([]byte, error) {
-	proof, err := h.scfg.Sign(sni, data)
+	var chloOrNil []byte
+	if h.version > protocol.VersionNumber(30) {
+		chloOrNil = data
+	}
+
+	proof, err := h.scfg.Sign(sni, chloOrNil)
 	if err != nil {
 		return nil, err
 	}

handshake/crypto_setup_test.go

@@ -133,6 +133,13 @@ var _ = Describe("Crypto setup", func() {
 			Expect(signer.gotCHLO).To(BeTrue())
 		})
 
+		It("generates REJ messages for version 30", func() {
+			cs.version = protocol.VersionNumber(30)
+			_, err := cs.handleInchoateCHLO("", sampleCHLO)
+			Expect(err).ToNot(HaveOccurred())
+			Expect(signer.gotCHLO).To(BeFalse())
+		})
+
 		It("generates SHLO messages", func() {
 			response, err := cs.handleCHLO("", []byte("chlo-data"), map[Tag][]byte{
 				TagPUBS: []byte("pubs-c"),

protocol/version.go

@@ -11,7 +11,7 @@ type VersionNumber int
 
 // SupportedVersions lists the versions that the server supports
 var SupportedVersions = []VersionNumber{
-	31, 32,
+	30, 31, 32,
 }
 
 // SupportedVersionsAsTags is needed for the SHLO crypto message

protocol/version_test.go

@@ -19,7 +19,7 @@ var _ = Describe("Version", func() {
 	})
 
 	It("has proper tag list", func() {
-		Expect(protocol.SupportedVersionsAsTags).To(Equal([]byte("Q031Q032")))
+		Expect(protocol.SupportedVersionsAsTags).To(Equal([]byte("Q030Q031Q032")))
 	})
 
 	It("recognizes supported versions", func() {