mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-05 05:07:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix flaky HTTP/3 client unit test

Browse source
This commit is contained in:
Marten Seemann 2019-10-13 06:14:49 -07:00
parent 413dd08bc6
commit 772cf9facd
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
http3/client_test.go
View file

@ -152,14 +152,14 @@ var _ = Describe("Client", func() {
decoder := qpack.NewDecoder(nil) decoder := qpack.NewDecoder(nil)
frame, err := parseNextFrame(str) frame, err := parseNextFrame(str)
Expect(err).ToNot(HaveOccurred()) ExpectWithOffset(1, err).ToNot(HaveOccurred())
Expect(frame).To(BeAssignableToTypeOf(&headersFrame{})) ExpectWithOffset(1, frame).To(BeAssignableToTypeOf(&headersFrame{}))
headersFrame := frame.(*headersFrame) headersFrame := frame.(*headersFrame)
data := make([]byte, headersFrame.Length) data := make([]byte, headersFrame.Length)
_, err = io.ReadFull(str, data) _, err = io.ReadFull(str, data)
Expect(err).ToNot(HaveOccurred()) ExpectWithOffset(1, err).ToNot(HaveOccurred())
hfs, err := decoder.DecodeFull(data) hfs, err := decoder.DecodeFull(data)
Expect(err).ToNot(HaveOccurred()) ExpectWithOffset(1, err).ToNot(HaveOccurred())
for _, p := range hfs { for _, p := range hfs {
fields[p.Name] = p.Value fields[p.Name] = p.Value
} }
@ -272,24 +272,28 @@ var _ = Describe("Client", func() {
buf := &bytes.Buffer{} buf := &bytes.Buffer{}
(&dataFrame{Length: 0x42}).Write(buf) (&dataFrame{Length: 0x42}).Write(buf)
sess.EXPECT().CloseWithError(quic.ErrorCode(errorUnexpectedFrame), gomock.Any()) sess.EXPECT().CloseWithError(quic.ErrorCode(errorUnexpectedFrame), gomock.Any())
str.EXPECT().Close().MaxTimes(1) closed := make(chan struct{})
str.EXPECT().Close().Do(func() { close(closed) })
str.EXPECT().Read(gomock.Any()).DoAndReturn(func(b []byte) (int, error) { str.EXPECT().Read(gomock.Any()).DoAndReturn(func(b []byte) (int, error) {
return buf.Read(b) return buf.Read(b)
}).AnyTimes() }).AnyTimes()
_, err := client.RoundTrip(request) _, err := client.RoundTrip(request)
Expect(err).To(MatchError("expected first frame to be a HEADERS frame")) Expect(err).To(MatchError("expected first frame to be a HEADERS frame"))
Eventually(closed).Should(BeClosed())
}) })
It("cancels the stream when the HEADERS frame is too large", func() { It("cancels the stream when the HEADERS frame is too large", func() {
buf := &bytes.Buffer{} buf := &bytes.Buffer{}
(&headersFrame{Length: 1338}).Write(buf) (&headersFrame{Length: 1338}).Write(buf)
str.EXPECT().CancelWrite(quic.ErrorCode(errorFrameError)) str.EXPECT().CancelWrite(quic.ErrorCode(errorFrameError))
str.EXPECT().Close().MaxTimes(1) closed := make(chan struct{})
str.EXPECT().Close().Do(func() { close(closed) })
str.EXPECT().Read(gomock.Any()).DoAndReturn(func(b []byte) (int, error) { str.EXPECT().Read(gomock.Any()).DoAndReturn(func(b []byte) (int, error) {
return buf.Read(b) return buf.Read(b)
}).AnyTimes() }).AnyTimes()
_, err := client.RoundTrip(request) _, err := client.RoundTrip(request)
Expect(err).To(MatchError("HEADERS frame too large: 1338 bytes (max: 1337)")) Expect(err).To(MatchError("HEADERS frame too large: 1338 bytes (max: 1337)"))
Eventually(closed).Should(BeClosed())
}) })
}) })