mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

return an error when Write is called on a closed stream

Browse source
This commit is contained in:
Marten Seemann 2017-07-29 00:10:43 +07:00
parent 3e012f77c8
commit 77d4573d9b
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
stream.go
View file

@ -180,6 +180,9 @@ func (s *stream) Write(p []byte) (int, error) {
if s.resetLocally.Get() || s.err != nil { if s.resetLocally.Get() || s.err != nil {
return 0, s.err return 0, s.err
} }
if s.finishedWriting.Get() {
return 0, fmt.Errorf("write on closed stream %d", s.streamID)
}
if len(p) == 0 { if len(p) == 0 {
return 0, nil return 0, nil
} }

6
stream_test.go
View file

@ -865,6 +865,12 @@ var _ = Describe("Stream", func() {
Expect(str.finishedWriting.Get()).To(BeTrue()) Expect(str.finishedWriting.Get()).To(BeTrue())
}) })
It("doesn't allow writes after it has been closed", func() {
str.Close()
_, err := strWithTimeout.Write([]byte("foobar"))
Expect(err).To(MatchError("write on closed stream 1337"))
})
It("allows FIN", func() { It("allows FIN", func() {
str.Close() str.Close()
Expect(str.shouldSendFin()).To(BeTrue()) Expect(str.shouldSendFin()).To(BeTrue())