mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

reject MAX_STREAMS frames with too large stream counts

Browse source
This commit is contained in:
Marten Seemann 2019-03-29 09:33:28 +01:00
parent 358fce241a
commit 7b02b87026
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/protocol/protocol.go
View file

@ -64,6 +64,10 @@ const MinStatelessResetSize = 1 /* first byte */ + 22 /* random bytes */ + 16 /*
// MinConnectionIDLenInitial is the minimum length of the destination connection ID on an Initial packet. // MinConnectionIDLenInitial is the minimum length of the destination connection ID on an Initial packet.
const MinConnectionIDLenInitial = 8 const MinConnectionIDLenInitial = 8
// MaxStreamCount is the maximum stream count value that can be sent in MAX_STREAMS frames
// and as the stream count in the transport parameters
const MaxStreamCount = 1 << 60
// DefaultAckDelayExponent is the default ack delay exponent // DefaultAckDelayExponent is the default ack delay exponent
const DefaultAckDelayExponent = 3 const DefaultAckDelayExponent = 3

4
streams_map.go
View file

@ -8,6 +8,7 @@ import (
"github.com/lucas-clemente/quic-go/internal/flowcontrol" "github.com/lucas-clemente/quic-go/internal/flowcontrol"
"github.com/lucas-clemente/quic-go/internal/handshake" "github.com/lucas-clemente/quic-go/internal/handshake"
"github.com/lucas-clemente/quic-go/internal/protocol" "github.com/lucas-clemente/quic-go/internal/protocol"
"github.com/lucas-clemente/quic-go/internal/qerr"
"github.com/lucas-clemente/quic-go/internal/wire" "github.com/lucas-clemente/quic-go/internal/wire"
) )
@ -159,6 +160,9 @@ func (m *streamsMap) GetOrOpenSendStream(id protocol.StreamID) (sendStreamI, err
} }
func (m *streamsMap) HandleMaxStreamsFrame(f *wire.MaxStreamsFrame) error { func (m *streamsMap) HandleMaxStreamsFrame(f *wire.MaxStreamsFrame) error {
if f.MaxStreams > protocol.MaxStreamCount {
return qerr.StreamLimitError
}
id := protocol.MaxStreamID(f.Type, f.MaxStreams, m.perspective) id := protocol.MaxStreamID(f.Type, f.MaxStreams, m.perspective)
switch id.Type() { switch id.Type() {
case protocol.StreamTypeUni: case protocol.StreamTypeUni:

7
streams_map_test.go
View file

@ -356,6 +356,13 @@ var _ = Describe("Streams Map", func() {
_, err = m.OpenUniStream() _, err = m.OpenUniStream()
expectTooManyStreamsError(err) expectTooManyStreamsError(err)
}) })
It("rejects MAX_STREAMS frames with too large values", func() {
Expect(m.HandleMaxStreamsFrame(&wire.MaxStreamsFrame{
Type: protocol.StreamTypeBidi,
MaxStreams: protocol.MaxStreamCount + 1,
})).To(MatchError(qerr.StreamLimitError))
})
}) })
Context("sending MAX_STREAMS frames", func() { Context("sending MAX_STREAMS frames", func() {