mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-07 06:07:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

don't generate empty STREAM frames in the send stream (#4812)

Browse source
This commit is contained in:
Marten Seemann 2024-12-28 16:21:48 +08:00 • committed by GitHub
parent 55687a684f
commit 810ef27db5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
send_stream_test.go
View file

@ -122,12 +122,11 @@ func TestSendStreamWriteData(t *testing.T) {
n, err = strWithTimeout.Write([]byte("foobaz"))
require.NoError(t, err)
require.Equal(t, 6, n)
mockFC.EXPECT().SendWindowSize().Return(protocol.MaxByteCount).Times(2)
mockFC.EXPECT().SendWindowSize().Return(protocol.MaxByteCount).Times(3)
mockFC.EXPECT().AddBytesSent(protocol.ByteCount(3)).Times(2)
// TODO(#4807): check that no empty frames are popped
// frame, ok, hasMore = str.popStreamFrame(expectedFrameHeaderLen(streamID, 10), protocol.Version1)
// require.False(t, ok)
// require.True(t, hasMore)
frame, ok, hasMore = str.popStreamFrame(expectedFrameHeaderLen(streamID, 10), protocol.Version1)
require.False(t, ok)
require.True(t, hasMore)
frame, ok, hasMore = str.popStreamFrame(expectedFrameHeaderLen(streamID, 10)+3, protocol.Version1)
require.True(t, ok)
require.True(t, hasMore)