diff --git a/internal/handshake/tls_extension_handler_client.go b/internal/handshake/tls_extension_handler_client.go index 37eb6a95..431c62b3 100644 --- a/internal/handshake/tls_extension_handler_client.go +++ b/internal/handshake/tls_extension_handler_client.go @@ -66,17 +66,12 @@ func (h *extensionHandlerClient) Receive(hType mint.HandshakeType, el *mint.Exte return err } - if hType != mint.HandshakeTypeEncryptedExtensions && hType != mint.HandshakeTypeNewSessionTicket { + if hType != mint.HandshakeTypeEncryptedExtensions { if found { return fmt.Errorf("Unexpected QUIC extension in handshake message %d", hType) } return nil } - if hType == mint.HandshakeTypeNewSessionTicket { - // the extension it's optional in the NewSessionTicket message - // TODO: handle this - return nil - } // hType == mint.HandshakeTypeEncryptedExtensions if !found { diff --git a/internal/handshake/tls_extension_handler_client_test.go b/internal/handshake/tls_extension_handler_client_test.go index d0a0e329..61d50e88 100644 --- a/internal/handshake/tls_extension_handler_client_test.go +++ b/internal/handshake/tls_extension_handler_client_test.go @@ -120,14 +120,6 @@ var _ = Describe("TLS Extension Handler, for the client", func() { Expect(err).ToNot(HaveOccurred()) }) - // TODO: fix this when implementing the NewSessionTicket - It("ignors the TransportParameters in the NewSessionTicket message", func() { - err := el.Add(fakeBody) - Expect(err).ToNot(HaveOccurred()) - err = handler.Receive(mint.HandshakeTypeNewSessionTicket, &el) - Expect(err).ToNot(HaveOccurred()) - }) - It("errors when it can't parse the TransportParameters", func() { err := el.Add(fakeBody) Expect(err).ToNot(HaveOccurred())