mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

http3: correctly handle closed clients (#3684)

Browse source 
* http3: use a mock roundTripCloser in tests

* http3: correctly handle failed clients

Specifically,
* immediately remove a client when a request errored
* if that error was an idle error, and the client was a reused client
(from an earlier request that already completed the handshake),
re-dial the connection
This commit is contained in:
Marten Seemann 2023-01-28 00:49:52 -08:00 • committed by GitHub
parent 7b2c69451e
commit 89769f409f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 336 additions and 147 deletions
Download patch file Download diff file Expand all files Collapse all files

16
http3/client.go
View file

@ -68,7 +68,9 @@ type client struct {
logger utils.Logger
}
func newClient(hostname string, tlsConf *tls.Config, opts *roundTripperOpts, conf *quic.Config, dialer dialFunc) (*client, error) {
var _ roundTripCloser = &client{}
func newClient(hostname string, tlsConf *tls.Config, opts *roundTripperOpts, conf *quic.Config, dialer dialFunc) (roundTripCloser, error) {
if conf == nil {
conf = defaultQuicConfig.Clone()
} else if len(conf.Versions) == 0 {
@ -434,3 +436,15 @@ func (c *client) doRequest(req *http.Request, str quic.Stream, opt RoundTripOpt,
return res, requestError{}
}
func (c *client) HandshakeComplete() bool {
if c.conn == nil {
return false
}
select {
case <-c.conn.HandshakeComplete().Done():
return true
default:
return false
}
}