From 8d91ad9fcd02d818424401bcc21a78d4e151c7d5 Mon Sep 17 00:00:00 2001 From: Jean-Francois Giorgi Date: Wed, 23 Aug 2023 05:12:08 +0200 Subject: [PATCH] move QUIC_GO_DISABLE_GSO check out of init (#4041) * move QUIC_GO_DISABLE_GSO test out of init(). * Update sys_conn_helper_linux.go --------- Co-authored-by: Marten Seemann --- sys_conn_helper_linux.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/sys_conn_helper_linux.go b/sys_conn_helper_linux.go index 5bda2286..6a049241 100644 --- a/sys_conn_helper_linux.go +++ b/sys_conn_helper_linux.go @@ -14,15 +14,6 @@ import ( "golang.org/x/sys/unix" ) -var gsoDisabled bool - -func init() { - disabled, err := strconv.ParseBool(os.Getenv("QUIC_GO_DISABLE_GSO")) - if err == nil { - gsoDisabled = disabled - } -} - const ( msgTypeIPTOS = unix.IP_TOS ipv4PKTINFO = unix.IP_PKTINFO @@ -65,7 +56,8 @@ func parseIPv4PktInfo(body []byte) (ip netip.Addr, ifIndex uint32, ok bool) { // isGSOSupported tests if the kernel supports GSO. // Sending with GSO might still fail later on, if the interface doesn't support it (see isGSOError). func isGSOSupported(conn syscall.RawConn) bool { - if gsoDisabled { + disabled, err := strconv.ParseBool(os.Getenv("QUIC_GO_DISABLE_GSO")) + if err == nil && disabled { return false } var serr error