mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-05 13:17:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

http3: close the connection when closing the roundtripper (#3873)

Browse source
This commit is contained in:
Glonee 2023-06-01 16:06:13 +08:00 • committed by GitHub
parent c96fbd2e4a
commit 9237dbb167
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
http3/roundtrip.go
View file

@ -239,7 +239,12 @@ func (r *RoundTripper) Close() error {
} }
r.clients = nil r.clients = nil
if r.transport != nil { if r.transport != nil {
r.transport.Close() if err := r.transport.Close(); err != nil {
return err
}
if err := r.transport.Conn.Close(); err != nil {
return err
}
r.transport = nil r.transport = nil
} }
return nil return nil

2
integrationtests/self/hotswap_test.go
View file

@ -98,7 +98,7 @@ var _ = Describe("HTTP3 Server hotswap test", func() {
}) })
AfterEach(func() { AfterEach(func() {
rt.Close() Expect(rt.Close()).NotTo(HaveOccurred())
Expect(ln.Close()).NotTo(HaveOccurred()) Expect(ln.Close()).NotTo(HaveOccurred())
}) })

2
integrationtests/self/http_test.go
View file

@ -106,7 +106,7 @@ var _ = Describe("HTTP tests", func() {
}) })
AfterEach(func() { AfterEach(func() {
rt.Close() Expect(rt.Close()).NotTo(HaveOccurred())
Expect(server.Close()).NotTo(HaveOccurred()) Expect(server.Close()).NotTo(HaveOccurred())
Eventually(stoppedServing).Should(BeClosed()) Eventually(stoppedServing).Should(BeClosed())
}) })