mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

congestion: fix overflow when calculating the pacing budget (#3796)

Browse source
This commit is contained in:
Marten Seemann 2023-05-01 14:32:20 +02:00 • committed by GitHub
parent c0b94ee4b0
commit 94829edf35
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/congestion/pacer_test.go
View file

@ -1,6 +1,7 @@
package congestion
import (
"math/rand"
"time"
"github.com/quic-go/quic-go/internal/protocol"
@ -128,4 +129,13 @@ var _ = Describe("Pacer", func() {
Expect(p.TimeUntilSend()).To(Equal(t.Add(protocol.MinPacingDelay)))
Expect(p.Budget(t.Add(protocol.MinPacingDelay))).To(Equal(protocol.ByteCount(protocol.MinPacingDelay) * initialMaxDatagramSize * 1e6 / 1e9))
})
It("protects against overflows", func() {
p = newPacer(func() Bandwidth { return infBandwidth })
t := time.Now()
p.SentPacket(t, initialMaxDatagramSize)
for i := 0; i < 1e5; i++ {
Expect(p.Budget(t.Add(time.Duration(rand.Int63())))).To(BeNumerically(">=", 0))
}
})
})