mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

http3: use the AdditionalSettings for requests (#4156)

Browse source
This commit is contained in:
Marten Seemann 2023-12-06 19:52:23 +05:30 • committed by GitHub
parent 45922f76d6
commit 9b40c50a73
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
http3/roundtrip.go
View file

@ -202,6 +202,7 @@ func (r *RoundTripper) getClient(hostname string, onlyCached bool) (rtc *roundTr
MaxHeaderBytes: r.MaxResponseHeaderBytes, MaxHeaderBytes: r.MaxResponseHeaderBytes,
StreamHijacker: r.StreamHijacker, StreamHijacker: r.StreamHijacker,
UniStreamHijacker: r.UniStreamHijacker, UniStreamHijacker: r.UniStreamHijacker,
AdditionalSettings: r.AdditionalSettings,
}, },
r.QuicConfig, r.QuicConfig,
dial, dial,

15
http3/roundtrip_test.go
View file

@ -71,6 +71,21 @@ var _ = Describe("RoundTripper", func() {
Expect(err).To(MatchError(testErr)) Expect(err).To(MatchError(testErr))
}) })
It("creates new clients with additional settings", func() {
testErr := errors.New("test err")
req, err := http.NewRequest("GET", "https://quic.clemente.io/foobar.html", nil)
Expect(err).ToNot(HaveOccurred())
rt.AdditionalSettings = map[uint64]uint64{1337: 42}
rt.newClient = func(_ string, _ *tls.Config, opts *roundTripperOpts, conf *quic.Config, _ dialFunc) (roundTripCloser, error) {
cl := NewMockRoundTripCloser(mockCtrl)
cl.EXPECT().RoundTripOpt(gomock.Any(), gomock.Any()).Return(nil, testErr)
Expect(opts.AdditionalSettings).To(HaveKeyWithValue(uint64(1337), uint64(42)))
return cl, nil
}
_, err = rt.RoundTrip(req)
Expect(err).To(MatchError(testErr))
})
It("uses the quic.Config, if provided", func() { It("uses the quic.Config, if provided", func() {
config := &quic.Config{HandshakeIdleTimeout: time.Millisecond} config := &quic.Config{HandshakeIdleTimeout: time.Millisecond}
var receivedConfig *quic.Config var receivedConfig *quic.Config