mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

use a chan instead of a context in Connection.HandshakeComplete (#3709)

Browse source
This commit is contained in:
Marten Seemann 2023-03-27 00:51:56 +11:00 • committed by GitHub
parent 41ddaa0262
commit a4b0265628
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 66 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

10
connection_test.go
View file

@ -1834,9 +1834,9 @@ var _ = Describe("Connection", func() {
conn.run()
}()
handshakeCtx := conn.HandshakeComplete()
Consistently(handshakeCtx.Done()).ShouldNot(BeClosed())
Consistently(handshakeCtx).ShouldNot(BeClosed())
close(finishHandshake)
Eventually(handshakeCtx.Done()).Should(BeClosed())
Eventually(handshakeCtx).Should(BeClosed())
// make sure the go routine returns
streamManager.EXPECT().CloseWithError(gomock.Any())
expectReplaceWithClosed()
@ -1865,7 +1865,7 @@ var _ = Describe("Connection", func() {
}()
handshakeCtx := conn.HandshakeComplete()
Consistently(handshakeCtx.Done()).ShouldNot(BeClosed())
Consistently(handshakeCtx).ShouldNot(BeClosed())
close(finishHandshake)
var frames []*ackhandler.Frame
Eventually(func() []*ackhandler.Frame {
@ -1908,10 +1908,10 @@ var _ = Describe("Connection", func() {
conn.run()
}()
handshakeCtx := conn.HandshakeComplete()
Consistently(handshakeCtx.Done()).ShouldNot(BeClosed())
Consistently(handshakeCtx).ShouldNot(BeClosed())
mconn.EXPECT().Write(gomock.Any())
conn.closeLocal(errors.New("handshake error"))
Consistently(handshakeCtx.Done()).ShouldNot(BeClosed())
Consistently(handshakeCtx).ShouldNot(BeClosed())
Eventually(conn.Context().Done()).Should(BeClosed())
})