mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

restart the loss detection timer when the server becomes unblocked

Browse source
This commit is contained in:
Marten Seemann 2021-03-29 09:39:58 +07:00
parent 3fab321ea7
commit a695bae019
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/ackhandler/sent_packet_handler.go
View file

@ -194,7 +194,11 @@ func (h *sentPacketHandler) dropPackets(encLevel protocol.EncryptionLevel) {
} }
func (h *sentPacketHandler) ReceivedBytes(n protocol.ByteCount) { func (h *sentPacketHandler) ReceivedBytes(n protocol.ByteCount) {
wasAmplificationLimit := h.isAmplificationLimited()
h.bytesReceived += n h.bytesReceived += n
if wasAmplificationLimit && !h.isAmplificationLimited() {
h.setLossDetectionTimer()
}
} }
func (h *sentPacketHandler) ReceivedPacket(encLevel protocol.EncryptionLevel) { func (h *sentPacketHandler) ReceivedPacket(encLevel protocol.EncryptionLevel) {

6
internal/ackhandler/sent_packet_handler_test.go
View file

@ -828,7 +828,7 @@ var _ = Describe("SentPacketHandler", func() {
Expect(handler.SendMode()).To(Equal(SendNone)) Expect(handler.SendMode()).To(Equal(SendNone))
}) })
It("cancels the loss detection timer when it is amplification limited", func() { It("cancels the loss detection timer when it is amplification limited, and resets it when becoming unblocked", func() {
handler.ReceivedBytes(300) handler.ReceivedBytes(300)
handler.SentPacket(&Packet{ handler.SentPacket(&Packet{
PacketNumber: 1, PacketNumber: 1,
@ -837,7 +837,11 @@ var _ = Describe("SentPacketHandler", func() {
Frames: []Frame{{Frame: &wire.PingFrame{}}}, Frames: []Frame{{Frame: &wire.PingFrame{}}},
SendTime: time.Now(), SendTime: time.Now(),
}) })
// Amplification limited. We don't need to set a timer now.
Expect(handler.GetLossDetectionTimeout()).To(BeZero()) Expect(handler.GetLossDetectionTimeout()).To(BeZero())
// Unblock the server. Now we should fire up the timer.
handler.ReceivedBytes(1)
Expect(handler.GetLossDetectionTimeout()).ToNot(BeZero())
}) })
}) })