mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

add a message to crypto errors

Browse source 
The string representation varies depending on the message:
* if there's no message, the TLS alert is used
* if there's a message, it is used instead
This commit is contained in:
Marten Seemann 2019-03-07 15:11:01 +09:00
parent 373db3c153
commit ae12852e4c
3 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/handshake/crypto_setup.go
View file

@ -462,7 +462,7 @@ func (h *cryptoSetup) WriteRecord(p []byte) (int, error) {
}
func (h *cryptoSetup) SendAlert(alert uint8) {
h.alertChan <- qerr.CryptoError(alert)
h.alertChan <- qerr.CryptoError(alert, "")
}
func (h *cryptoSetup) GetSealer() (protocol.EncryptionLevel, Sealer) {

5
internal/qerr/quic_error.go
View file

@ -31,9 +31,10 @@ func TimeoutError(errorMessage string) *QuicError {
}
// CryptoError create a new QuicError instance for a crypto error
func CryptoError(tlsAlert uint8) *QuicError {
func CryptoError(tlsAlert uint8, errorMessage string) *QuicError {
return &QuicError{
ErrorCode: 0x100 + ErrorCode(tlsAlert),
ErrorCode: 0x100 + ErrorCode(tlsAlert),
ErrorMessage: errorMessage,
}
}

9
internal/qerr/quic_error_test.go
View file

@ -25,8 +25,13 @@ var _ = Describe("QUIC Transport Errors", func() {
Expect(err.Error()).To(Equal("NO_ERROR: foobar"))
})
It("has a string representation for crypto errors", func() {
err := CryptoError(42)
It("has a string representation for crypto errors with a message", func() {
err := CryptoError(42, "foobar")
Expect(err.Error()).To(Equal("CRYPTO_ERROR: foobar"))
})
It("has a string representation for crypto errors without a message", func() {
err := CryptoError(42, "")
Expect(err.Error()).To(Equal("CRYPTO_ERROR: tls: bad certificate"))
})