mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-05 13:17:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

introduce a StreamLimitReachedError for Connection.Open{Uni}Stream (#4579)

Browse source 
Using a concrete type is preferable to relying on interpreting the
return values from net.Error.Timeout and net.Error.Temporary, especially
since the latter has been deprecated since Go 1.18.
This commit is contained in:
Marten Seemann 2024-06-28 06:58:28 -07:00 • committed by GitHub
parent 7379f1fd5e
commit b52c33939d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 35 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

7
streams_map_test.go
View file

@ -33,11 +33,14 @@ type streamMapping struct {
}
func expectTooManyStreamsError(err error) {
ExpectWithOffset(1, err).To(HaveOccurred())
ExpectWithOffset(1, err.Error()).To(Equal(errTooManyOpenStreams.Error()))
ExpectWithOffset(1, err).To(MatchError(&StreamLimitReachedError{}))
nerr, ok := err.(net.Error)
ExpectWithOffset(1, ok).To(BeTrue())
ExpectWithOffset(1, nerr.Timeout()).To(BeFalse())
//nolint:staticcheck // SA1019
// In older versions of quic-go, the stream limit error was documented to be a net.Error.Temporary.
// This function was since deprecated, but we keep the existing behavior.
ExpectWithOffset(1, nerr.Temporary()).To(BeTrue())
}
var _ = Describe("Streams Map", func() {