mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

limit the exponential PTO backoff to 60s (#3595)

Browse source
This commit is contained in:
cliffc-spirent 2022-11-15 13:42:35 -10:00 • committed by GitHub
parent f2d3cb8f43
commit b8447041bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/ackhandler/sent_packet_handler_test.go
View file

@ -687,6 +687,14 @@ var _ = Describe("SentPacketHandler", func() {
handler.ptoCount = 2
handler.setLossDetectionTimer()
Expect(handler.GetLossDetectionTimeout().Sub(sendTime)).To(Equal(4 * timeout))
// truncated when the exponential gets too large
handler.ptoCount = 20
handler.setLossDetectionTimer()
Expect(handler.GetLossDetectionTimeout().Sub(sendTime)).To(Equal(maxPTODuration))
// protected from rollover
handler.ptoCount = 100
handler.setLossDetectionTimer()
Expect(handler.GetLossDetectionTimeout().Sub(sendTime)).To(Equal(maxPTODuration))
})
It("reset the PTO count when receiving an ACK", func() {
@ -1036,7 +1044,7 @@ var _ = Describe("SentPacketHandler", func() {
})
It("correctly sets the timer after the Initial packet number space has been dropped", func() {
handler.SentPacket(initialPacket(&Packet{PacketNumber: 1, SendTime: time.Now().Add(-42 * time.Second)}))
handler.SentPacket(initialPacket(&Packet{PacketNumber: 1, SendTime: time.Now().Add(-19 * time.Second)}))
_, err := handler.ReceivedAck(
&wire.AckFrame{AckRanges: []wire.AckRange{{Smallest: 1, Largest: 1}}},
protocol.EncryptionInitial,
@ -1048,6 +1056,8 @@ var _ = Describe("SentPacketHandler", func() {
pto := handler.rttStats.PTO(false)
Expect(pto).ToNot(BeZero())
// pto is approximately 19 * 3. Using a number > 19 above will
// run into the maxPTODuration limit
Expect(handler.GetLossDetectionTimeout()).To(BeTemporally("~", time.Now().Add(pto), 10*time.Millisecond))
})