mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2228 from lucas-clemente/fix-pto-for-dropped-pn-spaces

Browse source 
reset the loss detection timer when dropping a packet number space
This commit is contained in:
Marten Seemann 2019-11-24 21:11:46 +07:00 • committed by GitHub
commit c46c72aae8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/ackhandler/sent_packet_handler.go
View file

@ -120,6 +120,8 @@ func (h *sentPacketHandler) DropPackets(encLevel protocol.EncryptionLevel) {
default:
panic(fmt.Sprintf("Cannot drop keys for encryption level %s", encLevel))
}
h.setLossDetectionTimer()
h.ptoMode = SendNone
}
func (h *sentPacketHandler) SentPacket(packet *Packet) {

22
internal/ackhandler/sent_packet_handler_test.go
View file

@ -590,6 +590,28 @@ var _ = Describe("SentPacketHandler", func() {
Expect(handler.GetLossDetectionTimeout().Sub(sendTime)).To(Equal(4 * timeout))
})
It("resets the PTO mode when a packet number space is dropped", func() {
now := time.Now()
handler.SentPacket(ackElicitingPacket(&Packet{
PacketNumber: 1,
EncryptionLevel: protocol.EncryptionHandshake,
SendTime: now.Add(-2 * time.Hour),
}))
handler.SentPacket(ackElicitingPacket(&Packet{
PacketNumber: 2,
SendTime: now.Add(-time.Hour),
}))
// PTO timer based on the Handshake packet
Expect(handler.GetLossDetectionTimeout()).To(BeTemporally("~", now.Add(-2*time.Hour), time.Second))
Expect(handler.OnLossDetectionTimeout()).To(Succeed())
Expect(handler.SendMode()).To(Equal(SendPTOHandshake))
handler.SetHandshakeComplete()
handler.DropPackets(protocol.EncryptionHandshake)
// PTO timer based on the 1-RTT packet
Expect(handler.GetLossDetectionTimeout()).To(BeTemporally("~", now.Add(-time.Hour), time.Second))
Expect(handler.SendMode()).ToNot(Equal(SendPTOHandshake))
})
It("allows two 1-RTT PTOs", func() {
handler.SetHandshakeComplete()
var lostPackets []protocol.PacketNumber