mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix flaky accept queue test (#4280)

Browse source
This commit is contained in:
Marten Seemann 2024-01-29 11:14:02 +07:00 • committed by GitHub
parent 808f849ca2
commit c82c37a31c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
server_test.go
View file

@ -1289,6 +1289,8 @@ var _ = Describe("Server", func() {
It("rejects new connection attempts if the accept queue is full", func() { It("rejects new connection attempts if the accept queue is full", func() {
connChan := make(chan *MockQUICConn, 1) connChan := make(chan *MockQUICConn, 1)
var wg sync.WaitGroup // to make sure the test fully completes
wg.Add(protocol.MaxAcceptQueueSize + 1)
serv.baseServer.newConn = func( serv.baseServer.newConn = func(
_ sendConn, _ sendConn,
runner connRunner, runner connRunner,
@ -1308,6 +1310,7 @@ var _ = Describe("Server", func() {
_ utils.Logger, _ utils.Logger,
_ protocol.VersionNumber, _ protocol.VersionNumber,
) quicConn { ) quicConn {
defer wg.Done()
ready := make(chan struct{}) ready := make(chan struct{})
close(ready) close(ready)
conn := <-connChan conn := <-connChan
@ -1341,6 +1344,7 @@ var _ = Describe("Server", func() {
conn.EXPECT().closeWithTransportError(ConnectionRefused) conn.EXPECT().closeWithTransportError(ConnectionRefused)
connChan <- conn connChan <- conn
serv.baseServer.handlePacket(getInitialWithRandomDestConnID()) serv.baseServer.handlePacket(getInitialWithRandomDestConnID())
wg.Wait()
}) })
It("doesn't accept new connections if they were closed in the mean time", func() { It("doesn't accept new connections if they were closed in the mean time", func() {