mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 04:37:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

remove the error return value from Stream.CancelRead

Browse source
This commit is contained in:
Marten Seemann 2019-01-24 09:31:34 +07:00
parent 3808191679
commit ca939df44e
7 changed files with 22 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

18
receive_stream_test.go
View file

@ -458,21 +458,21 @@ var _ = Describe("Receive Stream", func() {
close(done)
}()
Consistently(done).ShouldNot(BeClosed())
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
Eventually(done).Should(BeClosed())
})
It("doesn't allow further calls to Read", func() {
mockSender.EXPECT().queueControlFrame(gomock.Any())
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
_, err := strWithTimeout.Read([]byte{0})
Expect(err).To(MatchError("Read on stream 1337 canceled with error code 1234"))
})
It("does nothing when CancelRead is called twice", func() {
mockSender.EXPECT().queueControlFrame(gomock.Any())
Expect(str.CancelRead(1234)).To(Succeed())
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
str.CancelRead(1234)
_, err := strWithTimeout.Read([]byte{0})
Expect(err).To(MatchError("Read on stream 1337 canceled with error code 1234"))
})
@ -482,7 +482,7 @@ var _ = Describe("Receive Stream", func() {
StreamID: streamID,
ErrorCode: 1234,
})
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
})
It("doesn't send a STOP_SENDING frame, if the FIN was already read", func() {
@ -497,7 +497,7 @@ var _ = Describe("Receive Stream", func() {
mockSender.EXPECT().onStreamCompleted(streamID)
_, err := strWithTimeout.Read(make([]byte, 100))
Expect(err).To(MatchError(io.EOF))
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
})
It("doesn't send a STOP_SENDING frame, if the stream was already reset", func() {
@ -510,7 +510,7 @@ var _ = Describe("Receive Stream", func() {
StreamID: streamID,
ByteOffset: 42,
})).To(Succeed())
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
})
It("sends a STOP_SENDING and completes the stream after receiving the final offset", func() {
@ -522,12 +522,12 @@ var _ = Describe("Receive Stream", func() {
mockFC.EXPECT().Abandon()
mockSender.EXPECT().queueControlFrame(gomock.Any())
mockSender.EXPECT().onStreamCompleted(streamID)
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
})
It("completes the stream when receiving the FinBit after the stream was canceled", func() {
mockSender.EXPECT().queueControlFrame(gomock.Any())
Expect(str.CancelRead(1234)).To(Succeed())
str.CancelRead(1234)
gomock.InOrder(
mockFC.EXPECT().UpdateHighestReceived(protocol.ByteCount(1000), true),
mockFC.EXPECT().Abandon(),