mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-06 13:47:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

send out the CONNECTION_REFUSED error when refusing a connection (#4250)

Browse source 
So far, we used Connection.destroy, which destroys a connection without
sending out a CONNECTION_CLOSE frame. This is useful (for example) when
receiving a stateless reset, but it's not what we want when the server
refuses an incoming connection. In this case, we want to send out a
packet with a CONNECTION_CLOSE frame to inform the client that the
connection attempt is being rejected.
This commit is contained in:
Marten Seemann 2024-01-18 22:29:22 -08:00 • committed by GitHub
parent b3eb375bc1
commit cb1775a08a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 129 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
server_test.go
View file

@ -327,7 +327,7 @@ var _ = Describe("Server", func() {
Eventually(run).Should(BeClosed())
Eventually(done).Should(BeClosed())
// shutdown
conn.EXPECT().destroy(gomock.Any())
conn.EXPECT().closeWithTransportError(gomock.Any())
})
It("sends a Version Negotiation Packet for unsupported versions", func() {
@ -530,7 +530,7 @@ var _ = Describe("Server", func() {
Eventually(run).Should(BeClosed())
Eventually(done).Should(BeClosed())
// shutdown
conn.EXPECT().destroy(gomock.Any()).MaxTimes(1)
conn.EXPECT().closeWithTransportError(gomock.Any()).MaxTimes(1)
})
It("drops packets if the receive queue is full", func() {
@ -570,7 +570,7 @@ var _ = Describe("Server", func() {
conn.EXPECT().Context().Return(context.Background()).MaxTimes(1)
conn.EXPECT().HandshakeComplete().Return(make(chan struct{})).MaxTimes(1)
// shutdown
conn.EXPECT().destroy(gomock.Any()).MaxTimes(1)
conn.EXPECT().closeWithTransportError(gomock.Any()).MaxTimes(1)
return conn
}
@ -1008,7 +1008,7 @@ var _ = Describe("Server", func() {
) quicConn {
conn := NewMockQUICConn(mockCtrl)
conn.EXPECT().handlePacket(gomock.Any())
conn.EXPECT().destroy(&qerr.TransportError{ErrorCode: ConnectionRefused}).Do(func(error) { close(destroyed) })
conn.EXPECT().closeWithTransportError(ConnectionRefused).Do(func(TransportErrorCode) { close(destroyed) })
conn.EXPECT().HandshakeComplete().Return(make(chan struct{}))
conn.EXPECT().run().MaxTimes(1)
conn.EXPECT().Context().Return(context.Background())
@ -1468,7 +1468,7 @@ var _ = Describe("Server", func() {
conn.EXPECT().Context().Return(context.Background())
close(called)
// shutdown
conn.EXPECT().destroy(gomock.Any())
conn.EXPECT().closeWithTransportError(gomock.Any())
return conn
}