mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

remove unneeded tracking of acknowledgments for PATH_CHALLENGEs (#4959)

Browse source
This commit is contained in:
Marten Seemann 2025-02-16 04:37:12 +01:00 • committed by GitHub
parent 9f704c72cf
commit d726a795db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
path_manager.go
View file

@ -19,7 +19,6 @@ type path struct {
pathChallenge [8]byte pathChallenge [8]byte
validated bool validated bool
rcvdNonProbing bool rcvdNonProbing bool
acked bool
} }
type pathManager struct { type pathManager struct {
@ -119,16 +118,7 @@ type pathManagerAckHandler pathManager
var _ ackhandler.FrameHandler = &pathManagerAckHandler{} var _ ackhandler.FrameHandler = &pathManagerAckHandler{}
// Acknowledging the frame doesn't validate the path, only receiving the PATH_RESPONSE does. // Acknowledging the frame doesn't validate the path, only receiving the PATH_RESPONSE does.
// However, it means that we don't need to retransmit the PATH_CHALLENGE. func (pm *pathManagerAckHandler) OnAcked(f wire.Frame) {}
func (pm *pathManagerAckHandler) OnAcked(f wire.Frame) {
pc := f.(*wire.PathChallengeFrame)
for _, path := range pm.paths {
if path.pathChallenge == pc.Data {
path.acked = true
break
}
}
}
func (pm *pathManagerAckHandler) OnLost(f wire.Frame) { func (pm *pathManagerAckHandler) OnLost(f wire.Frame) {
// TODO: retransmit the packet the first time it is lost // TODO: retransmit the packet the first time it is lost