mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

don't negotiate the maximum incoming streams value

Browse source 
The maximum number of incoming streams doesn't need to be negotiated. It
is a value that is only announced by the peer, and has to be respected.
Furthermore, Chrome doesn't seem to care about the MSPC value anymore
(since MIDS was introduced), so there's no need to send this in the
handshake any more.
This commit is contained in:
Marten Seemann 2017-10-15 09:23:42 +08:00
parent a816d5a12e
commit daff6256b9
7 changed files with 19 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

15
streams_map_test.go
View file

@ -11,10 +11,7 @@ import (
)
var _ = Describe("Streams Map", func() {
const (
maxIncomingStreams = 75
maxOutgoingStreams = 60
)
const maxOutgoingStreams = 60
var (
m *streamsMap
@ -23,9 +20,7 @@ var _ = Describe("Streams Map", func() {
setNewStreamsMap := func(p protocol.Perspective) {
mockPn = mocks.NewMockParamsNegotiator(mockCtrl)
mockPn.EXPECT().GetMaxOutgoingStreams().AnyTimes().Return(uint32(maxOutgoingStreams))
mockPn.EXPECT().GetMaxIncomingStreams().AnyTimes().Return(uint32(maxIncomingStreams))
newStream := func(id protocol.StreamID) *stream {
return newStream(id, func() {}, nil, nil)
@ -113,21 +108,21 @@ var _ = Describe("Streams Map", func() {
Context("counting streams", func() {
It("errors when too many streams are opened", func() {
for i := 0; i < maxIncomingStreams; i++ {
for i := uint32(0); i < m.maxIncomingStreams; i++ {
_, err := m.GetOrOpenStream(protocol.StreamID(i*2 + 1))
Expect(err).NotTo(HaveOccurred())
}
_, err := m.GetOrOpenStream(protocol.StreamID(2*maxIncomingStreams + 3))
_, err := m.GetOrOpenStream(protocol.StreamID(2*m.maxIncomingStreams + 3))
Expect(err).To(MatchError(qerr.TooManyOpenStreams))
})
It("errors when too many streams are opened implicitely", func() {
_, err := m.GetOrOpenStream(protocol.StreamID(maxIncomingStreams*2 + 1))
_, err := m.GetOrOpenStream(protocol.StreamID(m.maxIncomingStreams*2 + 1))
Expect(err).To(MatchError(qerr.TooManyOpenStreams))
})
It("does not error when many streams are opened and closed", func() {
for i := 2; i < 10*maxIncomingStreams; i++ {
for i := uint32(2); i < 10*m.maxIncomingStreams; i++ {
str, err := m.GetOrOpenStream(protocol.StreamID(i*2 + 1))
Expect(err).NotTo(HaveOccurred())
deleteStream(str.StreamID())