From f54a32ec28f5588e9e206326ea7d536fd87a9da0 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Fri, 9 Feb 2024 11:53:24 +0700 Subject: [PATCH] don't preallocate the slice for STREAM frames when composing a packet (#4314) The slice will be allocated when STREAM frames are appended. By not preallocating it is made sure that the slice is only created in cases where STREAM frames are actually sent in this packet. --- packet_packer.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packet_packer.go b/packet_packer.go index 5b055de7..e707734f 100644 --- a/packet_packer.go +++ b/packet_packer.go @@ -589,12 +589,11 @@ func (p *packetPacker) composeNextPacket(maxFrameSize protocol.ByteCount, onlyAc return payload{} } - pl := payload{streamFrames: make([]ackhandler.StreamFrame, 0, 1)} - hasData := p.framer.HasData() hasRetransmission := p.retransmissionQueue.HasAppData() var hasAck bool + var pl payload if ackAllowed { if ack := p.acks.GetAckFrame(protocol.Encryption1RTT, !hasRetransmission && !hasData); ack != nil { pl.ack = ack