mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

add a callback to block window increases to the connection flow controller

Browse source
This commit is contained in:
Marten Seemann 2022-01-14 11:27:43 +04:00
parent a98e60c28c
commit f9904c7c45
5 changed files with 75 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

31
internal/flowcontrol/connection_flow_controller_test.go
View file

@ -27,6 +27,7 @@ var _ = Describe("Connection Flow controller", func() {
controller.rttStats = &utils.RTTStats{}
controller.logger = utils.DefaultLogger
controller.queueWindowUpdate = func() { queuedWindowUpdate = true }
controller.allowWindowIncrease = func(protocol.ByteCount) bool { return true }
})
Context("Constructor", func() {
@ -36,7 +37,13 @@ var _ = Describe("Connection Flow controller", func() {
receiveWindow := protocol.ByteCount(2000)
maxReceiveWindow := protocol.ByteCount(3000)
fc := NewConnectionFlowController(receiveWindow, maxReceiveWindow, nil, rttStats, utils.DefaultLogger).(*connectionFlowController)
fc := NewConnectionFlowController(
receiveWindow,
maxReceiveWindow,
nil,
func(protocol.ByteCount) bool { return true },
rttStats,
utils.DefaultLogger).(*connectionFlowController)
Expect(fc.receiveWindow).To(Equal(receiveWindow))
Expect(fc.maxReceiveWindowSize).To(Equal(maxReceiveWindow))
})
@ -78,6 +85,11 @@ var _ = Describe("Connection Flow controller", func() {
})
It("auto-tunes the window", func() {
var allowed protocol.ByteCount
controller.allowWindowIncrease = func(size protocol.ByteCount) bool {
allowed = size
return true
}
oldOffset := controller.bytesRead
oldWindowSize := controller.receiveWindowSize
rtt := scaleDuration(20 * time.Millisecond)
@ -90,6 +102,23 @@ var _ = Describe("Connection Flow controller", func() {
newWindowSize := controller.receiveWindowSize
Expect(newWindowSize).To(Equal(2 * oldWindowSize))
Expect(offset).To(Equal(oldOffset + dataRead + newWindowSize))
Expect(allowed).To(Equal(oldWindowSize))
})
It("doesn't auto-tune the window if it's not allowed", func() {
controller.allowWindowIncrease = func(protocol.ByteCount) bool { return false }
oldOffset := controller.bytesRead
oldWindowSize := controller.receiveWindowSize
rtt := scaleDuration(20 * time.Millisecond)
setRtt(rtt)
controller.epochStartTime = time.Now().Add(-time.Millisecond)
controller.epochStartOffset = oldOffset
dataRead := oldWindowSize/2 + 1
controller.AddBytesRead(dataRead)
offset := controller.GetWindowUpdate()
newWindowSize := controller.receiveWindowSize
Expect(newWindowSize).To(Equal(oldWindowSize))
Expect(offset).To(Equal(oldOffset + dataRead + newWindowSize))
})
})
})