Lucas Clemente
eeb2d8d821
Mock FlowControlManager using gomock
2017-06-08 16:06:31 +02:00
Lucas Clemente
f2959aa74a
Simplify session closing
2017-06-07 11:41:03 +02:00
Lucas Clemente
4f93969101
Run gosimple on our tree
2017-06-06 09:33:46 +02:00
Marten Seemann
13a25a5ba5
use the correct error code for handshake timeouts
2017-06-01 20:02:57 +02:00
Marten Seemann
9040fd25e7
add a quic.Config option to set the handshake timeout
2017-06-01 19:47:28 +02:00
Marten Seemann
87df63dd5f
add a quic.Config option to verify source address tokes
2017-05-25 11:49:19 +08:00
Marten Seemann
e68e2d287a
pass remote address to cryptoSetupServer
2017-05-20 23:27:38 +08:00
Marten Seemann
996fad14f8
remove unsafe from the session tests for the crypto setup
2017-05-16 10:55:55 +08:00
Marten Seemann
9fad63ff50
improve client tests
...
Use a mock newClientSession. That way, it’s a lot easier to test dialing
new connections.
2017-05-16 00:56:09 +08:00
Marten Seemann
8ba1bd817f
move client session tests to separate place
2017-05-16 00:56:09 +08:00
Marten Seemann
889d3b38f8
remove the cryptoChangeCallback from the server
2017-05-16 00:56:09 +08:00
Marten Seemann
2bfa7e59cb
implement DialNonFWSecure for the client
2017-05-16 00:56:09 +08:00
Marten Seemann
cb8bea73c7
implement a non-forward-secure session
2017-05-16 00:56:08 +08:00
Marten Seemann
4fd410700d
properly handle errors that occur while handling packets in the session
...
fixes #614
2017-05-14 10:05:15 +08:00
Marten Seemann
7a18b870e8
add a quic.Config option to ask the server to truncate the connection ID
2017-05-13 17:19:09 +08:00
Marten Seemann
650af86c70
pass the quic.Config to the session
2017-05-13 17:08:15 +08:00
Marten Seemann
adc4ef464a
simplify the CryptoSetup.SetDiversificationNonce interface
...
Pass the diversification nonce via a channel instead of setting it
directly. That way there is no need to protect the diversificationNonce
member by a mutex. Also prevents a possible deadlock that occurred when
SetDiversificationNonce was called before maybeUpgradeCrypto returned.
2017-05-11 21:56:41 +08:00
Marten Seemann
8c4fe4ff80
fix race when setting the diversification nonce in clientCryptoSetup
2017-05-11 21:56:35 +08:00
Marten Seemann
69d5f3c262
send ConnectionCloses and PublicReset from the session run loop
...
This avoids several race conditions that can occur when trying to pack
packets and to write to the underlying connection concurrently.
2017-05-10 15:38:40 +08:00
Marten Seemann
75308ab56e
improve runClosed channel semantics in session
2017-05-10 11:32:57 +08:00
Marten Seemann
db8fb356bc
Merge pull request #595 from lucas-clemente/remove-handshake-complete
...
replace CryptoSetup.HandshakeComplete() by closing the aeadChanged channel
2017-05-09 19:36:17 +08:00
Marten Seemann
86c408e4bc
Merge pull request #604 from lucas-clemente/fix-603
...
fix flaky session test
2017-05-09 18:59:00 +08:00
Marten Seemann
8a0ab02c6c
Merge pull request #602 from lucas-clemente/fix-546
...
fix flaky session test
2017-05-09 18:51:09 +08:00
Marten Seemann
ab613c3ab0
use a directed aeadChanged chan in the session
2017-05-09 18:42:49 +08:00
Marten Seemann
0a6a9551f8
close the aeadChanged chan when the handshake completes
...
This allows us to remove HandshakeComplete() from the CryptoSetup
interface. It also provides a signal to the session when the handshake
completes.
2017-05-09 18:40:23 +08:00
Marten Seemann
2e0f5473a0
Merge pull request #577 from lucas-clemente/fix-565
...
add a quic.Config option for QUIC versions
2017-05-09 18:30:04 +08:00
Marten Seemann
e9db78ace3
fix flaky session test
...
fixes #603
This test can be simplified (and made race-free) by using that
session.run() now returns an error.
2017-05-09 14:43:18 +08:00
Marten Seemann
fc4e49b1c1
fix flaky session test
...
fixes #546
2017-05-09 14:14:38 +08:00
Marten Seemann
ab88e9472d
fix infinite loop in session test
...
fixes #598
The mockReceivedPacketHandler returned the same ACK frame over and over
again, so that the loop in session.sendPacket() would send packets
containing this packet indefinitely.
2017-05-09 12:15:21 +08:00
Marten Seemann
b305cd674f
make it possible to configure the QUIC versions for the server
2017-05-05 18:05:57 +08:00
Lucas Clemente
fa12f3664d
Merge pull request #582 from lucas-clemente/improve-ackhandler-logs
...
Improve ackhandler logs
2017-05-05 10:48:35 +02:00
Marten Seemann
4f6e31a08b
Merge pull request #572 from lucas-clemente/remove-closecallback
...
remove the closeCallback from the session
2017-05-05 16:31:16 +08:00
Marten Seemann
6263c07a49
fix several flaky session tests
2017-05-04 12:33:23 +08:00
Marten Seemann
96e49b0c31
remove the closeCallback from the session
...
The closeCallback was run when a session was closed, i.e. after the run
loop of the session stopped. Instead of explicitely calling this callback
from the session, the caller of session.run() can just execute the code
after session.run() returns.
2017-05-03 14:06:47 +08:00
Lucas Clemente
a2e079c052
Remove an unnecessary error return value
2017-04-30 15:32:01 +02:00
Marten Seemann
3c223b22a2
include peer perspective in nullAEAD
...
ref #375
2017-04-27 18:05:24 +07:00
Marten Seemann
81e06c1f02
don’t send a Public Reset if trial decryption succeeds
...
fixes #516
2017-04-11 10:45:08 +07:00
Marten Seemann
8565fdf722
fix limit of undecrytable packets queue length
...
fixes #517
Also fixes an off-by-one error, such that the queue now holds exactly
protocol.MaxUndecrytablePackets packets when enough undecryptable
packets are received.
2017-04-11 10:37:25 +07:00
Lucas Clemente
612fa16a43
Move SentPacketHandler.CheckForError into SentPacket
2017-04-02 10:29:09 +02:00
Lucas Clemente
1c5380c49b
Implement loss recovery from the current WG draft
...
Fixes #498 and will hopefully go a long way towards fixing the many
flaky tests.
2017-04-02 10:29:09 +02:00
Lucas Clemente
22cdbf7b49
Fix flaky appveyor tests
...
We were relying on the number of goroutines in those tests. This commit
replaces that logic with grepping through the current callstack.
The 'doesn't return after version negotiation is established if no
ConnState is defined' test is disabled, since I can't figure out a way
to make it work without leaking sessions. I filed #506 to track that
work.
Fixes #484 .
2017-03-30 21:13:24 +02:00
Marten Seemann
f4113b772a
remove stray Print command in tests
2017-03-20 16:10:30 +07:00
Marten Seemann
6d5c9776e9
send a Public Reset when receiving a CHLO with the FHL2 tag
...
Fixes #411 .
Chrome sends the FHL2 when it wants to perform a head-of-line blocking
experiment, introduced in QUIC version 36 (see
https://codereview.chromium.org/2115033002 ). We don’t support this
experiment. By sending a Public Reset when receiving this tag we force
Chrome to use the TCP fallback.
2017-03-20 12:35:34 +07:00
Marten Seemann
ab90b3f4d0
add tests for session.LocalAddr and session.RemoteAddr
2017-03-10 00:13:20 +07:00
Marten Seemann
34b688b3b9
add a LocalAddr to the Session
2017-03-10 00:07:27 +07:00
Marten Seemann
eb7ed2624a
only send Public Reset after a timeout
...
fixes #471
2017-03-08 18:15:52 +07:00
Marten Seemann
936a29ff35
retransmit packets with the encryption level they were sent with
2017-03-01 14:11:25 +07:00
Marten Seemann
7d2922d7ab
save the encryption level of a sent packet in the SentPacketHandler
2017-03-01 14:09:50 +07:00
Marten Seemann
9e147714ac
pack smaller packets as long as the encryption is not forward secure
2017-03-01 14:01:52 +07:00
Marten Seemann
6cb19e42a5
explicitly pass encryption level in the aeadChanges channel
2017-02-25 21:38:08 +07:00
