package quic import ( "bytes" "math" "net" "github.com/golang/mock/gomock" "github.com/lucas-clemente/quic-go/internal/ackhandler" "github.com/lucas-clemente/quic-go/internal/handshake" "github.com/lucas-clemente/quic-go/internal/protocol" "github.com/lucas-clemente/quic-go/internal/wire" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" ) type mockSealer struct{} func (s *mockSealer) Seal(dst, src []byte, packetNumber protocol.PacketNumber, associatedData []byte) []byte { return append(src, bytes.Repeat([]byte{0}, 12)...) } func (s *mockSealer) Overhead() int { return 12 } var _ handshake.Sealer = &mockSealer{} type mockCryptoSetup struct { handleErr error encLevelSeal protocol.EncryptionLevel encLevelSealCrypto protocol.EncryptionLevel } var _ handshake.CryptoSetup = &mockCryptoSetup{} func (m *mockCryptoSetup) HandleCryptoStream() error { return m.handleErr } func (m *mockCryptoSetup) Open(dst, src []byte, packetNumber protocol.PacketNumber, associatedData []byte) ([]byte, protocol.EncryptionLevel, error) { return nil, protocol.EncryptionUnspecified, nil } func (m *mockCryptoSetup) GetSealer() (protocol.EncryptionLevel, handshake.Sealer) { return m.encLevelSeal, &mockSealer{} } func (m *mockCryptoSetup) GetSealerForCryptoStream() (protocol.EncryptionLevel, handshake.Sealer) { return m.encLevelSealCrypto, &mockSealer{} } func (m *mockCryptoSetup) GetSealerWithEncryptionLevel(protocol.EncryptionLevel) (handshake.Sealer, error) { return &mockSealer{}, nil } func (m *mockCryptoSetup) ConnectionState() ConnectionState { panic("not implemented") } var _ = Describe("Packet packer", func() { const maxPacketSize protocol.ByteCount = 1357 var ( packer *packetPacker publicHeaderLen protocol.ByteCount maxFrameSize protocol.ByteCount mockStreamFramer *MockStreamFrameSource divNonce []byte ) BeforeEach(func() { version := versionGQUICFrames mockSender := NewMockStreamSender(mockCtrl) mockSender.EXPECT().onHasStreamData(gomock.Any()).AnyTimes() mockStreamFramer = NewMockStreamFrameSource(mockCtrl) divNonce = bytes.Repeat([]byte{'e'}, 32) packer = newPacketPacker( 0x1337, 1, func(protocol.PacketNumber) protocol.PacketNumberLen { return protocol.PacketNumberLen2 }, &net.TCPAddr{}, divNonce, &mockCryptoSetup{encLevelSeal: protocol.EncryptionForwardSecure}, mockStreamFramer, protocol.PerspectiveServer, version, ) publicHeaderLen = 1 + 8 + 2 // 1 flag byte, 8 connection ID, 2 packet number maxFrameSize = maxPacketSize - protocol.ByteCount((&mockSealer{}).Overhead()) - publicHeaderLen packer.hasSentPacket = true packer.version = version packer.maxPacketSize = maxPacketSize }) Context("determining the maximum packet size", func() { It("uses the minimum initial size, if it can't determine if the remote address is IPv4 or IPv6", func() { remoteAddr := &net.TCPAddr{} packer = newPacketPacker(0x1337, 1, nil, remoteAddr, nil, nil, nil, protocol.PerspectiveServer, protocol.VersionWhatever) Expect(packer.maxPacketSize).To(BeEquivalentTo(protocol.MinInitialPacketSize)) }) It("uses the maximum IPv4 packet size, if the remote address is IPv4", func() { remoteAddr := &net.UDPAddr{IP: net.IPv4(11, 12, 13, 14), Port: 1337} packer = newPacketPacker(0x1337, 1, nil, remoteAddr, nil, nil, nil, protocol.PerspectiveServer, protocol.VersionWhatever) Expect(packer.maxPacketSize).To(BeEquivalentTo(protocol.MaxPacketSizeIPv4)) }) It("uses the maximum IPv6 packet size, if the remote address is IPv6", func() { ip := net.ParseIP("2001:0db8:85a3:0000:0000:8a2e:0370:7334") remoteAddr := &net.UDPAddr{IP: ip, Port: 1337} packer = newPacketPacker(0x1337, 1, nil, remoteAddr, nil, nil, nil, protocol.PerspectiveServer, protocol.VersionWhatever) Expect(packer.maxPacketSize).To(BeEquivalentTo(protocol.MaxPacketSizeIPv6)) }) }) It("returns nil when no packet is queued", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) p, err := packer.PackPacket() Expect(p).To(BeNil()) Expect(err).ToNot(HaveOccurred()) }) It("packs single packets", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() f := &wire.StreamFrame{ StreamID: 5, Data: []byte{0xDE, 0xCA, 0xFB, 0xAD}, } mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Return([]*wire.StreamFrame{f}) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).ToNot(BeNil()) b := &bytes.Buffer{} f.Write(b, packer.version) Expect(p.frames).To(Equal([]wire.Frame{f})) Expect(p.raw).To(ContainSubstring(b.String())) }) It("stores the encryption level a packet was sealed with", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Return([]*wire.StreamFrame{{ StreamID: 5, Data: []byte("foobar"), }}) packer.cryptoSetup.(*mockCryptoSetup).encLevelSeal = protocol.EncryptionForwardSecure p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.encryptionLevel).To(Equal(protocol.EncryptionForwardSecure)) }) Context("generating a packet header", func() { const ( versionPublicHeader = protocol.Version39 // a QUIC version that uses the Public Header format versionIETFHeader = protocol.VersionTLS // a QUIC version that uses the IETF Header format ) Context("Public Header (for gQUIC)", func() { BeforeEach(func() { packer.version = versionPublicHeader }) It("it omits the connection ID for forward-secure packets", func() { ph := packer.getHeader(protocol.EncryptionForwardSecure) Expect(ph.OmitConnectionID).To(BeFalse()) packer.SetOmitConnectionID() ph = packer.getHeader(protocol.EncryptionForwardSecure) Expect(ph.OmitConnectionID).To(BeTrue()) }) It("doesn't omit the connection ID for non-forward-secure packets", func() { packer.SetOmitConnectionID() ph := packer.getHeader(protocol.EncryptionSecure) Expect(ph.OmitConnectionID).To(BeFalse()) }) It("adds the Version Flag to the Public Header before the crypto handshake is finished", func() { packer.perspective = protocol.PerspectiveClient ph := packer.getHeader(protocol.EncryptionSecure) Expect(ph.VersionFlag).To(BeTrue()) }) It("doesn't add the Version Flag to the Public Header for forward-secure packets", func() { packer.perspective = protocol.PerspectiveClient ph := packer.getHeader(protocol.EncryptionForwardSecure) Expect(ph.VersionFlag).To(BeFalse()) }) Context("diversificaton nonces", func() { It("doesn't include a div nonce, when sending a packet with initial encryption", func() { ph := packer.getHeader(protocol.EncryptionUnencrypted) Expect(ph.DiversificationNonce).To(BeEmpty()) }) It("includes a div nonce, when sending a packet with secure encryption", func() { ph := packer.getHeader(protocol.EncryptionSecure) Expect(ph.DiversificationNonce).To(Equal(divNonce)) }) It("doesn't include a div nonce, when sending a packet with forward-secure encryption", func() { ph := packer.getHeader(protocol.EncryptionForwardSecure) Expect(ph.DiversificationNonce).To(BeEmpty()) }) It("doesn't send a div nonce as a client", func() { packer.perspective = protocol.PerspectiveClient ph := packer.getHeader(protocol.EncryptionSecure) Expect(ph.DiversificationNonce).To(BeEmpty()) }) }) }) Context("Header (for IETF draft QUIC)", func() { BeforeEach(func() { packer.version = versionIETFHeader }) It("uses the Long Header format for non-forward-secure packets", func() { h := packer.getHeader(protocol.EncryptionSecure) Expect(h.IsLongHeader).To(BeTrue()) Expect(h.PacketNumberLen).To(Equal(protocol.PacketNumberLen4)) Expect(h.Version).To(Equal(versionIETFHeader)) }) It("uses the Short Header format for forward-secure packets", func() { h := packer.getHeader(protocol.EncryptionForwardSecure) Expect(h.IsLongHeader).To(BeFalse()) Expect(h.PacketNumberLen).To(BeNumerically(">", 0)) }) It("it omits the connection ID for forward-secure packets", func() { h := packer.getHeader(protocol.EncryptionForwardSecure) Expect(h.OmitConnectionID).To(BeFalse()) packer.SetOmitConnectionID() h = packer.getHeader(protocol.EncryptionForwardSecure) Expect(h.OmitConnectionID).To(BeTrue()) }) It("doesn't omit the connection ID for non-forward-secure packets", func() { packer.SetOmitConnectionID() h := packer.getHeader(protocol.EncryptionSecure) Expect(h.OmitConnectionID).To(BeFalse()) }) }) }) It("packs a CONNECTION_CLOSE", func() { ccf := wire.ConnectionCloseFrame{ ErrorCode: 0x1337, ReasonPhrase: "foobar", } p, err := packer.PackConnectionClose(&ccf) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(1)) Expect(p.frames[0]).To(Equal(&ccf)) }) It("doesn't send any other frames when sending a CONNECTION_CLOSE", func() { // expect no mockStreamFramer.PopStreamFrames ccf := &wire.ConnectionCloseFrame{ ErrorCode: 0x1337, ReasonPhrase: "foobar", } packer.controlFrames = []wire.Frame{&wire.MaxStreamDataFrame{StreamID: 37}} p, err := packer.PackConnectionClose(ccf) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(Equal([]wire.Frame{ccf})) }) It("packs only control frames", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) packer.QueueControlFrame(&wire.RstStreamFrame{}) packer.QueueControlFrame(&wire.MaxDataFrame{}) p, err := packer.PackPacket() Expect(p).ToNot(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(2)) Expect(p.raw).NotTo(BeEmpty()) }) It("increases the packet number", func() { mockStreamFramer.EXPECT().HasCryptoStreamData().Times(2) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Times(2) packer.QueueControlFrame(&wire.RstStreamFrame{}) p1, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p1).ToNot(BeNil()) packer.QueueControlFrame(&wire.RstStreamFrame{}) p2, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p2).ToNot(BeNil()) Expect(p2.header.PacketNumber).To(BeNumerically(">", p1.header.PacketNumber)) }) It("packs a STOP_WAITING frame first", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) packer.packetNumberGenerator.next = 15 swf := &wire.StopWaitingFrame{LeastUnacked: 10} packer.QueueControlFrame(&wire.RstStreamFrame{}) packer.QueueControlFrame(swf) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).ToNot(BeNil()) Expect(p.frames).To(HaveLen(2)) Expect(p.frames[0]).To(Equal(swf)) }) It("sets the LeastUnackedDelta length of a STOP_WAITING frame", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) packer.packetNumberGenerator.next = 0x1337 swf := &wire.StopWaitingFrame{LeastUnacked: 0x1337 - 0x100} packer.QueueControlFrame(&wire.RstStreamFrame{}) packer.QueueControlFrame(swf) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames[0].(*wire.StopWaitingFrame).PacketNumberLen).To(Equal(protocol.PacketNumberLen2)) }) It("does not pack a packet containing only a STOP_WAITING frame", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) swf := &wire.StopWaitingFrame{LeastUnacked: 10} packer.QueueControlFrame(swf) p, err := packer.PackPacket() Expect(p).To(BeNil()) Expect(err).ToNot(HaveOccurred()) }) It("packs a packet if it has queued control frames, but no new control frames", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) packer.controlFrames = []wire.Frame{&wire.BlockedFrame{}} p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).ToNot(BeNil()) }) It("refuses to send a packet that doesn't contain crypto stream data, if it has never sent a packet before", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() packer.hasSentPacket = false packer.controlFrames = []wire.Frame{&wire.BlockedFrame{}} p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).To(BeNil()) }) It("packs many control frames into 1 packets", func() { f := &wire.AckFrame{LargestAcked: 1} b := &bytes.Buffer{} err := f.Write(b, packer.version) Expect(err).ToNot(HaveOccurred()) maxFramesPerPacket := int(maxFrameSize) / b.Len() var controlFrames []wire.Frame for i := 0; i < maxFramesPerPacket; i++ { controlFrames = append(controlFrames, f) } packer.controlFrames = controlFrames payloadFrames, err := packer.composeNextPacket(maxFrameSize, false) Expect(err).ToNot(HaveOccurred()) Expect(payloadFrames).To(HaveLen(maxFramesPerPacket)) payloadFrames, err = packer.composeNextPacket(maxFrameSize, false) Expect(err).ToNot(HaveOccurred()) Expect(payloadFrames).To(BeEmpty()) }) It("packs a lot of control frames into 2 packets if they don't fit into one", func() { blockedFrame := &wire.BlockedFrame{} maxFramesPerPacket := int(maxFrameSize) / int(blockedFrame.Length(packer.version)) var controlFrames []wire.Frame for i := 0; i < maxFramesPerPacket+10; i++ { controlFrames = append(controlFrames, blockedFrame) } packer.controlFrames = controlFrames payloadFrames, err := packer.composeNextPacket(maxFrameSize, false) Expect(err).ToNot(HaveOccurred()) Expect(payloadFrames).To(HaveLen(maxFramesPerPacket)) payloadFrames, err = packer.composeNextPacket(maxFrameSize, false) Expect(err).ToNot(HaveOccurred()) Expect(payloadFrames).To(HaveLen(10)) }) It("only increases the packet number when there is an actual packet to send", func() { mockStreamFramer.EXPECT().HasCryptoStreamData().Times(2) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) packer.packetNumberGenerator.nextToSkip = 1000 p, err := packer.PackPacket() Expect(p).To(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(packer.packetNumberGenerator.Peek()).To(Equal(protocol.PacketNumber(1))) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Return([]*wire.StreamFrame{{ StreamID: 5, Data: []byte{0xDE, 0xCA, 0xFB, 0xAD}, }}) p, err = packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).ToNot(BeNil()) Expect(p.header.PacketNumber).To(Equal(protocol.PacketNumber(1))) Expect(packer.packetNumberGenerator.Peek()).To(Equal(protocol.PacketNumber(2))) }) Context("making ACK packets retransmittable", func() { sendMaxNumNonRetransmittableAcks := func() { mockStreamFramer.EXPECT().HasCryptoStreamData().Times(protocol.MaxNonRetransmittableAcks) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Times(protocol.MaxNonRetransmittableAcks) for i := 0; i < protocol.MaxNonRetransmittableAcks; i++ { packer.QueueControlFrame(&wire.AckFrame{}) p, err := packer.PackPacket() Expect(p).ToNot(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(1)) } } It("adds a PING frame when it's supposed to send a retransmittable packet", func() { sendMaxNumNonRetransmittableAcks() mockStreamFramer.EXPECT().HasCryptoStreamData().Times(2) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Times(2) packer.QueueControlFrame(&wire.AckFrame{}) p, err := packer.PackPacket() Expect(p).ToNot(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(ContainElement(&wire.PingFrame{})) // make sure the next packet doesn't contain another PING packer.QueueControlFrame(&wire.AckFrame{}) p, err = packer.PackPacket() Expect(p).ToNot(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(1)) }) It("waits until there's something to send before adding a PING frame", func() { sendMaxNumNonRetransmittableAcks() mockStreamFramer.EXPECT().HasCryptoStreamData().Times(2) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Times(2) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).To(BeNil()) packer.QueueControlFrame(&wire.AckFrame{}) p, err = packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(2)) Expect(p.frames).To(ContainElement(&wire.PingFrame{})) }) It("doesn't send a PING if it already sent another retransmittable frame", func() { sendMaxNumNonRetransmittableAcks() mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) packer.QueueControlFrame(&wire.MaxDataFrame{}) packer.QueueControlFrame(&wire.AckFrame{}) p, err := packer.PackPacket() Expect(p).ToNot(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(2)) Expect(p.frames).ToNot(ContainElement(&wire.PingFrame{})) }) }) Context("STREAM frame handling", func() { It("does not splits a STREAM frame with maximum size, for gQUIC frames", func() { mockStreamFramer.EXPECT().HasCryptoStreamData().Times(2) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).DoAndReturn(func(maxSize protocol.ByteCount) []*wire.StreamFrame { f := &wire.StreamFrame{ Offset: 1, StreamID: 5, DataLenPresent: true, } f.Data = bytes.Repeat([]byte{'f'}, int(maxSize-f.Length(packer.version))) return []*wire.StreamFrame{f} }) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(1)) Expect(p.raw).To(HaveLen(int(maxPacketSize))) Expect(p.frames[0].(*wire.StreamFrame).DataLenPresent).To(BeFalse()) p, err = packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).To(BeNil()) }) It("does not splits a STREAM frame with maximum size, for IETF draft style frame", func() { packer.version = versionIETFFrames mockStreamFramer.EXPECT().HasCryptoStreamData().Times(2) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).DoAndReturn(func(maxSize protocol.ByteCount) []*wire.StreamFrame { f := &wire.StreamFrame{ Offset: 1, StreamID: 5, DataLenPresent: true, } f.Data = bytes.Repeat([]byte{'f'}, int(maxSize-f.Length(packer.version))) return []*wire.StreamFrame{f} }) mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(1)) Expect(p.raw).To(HaveLen(int(maxPacketSize))) Expect(p.frames[0].(*wire.StreamFrame).DataLenPresent).To(BeFalse()) p, err = packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).To(BeNil()) }) It("packs multiple small STREAM frames into single packet", func() { f1 := &wire.StreamFrame{ StreamID: 5, Data: []byte("frame 1"), DataLenPresent: true, } f2 := &wire.StreamFrame{ StreamID: 5, Data: []byte("frame 2"), DataLenPresent: true, } f3 := &wire.StreamFrame{ StreamID: 3, Data: []byte("frame 3"), DataLenPresent: true, } mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Return([]*wire.StreamFrame{f1, f2, f3}) p, err := packer.PackPacket() Expect(p).ToNot(BeNil()) Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(HaveLen(3)) Expect(p.frames[0].(*wire.StreamFrame).Data).To(Equal([]byte("frame 1"))) Expect(p.frames[1].(*wire.StreamFrame).Data).To(Equal([]byte("frame 2"))) Expect(p.frames[2].(*wire.StreamFrame).Data).To(Equal([]byte("frame 3"))) Expect(p.frames[0].(*wire.StreamFrame).DataLenPresent).To(BeTrue()) Expect(p.frames[1].(*wire.StreamFrame).DataLenPresent).To(BeTrue()) Expect(p.frames[2].(*wire.StreamFrame).DataLenPresent).To(BeFalse()) }) It("refuses to send unencrypted stream data on a data stream", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() // don't expect a call to mockStreamFramer.PopStreamFrames packer.cryptoSetup.(*mockCryptoSetup).encLevelSeal = protocol.EncryptionUnencrypted p, err := packer.PackPacket() Expect(err).NotTo(HaveOccurred()) Expect(p).To(BeNil()) }) It("sends non forward-secure data as the client", func() { f := &wire.StreamFrame{ StreamID: 5, Data: []byte("foobar"), } mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).Return([]*wire.StreamFrame{f}) packer.perspective = protocol.PerspectiveClient packer.cryptoSetup.(*mockCryptoSetup).encLevelSeal = protocol.EncryptionSecure p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.encryptionLevel).To(Equal(protocol.EncryptionSecure)) Expect(p.frames).To(Equal([]wire.Frame{f})) }) It("does not send non forward-secure data as the server", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() // don't expect a call to mockStreamFramer.PopStreamFrames packer.cryptoSetup.(*mockCryptoSetup).encLevelSeal = protocol.EncryptionSecure p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p).To(BeNil()) }) It("sends unencrypted stream data on the crypto stream", func() { f := &wire.StreamFrame{ StreamID: packer.version.CryptoStreamID(), Data: []byte("foobar"), } mockStreamFramer.EXPECT().HasCryptoStreamData().Return(true) mockStreamFramer.EXPECT().PopCryptoStreamFrame(gomock.Any()).Return(f) packer.cryptoSetup.(*mockCryptoSetup).encLevelSealCrypto = protocol.EncryptionUnencrypted p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(Equal([]wire.Frame{f})) Expect(p.encryptionLevel).To(Equal(protocol.EncryptionUnencrypted)) }) It("sends encrypted stream data on the crypto stream", func() { f := &wire.StreamFrame{ StreamID: packer.version.CryptoStreamID(), Data: []byte("foobar"), } mockStreamFramer.EXPECT().HasCryptoStreamData().Return(true) mockStreamFramer.EXPECT().PopCryptoStreamFrame(gomock.Any()).Return(f) packer.cryptoSetup.(*mockCryptoSetup).encLevelSealCrypto = protocol.EncryptionSecure p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(Equal([]wire.Frame{f})) Expect(p.encryptionLevel).To(Equal(protocol.EncryptionSecure)) }) It("does not pack STREAM frames if not allowed", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() // don't expect a call to mockStreamFramer.PopStreamFrames packer.cryptoSetup.(*mockCryptoSetup).encLevelSeal = protocol.EncryptionUnencrypted ack := &wire.AckFrame{LargestAcked: 10} packer.QueueControlFrame(ack) p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.frames).To(Equal([]wire.Frame{ack})) }) }) It("packs a single ACK", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) ack := &wire.AckFrame{LargestAcked: 42} packer.QueueControlFrame(ack) p, err := packer.PackPacket() Expect(err).NotTo(HaveOccurred()) Expect(p).ToNot(BeNil()) Expect(p.frames[0]).To(Equal(ack)) }) It("does not return nil if we only have a single ACK but request it to be sent", func() { mockStreamFramer.EXPECT().HasCryptoStreamData() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()) ack := &wire.AckFrame{} packer.QueueControlFrame(ack) p, err := packer.PackPacket() Expect(err).NotTo(HaveOccurred()) Expect(p).ToNot(BeNil()) }) Context("retransmitting of handshake packets", func() { swf := &wire.StopWaitingFrame{LeastUnacked: 1} sf := &wire.StreamFrame{ StreamID: 1, Data: []byte("foobar"), } BeforeEach(func() { packer.QueueControlFrame(swf) }) It("packs a retransmission for a packet sent with no encryption", func() { packet := &ackhandler.Packet{ PacketType: protocol.PacketTypeHandshake, EncryptionLevel: protocol.EncryptionUnencrypted, Frames: []wire.Frame{sf}, } p, err := packer.PackRetransmission(packet) Expect(err).ToNot(HaveOccurred()) Expect(p).To(HaveLen(1)) Expect(p[0].header.Type).To(Equal(protocol.PacketTypeHandshake)) Expect(p[0].frames).To(Equal([]wire.Frame{swf, sf})) Expect(p[0].encryptionLevel).To(Equal(protocol.EncryptionUnencrypted)) }) It("doesn't add a STOP_WAITING frame for IETF QUIC", func() { packer.version = versionIETFFrames packet := &ackhandler.Packet{ EncryptionLevel: protocol.EncryptionUnencrypted, Frames: []wire.Frame{sf}, } p, err := packer.PackRetransmission(packet) Expect(err).ToNot(HaveOccurred()) Expect(p).To(HaveLen(1)) Expect(p[0].frames).To(Equal([]wire.Frame{sf})) Expect(p[0].encryptionLevel).To(Equal(protocol.EncryptionUnencrypted)) }) It("packs a retransmission for a packet sent with initial encryption", func() { packet := &ackhandler.Packet{ EncryptionLevel: protocol.EncryptionSecure, Frames: []wire.Frame{sf}, } p, err := packer.PackRetransmission(packet) Expect(err).ToNot(HaveOccurred()) Expect(p).To(HaveLen(1)) Expect(p[0].frames).To(Equal([]wire.Frame{swf, sf})) Expect(p[0].encryptionLevel).To(Equal(protocol.EncryptionSecure)) // a packet sent by the server with initial encryption contains the SHLO // it needs to have a diversification nonce Expect(p[0].raw).To(ContainSubstring(string(divNonce))) }) It("includes the diversification nonce on packets sent with initial encryption", func() { packet := &ackhandler.Packet{ EncryptionLevel: protocol.EncryptionSecure, Frames: []wire.Frame{sf}, } p, err := packer.PackRetransmission(packet) Expect(err).ToNot(HaveOccurred()) Expect(p).To(HaveLen(1)) Expect(p[0].encryptionLevel).To(Equal(protocol.EncryptionSecure)) }) // this should never happen, since non forward-secure packets are limited to a size smaller than MaxPacketSize, such that it is always possible to retransmit them without splitting the StreamFrame // (note that the retransmitted packet needs to have enough space for the StopWaitingFrame) It("refuses to send a packet larger than MaxPacketSize", func() { packet := &ackhandler.Packet{ EncryptionLevel: protocol.EncryptionSecure, Frames: []wire.Frame{ &wire.StreamFrame{ StreamID: 1, Data: bytes.Repeat([]byte{'f'}, int(maxPacketSize-5)), }, }, } _, err := packer.PackRetransmission(packet) Expect(err).To(HaveOccurred()) Expect(err.Error()).To(ContainSubstring("PacketPacker BUG: packet too large")) }) It("pads Initial packets to the required minimum packet size", func() { f := &wire.StreamFrame{ StreamID: packer.version.CryptoStreamID(), Data: []byte("foobar"), } mockStreamFramer.EXPECT().HasCryptoStreamData().Return(true) mockStreamFramer.EXPECT().PopCryptoStreamFrame(gomock.Any()).Return(f) packer.version = protocol.VersionTLS packer.hasSentPacket = false packer.perspective = protocol.PerspectiveClient packer.cryptoSetup.(*mockCryptoSetup).encLevelSealCrypto = protocol.EncryptionUnencrypted packet, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(packet.raw).To(HaveLen(protocol.MinInitialPacketSize)) Expect(packet.frames).To(HaveLen(1)) sf := packet.frames[0].(*wire.StreamFrame) Expect(sf.Data).To(Equal([]byte("foobar"))) Expect(sf.DataLenPresent).To(BeTrue()) }) It("packs a retransmission for an Initial packet", func() { packer.version = versionIETFFrames packer.perspective = protocol.PerspectiveClient packet := &ackhandler.Packet{ PacketType: protocol.PacketTypeInitial, EncryptionLevel: protocol.EncryptionUnencrypted, Frames: []wire.Frame{sf}, } p, err := packer.PackRetransmission(packet) Expect(err).ToNot(HaveOccurred()) Expect(p).To(HaveLen(1)) Expect(p[0].frames).To(Equal([]wire.Frame{sf})) Expect(p[0].encryptionLevel).To(Equal(protocol.EncryptionUnencrypted)) Expect(p[0].header.Type).To(Equal(protocol.PacketTypeInitial)) }) It("refuses to retransmit packets without a STOP_WAITING Frame", func() { packer.stopWaiting = nil _, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionSecure, }) Expect(err).To(MatchError("PacketPacker BUG: Handshake retransmissions must contain a STOP_WAITING frame")) }) }) Context("retransmission of forward-secure packets", func() { BeforeEach(func() { packer.packetNumberGenerator.next = 15 packer.stopWaiting = &wire.StopWaitingFrame{LeastUnacked: 7} }) It("retransmits a small packet", func() { frames := []wire.Frame{ &wire.MaxDataFrame{ByteOffset: 0x1234}, &wire.StreamFrame{StreamID: 42, Data: []byte("foobar")}, } packets, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionForwardSecure, Frames: frames, }) Expect(err).ToNot(HaveOccurred()) Expect(packets).To(HaveLen(1)) p := packets[0] Expect(p.encryptionLevel).To(Equal(protocol.EncryptionForwardSecure)) Expect(p.frames).To(HaveLen(3)) Expect(p.frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(p.frames[0].(*wire.StopWaitingFrame).LeastUnacked).To(Equal(protocol.PacketNumber(7))) Expect(p.frames[0].(*wire.StopWaitingFrame).PacketNumber).To(Equal(p.header.PacketNumber)) Expect(p.frames[0].(*wire.StopWaitingFrame).PacketNumberLen).To(Equal(p.header.PacketNumberLen)) Expect(p.frames[1:]).To(Equal(frames)) }) It("refuses to retransmit packets without a STOP_WAITING Frame", func() { packer.stopWaiting = nil _, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionForwardSecure, Frames: []wire.Frame{&wire.MaxDataFrame{ByteOffset: 0x1234}}, }) Expect(err).To(MatchError("PacketPacker BUG: Handshake retransmissions must contain a STOP_WAITING frame")) }) It("packs two packets for retransmission if the original packet contained many control frames", func() { var frames []wire.Frame var totalLen protocol.ByteCount // pack a bunch of control frames, such that the packet is way bigger than a single packet for i := 0; totalLen < maxPacketSize*3/2; i++ { f := &wire.MaxStreamDataFrame{StreamID: protocol.StreamID(i), ByteOffset: protocol.ByteCount(i)} frames = append(frames, f) totalLen += f.Length(packer.version) } packets, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionForwardSecure, Frames: frames, }) Expect(err).ToNot(HaveOccurred()) Expect(packets).To(HaveLen(2)) Expect(len(packets[0].frames) + len(packets[1].frames)).To(Equal(len(frames) + 2)) // all frames, plus 2 STOP_WAITING frames Expect(packets[0].frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(packets[1].frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(packets[0].frames[1:]).To(Equal(frames[:len(packets[0].frames)-1])) Expect(packets[1].frames[1:]).To(Equal(frames[len(packets[0].frames)-1:])) // check that the first packet was filled up as far as possible: // if the first frame (after the STOP_WAITING) was packed into the first packet, it would have overflown the MaxPacketSize Expect(len(packets[0].raw) + int(packets[1].frames[1].Length(packer.version))).To(BeNumerically(">", maxPacketSize)) }) It("splits a STREAM frame that doesn't fit", func() { packets, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionForwardSecure, Frames: []wire.Frame{&wire.StreamFrame{ StreamID: 42, Offset: 1337, Data: bytes.Repeat([]byte{'a'}, int(maxPacketSize)*3/2), }}, }) Expect(err).ToNot(HaveOccurred()) Expect(packets).To(HaveLen(2)) Expect(packets[0].frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(packets[1].frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(packets[0].frames[1]).To(BeAssignableToTypeOf(&wire.StreamFrame{})) Expect(packets[1].frames[1]).To(BeAssignableToTypeOf(&wire.StreamFrame{})) sf1 := packets[0].frames[1].(*wire.StreamFrame) sf2 := packets[1].frames[1].(*wire.StreamFrame) Expect(sf1.StreamID).To(Equal(protocol.StreamID(42))) Expect(sf1.Offset).To(Equal(protocol.ByteCount(1337))) Expect(sf1.DataLenPresent).To(BeFalse()) Expect(sf2.StreamID).To(Equal(protocol.StreamID(42))) Expect(sf2.Offset).To(Equal(protocol.ByteCount(1337) + sf1.DataLen())) Expect(sf2.DataLenPresent).To(BeFalse()) Expect(sf1.DataLen() + sf2.DataLen()).To(Equal(maxPacketSize * 3 / 2)) Expect(packets[0].raw).To(HaveLen(int(maxPacketSize))) }) It("packs two packets for retransmission if the original packet contained many STREAM frames", func() { var frames []wire.Frame var totalLen protocol.ByteCount // pack a bunch of control frames, such that the packet is way bigger than a single packet for i := 0; totalLen < maxPacketSize*3/2; i++ { f := &wire.StreamFrame{ StreamID: protocol.StreamID(i), Data: []byte("foobar"), DataLenPresent: true, } frames = append(frames, f) totalLen += f.Length(packer.version) } packets, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionForwardSecure, Frames: frames, }) Expect(err).ToNot(HaveOccurred()) Expect(packets).To(HaveLen(2)) Expect(len(packets[0].frames) + len(packets[1].frames)).To(Equal(len(frames) + 2)) // all frames, plus 2 STOP_WAITING frames Expect(packets[0].frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(packets[1].frames[0]).To(BeAssignableToTypeOf(&wire.StopWaitingFrame{})) Expect(packets[0].frames[1:]).To(Equal(frames[:len(packets[0].frames)-1])) Expect(packets[1].frames[1:]).To(Equal(frames[len(packets[0].frames)-1:])) // check that the first packet was filled up as far as possible: // if the first frame (after the STOP_WAITING) was packed into the first packet, it would have overflown the MaxPacketSize Expect(len(packets[0].raw) + int(packets[1].frames[1].Length(packer.version))).To(BeNumerically(">", maxPacketSize-protocol.MinStreamFrameSize)) }) It("correctly sets the DataLenPresent on STREAM frames", func() { frames := []wire.Frame{ &wire.StreamFrame{StreamID: 4, Data: []byte("foobar"), DataLenPresent: true}, &wire.StreamFrame{StreamID: 5, Data: []byte("barfoo")}, } packets, err := packer.PackRetransmission(&ackhandler.Packet{ EncryptionLevel: protocol.EncryptionForwardSecure, Frames: frames, }) Expect(err).ToNot(HaveOccurred()) Expect(packets).To(HaveLen(1)) p := packets[0] Expect(p.frames).To(HaveLen(3)) Expect(p.frames[1]).To(BeAssignableToTypeOf(&wire.StreamFrame{})) Expect(p.frames[2]).To(BeAssignableToTypeOf(&wire.StreamFrame{})) sf1 := p.frames[1].(*wire.StreamFrame) sf2 := p.frames[2].(*wire.StreamFrame) Expect(sf1.StreamID).To(Equal(protocol.StreamID(4))) Expect(sf1.DataLenPresent).To(BeTrue()) Expect(sf2.StreamID).To(Equal(protocol.StreamID(5))) Expect(sf2.DataLenPresent).To(BeFalse()) }) }) Context("packing ACK packets", func() { It("packs ACK packets", func() { packer.QueueControlFrame(&wire.AckFrame{}) p, err := packer.PackAckPacket() Expect(err).NotTo(HaveOccurred()) Expect(p.frames).To(Equal([]wire.Frame{&wire.AckFrame{DelayTime: math.MaxInt64}})) }) It("packs ACK packets with STOP_WAITING frames", func() { packer.QueueControlFrame(&wire.AckFrame{}) packer.QueueControlFrame(&wire.StopWaitingFrame{}) p, err := packer.PackAckPacket() Expect(err).NotTo(HaveOccurred()) Expect(p.frames).To(Equal([]wire.Frame{ &wire.AckFrame{DelayTime: math.MaxInt64}, &wire.StopWaitingFrame{PacketNumber: 1, PacketNumberLen: 2}, })) }) }) Context("max packet size", func() { It("sets the maximum packet size", func() { for i := 0; i < 10*int(maxPacketSize); i++ { packer.QueueControlFrame(&wire.PingFrame{}) } mockStreamFramer.EXPECT().HasCryptoStreamData().AnyTimes() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).AnyTimes() p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.raw).To(HaveLen(int(maxPacketSize))) // now reduce the maxPacketSize packer.SetMaxPacketSize(maxPacketSize - 10) p, err = packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.raw).To(HaveLen(int(maxPacketSize) - 10)) }) It("doesn't increase the max packet size", func() { for i := 0; i < 10*int(maxPacketSize); i++ { packer.QueueControlFrame(&wire.PingFrame{}) } mockStreamFramer.EXPECT().HasCryptoStreamData().AnyTimes() mockStreamFramer.EXPECT().PopStreamFrames(gomock.Any()).AnyTimes() p, err := packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.raw).To(HaveLen(int(maxPacketSize))) // now try to increase the maxPacketSize packer.SetMaxPacketSize(maxPacketSize + 10) p, err = packer.PackPacket() Expect(err).ToNot(HaveOccurred()) Expect(p.raw).To(HaveLen(int(maxPacketSize))) }) }) })