mirror of
https://github.com/refraction-networking/uquic.git
synced 2025-04-01 19:27:35 +03:00
391 lines
17 KiB
Go
391 lines
17 KiB
Go
package ackhandler
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/refraction-networking/uquic/internal/protocol"
|
|
"github.com/refraction-networking/uquic/internal/utils"
|
|
"github.com/refraction-networking/uquic/internal/wire"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("Received Packet Tracker", func() {
|
|
var tracker *receivedPacketTracker
|
|
|
|
BeforeEach(func() {
|
|
tracker = newReceivedPacketTracker()
|
|
})
|
|
|
|
It("acknowledges packets", func() {
|
|
t := time.Now().Add(-10 * time.Second)
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(3), protocol.ECNNon, t, true)).To(Succeed())
|
|
ack := tracker.GetAckFrame()
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.AckRanges).To(Equal([]wire.AckRange{{Smallest: 3, Largest: 3}}))
|
|
Expect(ack.DelayTime).To(BeZero())
|
|
// now receive another packet
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(4), protocol.ECNNon, t.Add(time.Second), true)).To(Succeed())
|
|
ack = tracker.GetAckFrame()
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.AckRanges).To(Equal([]wire.AckRange{{Smallest: 3, Largest: 4}}))
|
|
Expect(ack.DelayTime).To(BeZero())
|
|
})
|
|
|
|
It("also acknowledges delayed packets", func() {
|
|
t := time.Now().Add(-10 * time.Second)
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(3), protocol.ECNNon, t, true)).To(Succeed())
|
|
ack := tracker.GetAckFrame()
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(3)))
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(3)))
|
|
Expect(ack.DelayTime).To(BeZero())
|
|
// now receive another packet
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(1), protocol.ECNNon, t.Add(time.Second), true)).To(Succeed())
|
|
ack = tracker.GetAckFrame()
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.AckRanges).To(HaveLen(2))
|
|
Expect(ack.AckRanges).To(ContainElement(wire.AckRange{Smallest: 1, Largest: 1}))
|
|
Expect(ack.AckRanges).To(ContainElement(wire.AckRange{Smallest: 3, Largest: 3}))
|
|
Expect(ack.DelayTime).To(BeZero())
|
|
})
|
|
|
|
It("doesn't trigger ACKs for non-ack-eliciting packets", func() {
|
|
t := time.Now().Add(-10 * time.Second)
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(3), protocol.ECNNon, t, false)).To(Succeed())
|
|
Expect(tracker.GetAckFrame()).To(BeNil())
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(4), protocol.ECNNon, t.Add(5*time.Second), false)).To(Succeed())
|
|
Expect(tracker.GetAckFrame()).To(BeNil())
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(5), protocol.ECNNon, t.Add(10*time.Second), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame()
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.AckRanges).To(Equal([]wire.AckRange{{Smallest: 3, Largest: 5}}))
|
|
})
|
|
})
|
|
|
|
var _ = Describe("Application Data Received Packet Tracker", func() {
|
|
var tracker *appDataReceivedPacketTracker
|
|
|
|
BeforeEach(func() {
|
|
tracker = newAppDataReceivedPacketTracker(utils.DefaultLogger)
|
|
})
|
|
|
|
Context("accepting packets", func() {
|
|
It("saves the time when each packet arrived", func() {
|
|
t := time.Now()
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(3), protocol.ECNNon, t, true)).To(Succeed())
|
|
Expect(tracker.largestObservedRcvdTime).To(Equal(t))
|
|
})
|
|
|
|
It("updates the largestObserved and the largestObservedRcvdTime", func() {
|
|
now := time.Now()
|
|
tracker.largestObserved = 3
|
|
tracker.largestObservedRcvdTime = now.Add(-1 * time.Second)
|
|
Expect(tracker.ReceivedPacket(5, protocol.ECNNon, now, true)).To(Succeed())
|
|
Expect(tracker.largestObserved).To(Equal(protocol.PacketNumber(5)))
|
|
Expect(tracker.largestObservedRcvdTime).To(Equal(now))
|
|
})
|
|
|
|
It("doesn't update the largestObserved and the largestObservedRcvdTime for a belated packet", func() {
|
|
now := time.Now()
|
|
timestamp := now.Add(-1 * time.Second)
|
|
tracker.largestObserved = 5
|
|
tracker.largestObservedRcvdTime = timestamp
|
|
Expect(tracker.ReceivedPacket(4, protocol.ECNNon, now, true)).To(Succeed())
|
|
Expect(tracker.largestObserved).To(Equal(protocol.PacketNumber(5)))
|
|
Expect(tracker.largestObservedRcvdTime).To(Equal(timestamp))
|
|
})
|
|
})
|
|
|
|
Context("ACKs", func() {
|
|
Context("queueing ACKs", func() {
|
|
// receives and gets ACKs for packet numbers 1 to 10 (including)
|
|
receiveAndAck10Packets := func() {
|
|
for i := 1; i <= 10; i++ {
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(i), protocol.ECNNon, time.Time{}, true)).To(Succeed())
|
|
}
|
|
Expect(tracker.GetAckFrame(true)).ToNot(BeNil())
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
}
|
|
|
|
It("always queues an ACK for the first packet", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeTrue())
|
|
Expect(tracker.GetAlarmTimeout()).To(BeZero())
|
|
Expect(tracker.GetAckFrame(true).DelayTime).To(BeNumerically("~", 0, time.Second))
|
|
})
|
|
|
|
It("works with packet number 0", func() {
|
|
Expect(tracker.ReceivedPacket(0, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeTrue())
|
|
Expect(tracker.GetAlarmTimeout()).To(BeZero())
|
|
Expect(tracker.GetAckFrame(true).DelayTime).To(BeNumerically("~", 0, time.Second))
|
|
})
|
|
|
|
It("sets ECN flags", func() {
|
|
Expect(tracker.ReceivedPacket(0, protocol.ECT0, time.Now(), true)).To(Succeed())
|
|
pn := protocol.PacketNumber(1)
|
|
for i := 0; i < 2; i++ {
|
|
Expect(tracker.ReceivedPacket(pn, protocol.ECT1, time.Now(), true)).To(Succeed())
|
|
pn++
|
|
}
|
|
for i := 0; i < 3; i++ {
|
|
Expect(tracker.ReceivedPacket(pn, protocol.ECNCE, time.Now(), true)).To(Succeed())
|
|
pn++
|
|
}
|
|
ack := tracker.GetAckFrame(false)
|
|
Expect(ack.ECT0).To(BeEquivalentTo(1))
|
|
Expect(ack.ECT1).To(BeEquivalentTo(2))
|
|
Expect(ack.ECNCE).To(BeEquivalentTo(3))
|
|
})
|
|
|
|
It("queues an ACK for every second ack-eliciting packet", func() {
|
|
receiveAndAck10Packets()
|
|
p := protocol.PacketNumber(11)
|
|
for i := 0; i <= 20; i++ {
|
|
Expect(tracker.ReceivedPacket(p, protocol.ECNNon, time.Time{}, true)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
p++
|
|
Expect(tracker.ReceivedPacket(p, protocol.ECNNon, time.Time{}, true)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeTrue())
|
|
p++
|
|
// dequeue the ACK frame
|
|
Expect(tracker.GetAckFrame(true)).ToNot(BeNil())
|
|
}
|
|
})
|
|
|
|
It("resets the counter when a non-queued ACK frame is generated", func() {
|
|
receiveAndAck10Packets()
|
|
rcvTime := time.Now()
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNNon, rcvTime, true)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(false)).ToNot(BeNil())
|
|
Expect(tracker.ReceivedPacket(12, protocol.ECNNon, rcvTime, true)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
Expect(tracker.ReceivedPacket(13, protocol.ECNNon, rcvTime, true)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(false)).ToNot(BeNil())
|
|
})
|
|
|
|
It("only sets the timer when receiving a ack-eliciting packets", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNNon, time.Now(), false)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
Expect(tracker.GetAlarmTimeout()).To(BeZero())
|
|
rcvTime := time.Now().Add(10 * time.Millisecond)
|
|
Expect(tracker.ReceivedPacket(12, protocol.ECNNon, rcvTime, true)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
Expect(tracker.GetAlarmTimeout()).To(Equal(rcvTime.Add(protocol.MaxAckDelay)))
|
|
})
|
|
|
|
It("queues an ACK if the packet was ECN-CE marked", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNCE, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.AckRanges).To(HaveLen(1))
|
|
Expect(ack.AckRanges[0].Largest).To(Equal(protocol.PacketNumber(11)))
|
|
Expect(ack.ECNCE).To(BeEquivalentTo(1))
|
|
})
|
|
|
|
It("queues an ACK if it was reported missing before", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ReceivedPacket(13, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true) // ACK: 1-11 and 13, missing: 12
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.HasMissingRanges()).To(BeTrue())
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
Expect(tracker.ReceivedPacket(12, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ackQueued).To(BeTrue())
|
|
})
|
|
|
|
It("doesn't recognize in-order packets as out-of-order after raising the threshold", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.lastAck.LargestAcked()).To(Equal(protocol.PacketNumber(10)))
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
tracker.IgnoreBelow(11)
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
})
|
|
|
|
It("recognizes out-of-order packets after raising the threshold", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.lastAck.LargestAcked()).To(Equal(protocol.PacketNumber(10)))
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
tracker.IgnoreBelow(11)
|
|
Expect(tracker.ReceivedPacket(12, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.AckRanges).To(Equal([]wire.AckRange{{Smallest: 12, Largest: 12}}))
|
|
})
|
|
|
|
It("doesn't queue an ACK if for non-ack-eliciting packets arriving out-of-order", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
Expect(tracker.ReceivedPacket(13, protocol.ECNNon, time.Now(), false)).To(Succeed()) // receive a non-ack-eliciting packet out-of-order
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
})
|
|
|
|
It("doesn't queue an ACK if packets arrive out-of-order, but haven't been acknowledged yet", func() {
|
|
receiveAndAck10Packets()
|
|
Expect(tracker.lastAck).ToNot(BeNil())
|
|
Expect(tracker.ReceivedPacket(12, protocol.ECNNon, time.Now(), false)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
// 11 is received out-of-order, but this hasn't been reported in an ACK frame yet
|
|
Expect(tracker.ReceivedPacket(11, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
})
|
|
})
|
|
|
|
Context("ACK generation", func() {
|
|
It("generates an ACK for an ack-eliciting packet, if no ACK is queued yet", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
// The first packet is always acknowledged.
|
|
Expect(tracker.GetAckFrame(true)).ToNot(BeNil())
|
|
})
|
|
|
|
It("doesn't generate ACK for a non-ack-eliciting packet, if no ACK is queued yet", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
// The first packet is always acknowledged.
|
|
Expect(tracker.GetAckFrame(true)).ToNot(BeNil())
|
|
|
|
Expect(tracker.ReceivedPacket(2, protocol.ECNNon, time.Now(), false)).To(Succeed())
|
|
Expect(tracker.GetAckFrame(false)).To(BeNil())
|
|
Expect(tracker.ReceivedPacket(3, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(false)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(1)))
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(3)))
|
|
})
|
|
|
|
Context("for queued ACKs", func() {
|
|
BeforeEach(func() {
|
|
tracker.ackQueued = true
|
|
})
|
|
|
|
It("generates a simple ACK frame", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ReceivedPacket(2, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(2)))
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(1)))
|
|
Expect(ack.HasMissingRanges()).To(BeFalse())
|
|
})
|
|
|
|
It("generates an ACK for packet number 0", func() {
|
|
Expect(tracker.ReceivedPacket(0, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(0)))
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(0)))
|
|
Expect(ack.HasMissingRanges()).To(BeFalse())
|
|
})
|
|
|
|
It("sets the delay time", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ReceivedPacket(2, protocol.ECNNon, time.Now().Add(-1337*time.Millisecond), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.DelayTime).To(BeNumerically("~", 1337*time.Millisecond, 50*time.Millisecond))
|
|
})
|
|
|
|
It("uses a 0 delay time if the delay would be negative", func() {
|
|
Expect(tracker.ReceivedPacket(0, protocol.ECNNon, time.Now().Add(time.Hour), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.DelayTime).To(BeZero())
|
|
})
|
|
|
|
It("saves the last sent ACK", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(tracker.lastAck).To(Equal(ack))
|
|
Expect(tracker.ReceivedPacket(2, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
tracker.ackQueued = true
|
|
ack = tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(tracker.lastAck).To(Equal(ack))
|
|
})
|
|
|
|
It("generates an ACK frame with missing packets", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ReceivedPacket(4, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(4)))
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(1)))
|
|
Expect(ack.AckRanges).To(Equal([]wire.AckRange{
|
|
{Smallest: 4, Largest: 4},
|
|
{Smallest: 1, Largest: 1},
|
|
}))
|
|
})
|
|
|
|
It("generates an ACK for packet number 0 and other packets", func() {
|
|
Expect(tracker.ReceivedPacket(0, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
Expect(tracker.ReceivedPacket(3, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(3)))
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(0)))
|
|
Expect(ack.AckRanges).To(Equal([]wire.AckRange{
|
|
{Smallest: 3, Largest: 3},
|
|
{Smallest: 0, Largest: 1},
|
|
}))
|
|
})
|
|
|
|
It("errors when called with an old packet", func() {
|
|
tracker.IgnoreBelow(7)
|
|
Expect(tracker.IsPotentiallyDuplicate(4)).To(BeTrue())
|
|
Expect(tracker.ReceivedPacket(4, protocol.ECNNon, time.Now(), true)).To(MatchError("recevedPacketTracker BUG: ReceivedPacket called for old / duplicate packet 4"))
|
|
})
|
|
|
|
It("deletes packets from the packetHistory when a lower limit is set", func() {
|
|
for i := 1; i <= 12; i++ {
|
|
Expect(tracker.ReceivedPacket(protocol.PacketNumber(i), protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
}
|
|
tracker.IgnoreBelow(7)
|
|
// check that the packets were deleted from the receivedPacketHistory by checking the values in an ACK frame
|
|
ack := tracker.GetAckFrame(true)
|
|
Expect(ack).ToNot(BeNil())
|
|
Expect(ack.LargestAcked()).To(Equal(protocol.PacketNumber(12)))
|
|
Expect(ack.LowestAcked()).To(Equal(protocol.PacketNumber(7)))
|
|
Expect(ack.HasMissingRanges()).To(BeFalse())
|
|
})
|
|
|
|
It("resets all counters needed for the ACK queueing decision when sending an ACK", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
tracker.ackAlarm = time.Now().Add(-time.Minute)
|
|
Expect(tracker.GetAckFrame(true)).ToNot(BeNil())
|
|
Expect(tracker.GetAlarmTimeout()).To(BeZero())
|
|
Expect(tracker.ackElicitingPacketsReceivedSinceLastAck).To(BeZero())
|
|
Expect(tracker.ackQueued).To(BeFalse())
|
|
})
|
|
|
|
It("doesn't generate an ACK when none is queued and the timer is not set", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
tracker.ackQueued = false
|
|
tracker.ackAlarm = time.Time{}
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
})
|
|
|
|
It("doesn't generate an ACK when none is queued and the timer has not yet expired", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
tracker.ackQueued = false
|
|
tracker.ackAlarm = time.Now().Add(time.Minute)
|
|
Expect(tracker.GetAckFrame(true)).To(BeNil())
|
|
})
|
|
|
|
It("generates an ACK when the timer has expired", func() {
|
|
Expect(tracker.ReceivedPacket(1, protocol.ECNNon, time.Now(), true)).To(Succeed())
|
|
tracker.ackQueued = false
|
|
tracker.ackAlarm = time.Now().Add(-time.Minute)
|
|
Expect(tracker.GetAckFrame(true)).ToNot(BeNil())
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|