From 05163f8a36354aa43b8c49b8b53feddd9b6fd26b Mon Sep 17 00:00:00 2001 From: sergeyfrolov Date: Wed, 20 Mar 2019 11:58:53 -0600 Subject: [PATCH] Fix TLS 1.2 session cache (#28) Currently, SessionCache is not used for non-HelloGolang fingerprints, and this PR is what the fix would potentially look like. This is only for the TLS 1.2, support for TLS 1.3 PSK resumption cache remains a TODO. Fixes #27 --- u_parrots.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/u_parrots.go b/u_parrots.go index b744ee8..6d34880 100644 --- a/u_parrots.go +++ b/u_parrots.go @@ -427,6 +427,11 @@ func (uconn *UConn) ApplyPreset(p *ClientHelloSpec) error { } grease_extensions_seen += 1 case *SessionTicketExtension: + if session == nil && uconn.config.ClientSessionCache != nil { + cacheKey := clientSessionCacheKey(uconn.RemoteAddr(), uconn.config) + session, _ = uconn.config.ClientSessionCache.Get(cacheKey) + // TODO: use uconn.loadSession(hello.getPrivatePtr()) to support TLS 1.3 PSK-style resumption + } err := uconn.SetSessionState(session) if err != nil { return err