mirrors/utls
1
0
Fork 0
mirror of https://github.com/refraction-networking/utls.git synced 2025-04-03 03:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix panic in u_public by never dereferencing (#30)

Browse source 
In order to avoid panics, we make sure that no pointer is dereferenced
during transformation between public and private handshake states.
Fixes #29
This commit is contained in:
sergeyfrolov 2019-04-15 13:36:40 -06:00 • committed by GitHub
parent a4f906cb90
commit 32987941eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
u_conn.go
View file

@ -361,7 +361,9 @@ func (c *UConn) clientHandshake() (err error) {
}
// In TLS 1.3, session tickets are delivered after the handshake.
err = hs13.handshake()
c.HandshakeState = *hs13.toPublic13()
if handshakeState := hs13.toPublic13(); handshakeState != nil {
c.HandshakeState = *handshakeState
}
return err
}
@ -369,7 +371,9 @@ func (c *UConn) clientHandshake() (err error) {
hs12.serverHello = serverHello
hs12.hello = hello
err = hs12.handshake()
c.HandshakeState = *hs12.toPublic12()
if handshakeState := hs12.toPublic12(); handshakeState != nil {
c.HandshakeState = *handshakeState
}
if err != nil {
return err
}