mirror of
https://github.com/refraction-networking/utls.git
synced 2025-04-04 04:27:36 +03:00
crypto/tls: test with FIPS 140-3 TLS mode
For tests that are interested in testing the difference between TLS in FIPS 140-3 required mode or otherwise two new helpers are introduced, runWithFIPSEnabled and runWithFIPSDisabled. They take care of forcing the correct TLS FIPS 140-3 state regardless of the overal GODEBUG=fips state, and restoring it afterwards. For the tests that use features or test data not appropriate for TLS in FIPS 140-3 required mode we add skips. For some tests we can make them appropriate for both TLS FIPS 140-3 required or not by tweaking some parameters that weren't important to the subject under test, but would otherwise preclude TLS FIPS 140-3 required mode (e.g. because they used TLS 1.0 when the test could use TLS 1.2 instead). For others, switching test certificates to a RSA 2048 hierarchy is sufficient. We avoid regenerating the existing RSA 1024 certs as 2048 since it would invalidate recorded static flow data. Tests that rely on static message flows (primarily the client and server handshake) tests are skipped due to FIPS mode being non-deterministic and inappropriate for this style of testing. Change-Id: I311f3828dac890bb3ff8ebda6ed73d50f0797110 Reviewed-on: https://go-review.googlesource.com/c/go/+/629736 Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This commit is contained in:
Daniel McCarney
Filippo Valsorda
parent
212bbb2c77
commit
4cb059fbbf
8 changed files with 238 additions and 118 deletions
|
|
@ -11,6 +11,7 @@ import (
|
|||
"crypto/elliptic"
|
||||
"crypto/rand"
|
||||
"crypto/rsa"
|
||||
"crypto/tls/internal/fips140tls"
|
||||
"crypto/x509"
|
||||
"crypto/x509/pkix"
|
||||
"encoding/base64"
|
||||
|
|
@ -848,13 +849,16 @@ func testResumption(t *testing.T, version uint16) {
|
|||
if testing.Short() {
|
||||
t.Skip("skipping in -short mode")
|
||||
}
|
||||
|
||||
// Note: using RSA 2048 test certificates because they are compatible with FIPS mode.
|
||||
testCertificates := []Certificate{{Certificate: [][]byte{testRSA2048Certificate}, PrivateKey: testRSA2048PrivateKey}}
|
||||
serverConfig := &Config{
|
||||
MaxVersion: version,
|
||||
CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA, TLS_ECDHE_RSA_WITH_RC4_128_SHA},
|
||||
Certificates: testConfig.Certificates,
|
||||
CipherSuites: []uint16{TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
|
||||
Certificates: testCertificates,
|
||||
}
|
||||
|
||||
issuer, err := x509.ParseCertificate(testRSACertificateIssuer)
|
||||
issuer, err := x509.ParseCertificate(testRSA2048CertificateIssuer)
|
||||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
|
|
@ -864,7 +868,7 @@ func testResumption(t *testing.T, version uint16) {
|
|||
|
||||
clientConfig := &Config{
|
||||
MaxVersion: version,
|
||||
CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA},
|
||||
CipherSuites: []uint16{TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
|
||||
ClientSessionCache: NewLRUClientSessionCache(32),
|
||||
RootCAs: rootCAs,
|
||||
ServerName: "example.golang",
|
||||
|
|
@ -982,8 +986,8 @@ func testResumption(t *testing.T, version uint16) {
|
|||
// before the serverConfig is used works.
|
||||
serverConfig = &Config{
|
||||
MaxVersion: version,
|
||||
CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA, TLS_ECDHE_RSA_WITH_RC4_128_SHA},
|
||||
Certificates: testConfig.Certificates,
|
||||
CipherSuites: []uint16{TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
|
||||
Certificates: testCertificates,
|
||||
}
|
||||
serverConfig.SetSessionTicketKeys([][32]byte{key2})
|
||||
|
||||
|
|
@ -992,7 +996,7 @@ func testResumption(t *testing.T, version uint16) {
|
|||
// In TLS 1.3, cross-cipher suite resumption is allowed as long as the KDF
|
||||
// hash matches. Also, Config.CipherSuites does not apply to TLS 1.3.
|
||||
if version != VersionTLS13 {
|
||||
clientConfig.CipherSuites = []uint16{TLS_ECDHE_RSA_WITH_RC4_128_SHA}
|
||||
clientConfig.CipherSuites = []uint16{TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384}
|
||||
testResumeState("DifferentCipherSuite", false)
|
||||
testResumeState("DifferentCipherSuiteRecovers", true)
|
||||
}
|
||||
|
|
@ -1008,7 +1012,7 @@ func testResumption(t *testing.T, version uint16) {
|
|||
// Use a different curve than the client to force a HelloRetryRequest.
|
||||
CurvePreferences: []CurveID{CurveP521, CurveP384, CurveP256},
|
||||
MaxVersion: version,
|
||||
Certificates: testConfig.Certificates,
|
||||
Certificates: testCertificates,
|
||||
}
|
||||
testResumeState("InitialHandshake", false)
|
||||
testResumeState("WithHelloRetryRequest", true)
|
||||
|
|
@ -1016,8 +1020,8 @@ func testResumption(t *testing.T, version uint16) {
|
|||
// Reset serverConfig back.
|
||||
serverConfig = &Config{
|
||||
MaxVersion: version,
|
||||
CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA, TLS_ECDHE_RSA_WITH_RC4_128_SHA},
|
||||
Certificates: testConfig.Certificates,
|
||||
CipherSuites: []uint16{TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
|
||||
Certificates: testCertificates,
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -1272,7 +1276,7 @@ func TestServerSelectingUnconfiguredApplicationProtocol(t *testing.T) {
|
|||
go func() {
|
||||
client := Client(c, &Config{
|
||||
ServerName: "foo",
|
||||
CipherSuites: []uint16{TLS_RSA_WITH_AES_128_GCM_SHA256},
|
||||
CipherSuites: []uint16{TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
|
||||
NextProtos: []string{"http", "something-else"},
|
||||
})
|
||||
errChan <- client.Handshake()
|
||||
|
|
@ -1292,7 +1296,7 @@ func TestServerSelectingUnconfiguredApplicationProtocol(t *testing.T) {
|
|||
serverHello := &serverHelloMsg{
|
||||
vers: VersionTLS12,
|
||||
random: make([]byte, 32),
|
||||
cipherSuite: TLS_RSA_WITH_AES_128_GCM_SHA256,
|
||||
cipherSuite: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
|
||||
alpnProtocol: "how-about-this",
|
||||
}
|
||||
serverHelloBytes := mustMarshal(t, serverHello)
|
||||
|
|
@ -1308,7 +1312,7 @@ func TestServerSelectingUnconfiguredApplicationProtocol(t *testing.T) {
|
|||
s.Close()
|
||||
|
||||
if err := <-errChan; !strings.Contains(err.Error(), "server selected unadvertised ALPN protocol") {
|
||||
t.Fatalf("Expected error about unconfigured cipher suite but got %q", err)
|
||||
t.Fatalf("Expected error about unconfigured ALPN protocol but got %q", err)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -1724,7 +1728,10 @@ func testVerifyConnection(t *testing.T, version uint16) {
|
|||
},
|
||||
}
|
||||
for _, test := range tests {
|
||||
issuer, err := x509.ParseCertificate(testRSACertificateIssuer)
|
||||
// Note: using RSA 2048 test certificates because they are compatible with FIPS mode.
|
||||
testCertificates := []Certificate{{Certificate: [][]byte{testRSA2048Certificate}, PrivateKey: testRSA2048PrivateKey}}
|
||||
|
||||
issuer, err := x509.ParseCertificate(testRSA2048CertificateIssuer)
|
||||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
|
|
@ -1735,7 +1742,7 @@ func testVerifyConnection(t *testing.T, version uint16) {
|
|||
|
||||
serverConfig := &Config{
|
||||
MaxVersion: version,
|
||||
Certificates: []Certificate{testConfig.Certificates[0]},
|
||||
Certificates: testCertificates,
|
||||
ClientCAs: rootCAs,
|
||||
NextProtos: []string{"protocol1"},
|
||||
}
|
||||
|
|
@ -1748,7 +1755,7 @@ func testVerifyConnection(t *testing.T, version uint16) {
|
|||
ClientSessionCache: NewLRUClientSessionCache(32),
|
||||
RootCAs: rootCAs,
|
||||
ServerName: "example.golang",
|
||||
Certificates: []Certificate{testConfig.Certificates[0]},
|
||||
Certificates: testCertificates,
|
||||
NextProtos: []string{"protocol1"},
|
||||
}
|
||||
test.configureClient(clientConfig, &clientCalled)
|
||||
|
|
@ -1783,7 +1790,8 @@ func TestVerifyPeerCertificate(t *testing.T) {
|
|||
}
|
||||
|
||||
func testVerifyPeerCertificate(t *testing.T, version uint16) {
|
||||
issuer, err := x509.ParseCertificate(testRSACertificateIssuer)
|
||||
// Note: using RSA 2048 test certificates because they are compatible with FIPS mode.
|
||||
issuer, err := x509.ParseCertificate(testRSA2048CertificateIssuer)
|
||||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
|
|
@ -2041,8 +2049,8 @@ func testVerifyPeerCertificate(t *testing.T, version uint16) {
|
|||
config.Time = now
|
||||
config.MaxVersion = version
|
||||
config.Certificates = make([]Certificate, 1)
|
||||
config.Certificates[0].Certificate = [][]byte{testRSACertificate}
|
||||
config.Certificates[0].PrivateKey = testRSAPrivateKey
|
||||
config.Certificates[0].Certificate = [][]byte{testRSA2048Certificate}
|
||||
config.Certificates[0].PrivateKey = testRSA2048PrivateKey
|
||||
config.Certificates[0].SignedCertificateTimestamps = [][]byte{[]byte("dummy sct 1"), []byte("dummy sct 2")}
|
||||
config.Certificates[0].OCSPStaple = []byte("dummy ocsp")
|
||||
test.configureServer(config, &serverCalled)
|
||||
|
|
@ -2053,6 +2061,7 @@ func testVerifyPeerCertificate(t *testing.T, version uint16) {
|
|||
}()
|
||||
|
||||
config := testConfig.Clone()
|
||||
config.Certificates = []Certificate{{Certificate: [][]byte{testRSA2048Certificate}, PrivateKey: testRSA2048PrivateKey}}
|
||||
config.ServerName = "example.golang"
|
||||
config.RootCAs = rootCAs
|
||||
config.Time = now
|
||||
|
|
@ -2336,8 +2345,8 @@ var getClientCertificateTests = []struct {
|
|||
panic("empty AcceptableCAs")
|
||||
}
|
||||
cert := &Certificate{
|
||||
Certificate: [][]byte{testRSACertificate},
|
||||
PrivateKey: testRSAPrivateKey,
|
||||
Certificate: [][]byte{testRSA2048Certificate},
|
||||
PrivateKey: testRSA2048PrivateKey,
|
||||
}
|
||||
return cert, nil
|
||||
}
|
||||
|
|
@ -2357,13 +2366,15 @@ func TestGetClientCertificate(t *testing.T) {
|
|||
}
|
||||
|
||||
func testGetClientCertificate(t *testing.T, version uint16) {
|
||||
issuer, err := x509.ParseCertificate(testRSACertificateIssuer)
|
||||
// Note: using RSA 2048 test certificates because they are compatible with FIPS mode.
|
||||
issuer, err := x509.ParseCertificate(testRSA2048CertificateIssuer)
|
||||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
|
||||
for i, test := range getClientCertificateTests {
|
||||
serverConfig := testConfig.Clone()
|
||||
serverConfig.Certificates = []Certificate{{Certificate: [][]byte{testRSA2048Certificate}, PrivateKey: testRSA2048PrivateKey}}
|
||||
serverConfig.ClientAuth = VerifyClientCertIfGiven
|
||||
serverConfig.RootCAs = x509.NewCertPool()
|
||||
serverConfig.RootCAs.AddCert(issuer)
|
||||
|
|
@ -2372,10 +2383,17 @@ func testGetClientCertificate(t *testing.T, version uint16) {
|
|||
serverConfig.MaxVersion = version
|
||||
|
||||
clientConfig := testConfig.Clone()
|
||||
clientConfig.Certificates = []Certificate{{Certificate: [][]byte{testRSA2048Certificate}, PrivateKey: testRSA2048PrivateKey}}
|
||||
clientConfig.MaxVersion = version
|
||||
|
||||
test.setup(clientConfig, serverConfig)
|
||||
|
||||
// TLS 1.1 isn't available for FIPS required
|
||||
if fips140tls.Required() && clientConfig.MaxVersion == VersionTLS11 {
|
||||
t.Logf("skipping test %d for FIPS mode", i)
|
||||
continue
|
||||
}
|
||||
|
||||
type serverResult struct {
|
||||
cs ConnectionState
|
||||
err error
|
||||
|
|
@ -2514,11 +2532,15 @@ func TestDowngradeCanary(t *testing.T) {
|
|||
if err := testDowngradeCanary(t, VersionTLS12, VersionTLS12); err != nil {
|
||||
t.Errorf("client didn't ignore expected TLS 1.2 canary")
|
||||
}
|
||||
if err := testDowngradeCanary(t, VersionTLS11, VersionTLS11); err != nil {
|
||||
t.Errorf("client unexpectedly reacted to a canary in TLS 1.1")
|
||||
}
|
||||
if err := testDowngradeCanary(t, VersionTLS10, VersionTLS10); err != nil {
|
||||
t.Errorf("client unexpectedly reacted to a canary in TLS 1.0")
|
||||
if !fips140tls.Required() {
|
||||
if err := testDowngradeCanary(t, VersionTLS11, VersionTLS11); err != nil {
|
||||
t.Errorf("client unexpectedly reacted to a canary in TLS 1.1")
|
||||
}
|
||||
if err := testDowngradeCanary(t, VersionTLS10, VersionTLS10); err != nil {
|
||||
t.Errorf("client unexpectedly reacted to a canary in TLS 1.0")
|
||||
}
|
||||
} else {
|
||||
t.Logf("skiping TLS 1.1 and TLS 1.0 downgrade canary checks in FIPS mode")
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -2528,7 +2550,8 @@ func TestResumptionKeepsOCSPAndSCT(t *testing.T) {
|
|||
}
|
||||
|
||||
func testResumptionKeepsOCSPAndSCT(t *testing.T, ver uint16) {
|
||||
issuer, err := x509.ParseCertificate(testRSACertificateIssuer)
|
||||
// Note: using RSA 2048 test certificates because they are compatible with FIPS mode.
|
||||
issuer, err := x509.ParseCertificate(testRSA2048CertificateIssuer)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to parse test issuer")
|
||||
}
|
||||
|
|
@ -2541,6 +2564,7 @@ func testResumptionKeepsOCSPAndSCT(t *testing.T, ver uint16) {
|
|||
RootCAs: roots,
|
||||
}
|
||||
serverConfig := testConfig.Clone()
|
||||
serverConfig.Certificates = []Certificate{{Certificate: [][]byte{testRSA2048Certificate}, PrivateKey: testRSA2048PrivateKey}}
|
||||
serverConfig.MaxVersion = ver
|
||||
serverConfig.Certificates[0].OCSPStaple = []byte{1, 2, 3}
|
||||
serverConfig.Certificates[0].SignedCertificateTimestamps = [][]byte{{4, 5, 6}}
|
||||
|
|
@ -2675,11 +2699,15 @@ func testTLS13OnlyClientHelloCipherSuite(t *testing.T, ciphers []uint16) {
|
|||
serverConfig := &Config{
|
||||
Certificates: testConfig.Certificates,
|
||||
GetConfigForClient: func(chi *ClientHelloInfo) (*Config, error) {
|
||||
if len(chi.CipherSuites) != len(defaultCipherSuitesTLS13NoAES) {
|
||||
expectedCiphersuites := defaultCipherSuitesTLS13NoAES
|
||||
if fips140tls.Required() {
|
||||
expectedCiphersuites = defaultCipherSuitesTLS13FIPS
|
||||
}
|
||||
if len(chi.CipherSuites) != len(expectedCiphersuites) {
|
||||
t.Errorf("only TLS 1.3 suites should be advertised, got=%x", chi.CipherSuites)
|
||||
} else {
|
||||
for i := range defaultCipherSuitesTLS13NoAES {
|
||||
if want, got := defaultCipherSuitesTLS13NoAES[i], chi.CipherSuites[i]; want != got {
|
||||
for i := range expectedCiphersuites {
|
||||
if want, got := expectedCiphersuites[i], chi.CipherSuites[i]; want != got {
|
||||
t.Errorf("cipher at index %d does not match, want=%x, got=%x", i, want, got)
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue