mirrors/utls
1
0
Fork 0
mirror of https://github.com/refraction-networking/utls.git synced 2025-04-03 20:17:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

crypto/tls: apply QUIC session event flag to QUICResumeSession events

Browse source 
Go 1.23 adds two new events to QUICConns: QUICStoreSessionEvent and
QUICResumeSessionEvent. We added a QUICConfig.EnableStoreSessionEvent
flag to control whether the store-session event is provided or not,
because receiving this event requires additional action from the caller:
the session must be explicitly stored with QUICConn.StoreSession.

We did not add a control for whether the resume-session event is
provided, because this event requires no action and the caller is
expected to ignore unknown events.

However, we never documented the expectation that callers ignore
unknown events, and quic-go produces an error when receiving an
unexpected event. So change the EnableStoreSessionEvent flag to
apply to both new events.

Fixes #68124
For #63691

Change-Id: I84af487e52b3815f7b648e09884608f8915cd645
Reviewed-on: https://go-review.googlesource.com/c/go/+/594475
Reviewed-by: Marten Seemann <martenseemann@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
This commit is contained in:
Damien Neil 2024-06-24 10:01:47 -07:00
parent 861b74c00c
commit 8b177082b2
5 changed files with 98 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

16
quic.go
View file

@ -50,12 +50,12 @@ type QUICConn struct {
type QUICConfig struct {
TLSConfig *Config
// EnableStoreSessionEvent may be set to true to enable the
// [QUICStoreSession] event for client connections.
// EnableSessionEvents may be set to true to enable the
// [QUICStoreSession] and [QUICResumeSession] events for client connections.
// When this event is enabled, sessions are not automatically
// stored in the client session cache.
// The application should use [QUICConn.StoreSession] to store sessions.
EnableStoreSessionEvent bool
EnableSessionEvents bool
}
// A QUICEventKind is a type of operation on a QUIC connection.
@ -113,7 +113,7 @@ const (
// QUICStoreSession indicates that the server has provided state permitting
// the client to resume the session.
// [QUICEvent.SessionState] is set.
// The application should use [QUICConn.Store] session to store the [SessionState].
// The application should use [QUICConn.StoreSession] session to store the [SessionState].
// The application may modify the [SessionState] before storing it.
// This event only occurs on client connections.
QUICStoreSession
@ -165,7 +165,7 @@ type quicState struct {
transportParams []byte // to send to the peer
enableStoreSessionEvent bool
enableSessionEvents bool
}
// QUICClient returns a new TLS client side connection using QUICTransport as the
@ -186,9 +186,9 @@ func QUICServer(config *QUICConfig) *QUICConn {
func newQUICConn(conn *Conn, config *QUICConfig) *QUICConn {
conn.quic = &quicState{
signalc: make(chan struct{}),
blockedc: make(chan struct{}),
enableStoreSessionEvent: config.EnableStoreSessionEvent,
signalc: make(chan struct{}),
blockedc: make(chan struct{}),
enableSessionEvents: config.EnableSessionEvents,
}
conn.quic.events = conn.quic.eventArr[:0]
return &QUICConn{