mirrors/utls
1
0
Fork 0
mirror of https://github.com/refraction-networking/utls.git synced 2025-04-04 12:37:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

all: document legacy //go:linkname for modules with ≥5,000 dependents

Browse source 
For #67401.

Change-Id: Ifea84af92017b405466937f50fb8f28e6893c8cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/587220
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Russ Cox <rsc@golang.org>
This commit is contained in:
Russ Cox 2024-05-21 23:50:52 -04:00 • committed by Gopher Robot
parent 2621b1f66c
commit a58f39d686
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
badlinkname.go
View file

@ -14,9 +14,6 @@ import _ "unsafe"
//go:linkname aeadAESGCMTLS13 //go:linkname aeadAESGCMTLS13
//go:linkname cipherSuiteTLS13ByID //go:linkname cipherSuiteTLS13ByID
//go:linkname cipherSuitesTLS13
//go:linkname defaultCipherSuitesTLS13
//go:linkname defaultCipherSuitesTLS13NoAES
//go:linkname errShutdown //go:linkname errShutdown
// The compiler doesn't allow linknames on methods, for good reasons. // The compiler doesn't allow linknames on methods, for good reasons.

10
cipher_suites.go
View file

@ -18,6 +18,7 @@ import (
"hash" "hash"
"internal/cpu" "internal/cpu"
"runtime" "runtime"
_ "unsafe" // for linkname
"golang.org/x/crypto/chacha20poly1305" "golang.org/x/crypto/chacha20poly1305"
) )
@ -197,6 +198,15 @@ type cipherSuiteTLS13 struct {
hash crypto.Hash hash crypto.Hash
} }
// cipherSuitesTLS13 should be an internal detail,
// but widely used packages access it using linkname.
// Notable members of the hall of shame include:
// - github.com/quic-go/quic-go
//
// Do not remove or change the type signature.
// See go.dev/issue/67401.
//
//go:linkname cipherSuitesTLS13
var cipherSuitesTLS13 = []*cipherSuiteTLS13{ // TODO: replace with a map. var cipherSuitesTLS13 = []*cipherSuiteTLS13{ // TODO: replace with a map.
{TLS_AES_128_GCM_SHA256, 16, aeadAESGCMTLS13, crypto.SHA256}, {TLS_AES_128_GCM_SHA256, 16, aeadAESGCMTLS13, crypto.SHA256},
{TLS_CHACHA20_POLY1305_SHA256, 32, aeadChaCha20Poly1305, crypto.SHA256}, {TLS_CHACHA20_POLY1305_SHA256, 32, aeadChaCha20Poly1305, crypto.SHA256},