mirror of
https://github.com/refraction-networking/utls.git
synced 2025-04-04 20:47:36 +03:00
74ff008a9d
A test that checks if "tls.(*Conn)" appears in any symbol's name. tls.Conn is a type, so the string "tls.(*Conn)" can only appear in the name of a method of Conn. But the test code doesn't use any of the methods. Not sure why this needs to be live. In particular, the linker is now able to prune all methods of Conn. Remove this requirement. In fact, just drop the only_conn test case, as simply allocating a type doesn't necessarily bring anything live. Change-Id: I754291b75d38e1465b5291b4dea20806615d21b3 Reviewed-on: https://go-review.googlesource.com/c/go/+/257973 Trust: Cherry Zhang <cherryyz@google.com> Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Jeremy Faller <jeremy@golang.org>
108 lines
2.4 KiB
Go
108 lines
2.4 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package tls
|
|
|
|
import (
|
|
"bytes"
|
|
"internal/testenv"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
// Tests that the linker is able to remove references to the Client or Server if unused.
|
|
func TestLinkerGC(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping in short mode")
|
|
}
|
|
t.Parallel()
|
|
goBin := testenv.GoToolPath(t)
|
|
testenv.MustHaveGoBuild(t)
|
|
|
|
tests := []struct {
|
|
name string
|
|
program string
|
|
want []string
|
|
bad []string
|
|
}{
|
|
{
|
|
name: "empty_import",
|
|
program: `package main
|
|
import _ "crypto/tls"
|
|
func main() {}
|
|
`,
|
|
bad: []string{
|
|
"tls.(*Conn)",
|
|
"type.crypto/tls.clientHandshakeState",
|
|
"type.crypto/tls.serverHandshakeState",
|
|
},
|
|
},
|
|
{
|
|
name: "client_and_server",
|
|
program: `package main
|
|
import "crypto/tls"
|
|
func main() {
|
|
tls.Dial("", "", nil)
|
|
tls.Server(nil, nil)
|
|
}
|
|
`,
|
|
want: []string{
|
|
"crypto/tls.(*Conn).clientHandshake",
|
|
"crypto/tls.(*Conn).serverHandshake",
|
|
},
|
|
},
|
|
{
|
|
name: "only_client",
|
|
program: `package main
|
|
import "crypto/tls"
|
|
func main() { tls.Dial("", "", nil) }
|
|
`,
|
|
want: []string{
|
|
"crypto/tls.(*Conn).clientHandshake",
|
|
},
|
|
bad: []string{
|
|
"crypto/tls.(*Conn).serverHandshake",
|
|
},
|
|
},
|
|
// TODO: add only_server like func main() { tls.Server(nil, nil) }
|
|
// That currently brings in the client via Conn.handleRenegotiation.
|
|
|
|
}
|
|
tmpDir := t.TempDir()
|
|
goFile := filepath.Join(tmpDir, "x.go")
|
|
exeFile := filepath.Join(tmpDir, "x.exe")
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if err := ioutil.WriteFile(goFile, []byte(tt.program), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
os.Remove(exeFile)
|
|
cmd := exec.Command(goBin, "build", "-o", "x.exe", "x.go")
|
|
cmd.Dir = tmpDir
|
|
if out, err := cmd.CombinedOutput(); err != nil {
|
|
t.Fatalf("compile: %v, %s", err, out)
|
|
}
|
|
|
|
cmd = exec.Command(goBin, "tool", "nm", "x.exe")
|
|
cmd.Dir = tmpDir
|
|
nm, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("nm: %v, %s", err, nm)
|
|
}
|
|
for _, sym := range tt.want {
|
|
if !bytes.Contains(nm, []byte(sym)) {
|
|
t.Errorf("expected symbol %q not found", sym)
|
|
}
|
|
}
|
|
for _, sym := range tt.bad {
|
|
if bytes.Contains(nm, []byte(sym)) {
|
|
t.Errorf("unexpected symbol %q found", sym)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|