mirrors/utls
1
0
Fork 0
mirror of https://github.com/refraction-networking/utls.git synced 2025-04-03 20:17:36 +03:00
Code Issues Projects Releases Packages Wiki Activity
Fork of the Go standard TLS library, providing low-level access to the ClientHello for mimicry purposes.
285 commits 7 branches 42 tags 12 MiB
Find a file
Daniel e548024677 crypto/tls: create certs w/o KeyEncipherment KU for non-RSA keys in generate_cert.go 
Summary

The crypto/tls/generate_cert.go utility should only set the template
x509.Certificate's KeyUsage field to a value with the
x509.KeyUsageKeyEncipherment bits set when the certificate subject
public key is an RSA public key, not an ECDSA or ED25519 public key.

Background

RFC 5480 describes the usage of ECDSA elliptic curve subject keys with
X.509. Unfortunately while Section 3 "Key Usages Bits" indicates which
key usage bits MAY be used with a certificate that indicates
id-ecPublicKey in the SubjectPublicKeyInfo field it doesn't provide
guidance on which usages should *not* be included (e.g. the
keyEncipherment bit, which is particular to RSA key exchange). The same
problem is present in RFC 8410 Section 5 describing Key Usage Bits for
ED25519 elliptic curve subject keys.

There's an update to RFC 5480 in last call stage within the IETF LAMPS
WG, draft-ietf-lamps-5480-ku-clarifications-00. This update is meant
to clarify the allowed Key Usages extension values for certificates with
ECDSA subject public keys by adding:

> If the keyUsage extension is present in a certificate that indicates
> id-ecPublicKey as algorithm of AlgorithmIdentifier [RFC2986] in
> SubjectPublicKeyInfo, then following values MUST NOT be present:
>
> keyEncipherment; and
> dataEncipherment.

I don't believe there is an update for RFC 8410 in the works but I
suspect it will be clarified similarly in the future.

This commit updates generate_cert.go to ensure when the certificate
public key is ECDSA or ED25519 the generated certificate has the
x509.Certificate.KeyUsage field set to a value that doesn't include KUs
specific to RSA. For ECDSA keys this will adhere to the updated RFC 5480
language.

Fixes #36499

Change-Id: Ib1b0757c039b7fe97fc6d1e826fe6b88856c1964
GitHub-Last-Rev: a8f34fb33dde90e09b6f9a27b2598a82b3023abb
GitHub-Pull-Request: golang/go#36500
Reviewed-on: https://go-review.googlesource.com/c/go/+/214337
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-07-03 03:31:29 +00:00
testdata crypto/tls: rotate session keys in older TLS versions 2020-05-07 18:33:39 +00:00
alert.go crypto/tls: add missing alert values 2020-04-01 19:32:57 +00:00
auth.go crypto/tls: add {SignatureScheme,CurveID,ClientAuthType}.String() 2020-03-11 20:02:18 +00:00
auth_test.go crypto/tls: add {SignatureScheme,CurveID,ClientAuthType}.String() 2020-03-11 20:02:18 +00:00
cipher_suites.go crypto/tls: add CipherSuites, InsecureCipherSuites and CipherSuiteName 2019-11-12 01:09:31 +00:00
common.go crypto/tls: expand the ConnectionState docs 2020-06-24 20:22:03 +00:00
common_string.go crypto/tls: add {SignatureScheme,CurveID,ClientAuthType}.String() 2020-03-11 20:02:18 +00:00
conn.go crypto/tls: add Config.VerifyConnection callback 2020-05-08 02:17:26 +00:00
conn_test.go crypto/tls: select only compatible chains from Certificates 2019-11-12 01:08:57 +00:00
example_test.go crypto/tls: replace VerifyPeerCertificate example with VerifyConnection 2020-06-24 20:48:12 +00:00
generate_cert.go crypto/tls: create certs w/o KeyEncipherment KU for non-RSA keys in generate_cert.go 2020-07-03 03:31:29 +00:00
handshake_client.go crypto/tls: restore OCSP and SCTs during session resumption 2020-06-09 23:24:08 +00:00
handshake_client_test.go crypto/tls: restore OCSP and SCTs during session resumption 2020-06-09 23:24:08 +00:00
handshake_client_tls13.go crypto/tls: restore OCSP and SCTs during session resumption 2020-06-09 23:24:08 +00:00
handshake_messages.go crypto/tls: send ec_points_format extension in ServerHello 2019-10-31 15:14:45 +00:00
handshake_messages_test.go crypto/tls: rotate session keys in older TLS versions 2020-05-07 18:33:39 +00:00
handshake_server.go crypto/tls: set CipherSuite for VerifyConnection 2020-06-04 20:16:53 +00:00
handshake_server_test.go crypto/tls: rotate session ticket keys 2020-05-08 02:00:35 +00:00
handshake_server_tls13.go crypto/tls: fix duplicate calls to VerifyConnection 2020-06-03 19:01:50 +00:00
handshake_test.go crypto/tls: retry ETIMEDOUT flakes in localPipe on dragonfly 2019-11-12 17:55:14 +00:00
handshake_unix_test.go crypto/tls: retry net.Dial flakes on Dragonfly 2019-10-21 19:06:29 +00:00
key_agreement.go crypto/tls: refactor certificate and signature algorithm logic 2019-11-12 01:07:15 +00:00
key_schedule.go math/big: add (*Int).FillBytes 2020-05-05 00:36:44 +00:00
key_schedule_test.go crypto/tls: implement TLS 1.3 cryptographic computations 2018-11-02 21:54:52 +00:00
link_test.go crypto/tls: help linker remove code when only Client or Server is used 2020-04-15 19:49:43 +00:00
prf.go crypto/tls: improve error messages for invalid certificates and signatures 2019-10-30 20:18:59 +00:00
prf_test.go crypto/tls: remove SSLv3 support 2019-08-27 22:24:05 +00:00
ticket.go crypto/tls: remove version check when unmarshaling sessionState 2020-05-18 23:09:31 +00:00
tls.go crypto/tls: fix DialContext docs 2020-06-24 20:17:05 +00:00
tls_test.go crypto/tls: test that Clone copies session ticket key fields 2020-06-03 19:23:34 +00:00