lib: remove RELEASE_NUMBERS_AND_DEV, use RELEASE_NUMBERS

In the lifecycle of vX.Y.Z, all tests are run against vX.Y-test
before it is published, including when the tag is pushed because the
automated release process now runs end-to-end before pushing the
release to forgejo-experimental.

Running end-to-end against vX.Y-dev is therefore redundant with at least
two other runs with exactly the same SHA (the one before the tag is
pushed and the one when the tag is pushed). There would be value in
doing that if it allowed to detect race conditions in Forgejo. But
such races were not found in the past six months and there is a lot
more scrutiny on commits merged in Forgejo which makes it even less
likely than it was before.

Running the tests on vX.Y instead of also including the built version
provide the same coverage and reduces the workload.
This commit is contained in:
Earl Warren 2024-08-08 16:48:39 +02:00
parent 996373c707
commit 427c46dbf9
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
15 changed files with 5 additions and 7 deletions

View file

@ -88,7 +88,7 @@ function actions_runner_version() {
} }
function test_actions() { function test_actions() {
local versions="${1:-$RELEASE_NUMBERS_AND_DEV}" local versions="${1:-$RELEASE_NUMBERS}"
for version in $versions; do for version in $versions; do

View file

@ -69,7 +69,7 @@ function test_federation() {
# start_gitlab octobus/heptapod:1.5.3 # start_gitlab octobus/heptapod:1.5.3
federation_setup_variables federation_setup_variables
local versions="${1:-$RELEASE_NUMBERS_AND_DEV}" local versions="${1:-$RELEASE_NUMBERS}"
for version in $versions; do for version in $versions; do

View file

@ -35,7 +35,6 @@ export DOT_FORGEJO_CURL=$DIR/forgejo-curl
export DOT=$DOT_FORGEJO_CURL # for backward compatibility with forgejo-curl.sh 1.0.0 export DOT=$DOT_FORGEJO_CURL # for backward compatibility with forgejo-curl.sh 1.0.0
: ${FORGEJO_USER:=root} : ${FORGEJO_USER:=root}
: ${FORGEJO_PASSWORD:=admin1234} : ${FORGEJO_PASSWORD:=admin1234}
: ${RELEASE_NUMBERS_AND_DEV:="$(for r in $RELEASE_NUMBERS; do echo -n "$r $r-dev "; done)"}
ORGANIZATIONS=$(cat $LIB_DIR/ORGANIZATIONS) ORGANIZATIONS=$(cat $LIB_DIR/ORGANIZATIONS)
function log_info() { function log_info() {

View file

@ -1 +0,0 @@
alpine-7.0-test

1
packages/alpine-9.0 Symbolic link
View file

@ -0,0 +1 @@
alpine-7.0

View file

@ -1 +0,0 @@
alpine-7.0-test

View file

@ -31,7 +31,7 @@ function test_storage_stable_s3() {
local work_path=$DIR/forgejo-work-path local work_path=$DIR/forgejo-work-path
local s3_backend=${1:-minio} local s3_backend=${1:-minio}
for version in $RELEASE_NUMBERS_AND_DEV; do for version in $RELEASE_NUMBERS; do
log_info "Forgejo $version & $s3_backend" log_info "Forgejo $version & $s3_backend"
stop stop
storage_reset stable-s3 storage_reset stable-s3

View file

@ -38,7 +38,7 @@ function test_successful_upgrades() {
fixture_assert fixture_assert
doctor_run $config doctor_run $config
for version in $RELEASE_NUMBERS_AND_DEV; do for version in $RELEASE_NUMBERS; do
stop stop
log_info "run $version" log_info "run $version"
start $version start $version