mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2025-04-03 20:47:37 +03:00
d612cad09a
The Database, DatabaseWidget, and DatabaseTabWidget classes share many responsibilities in inconsistent ways resulting in impenetrable and unmaintainable code and a diverse set of bugs and architecture restrictions. This patch reworks the architecture, responsibilities of, and dependencies between these classes. The core changes are: * Move loading and saving logic from widgets into the Database class * Get rid of the DatabaseManagerStruct and move all the information contained in it into the Database * Let database objects keep track of modifications and dirty/clean state instead of handing this to external widgets * Move GUI interactions for loading and saving from the DatabaseTabWidget into the DatabaseWidget (resolves #2494 as a side-effect) * Heavily clean up DatabaseTabWidget and degrade it to a slightly glorified QTabWidget * Use QSharedPointers for all Database objects * Remove the modifiedImmediate signal and replace it with a markAsModified() method * Implement proper tabName() method instead of reading back titles from GUI widgets (resolves #1389 and its duplicates #2146 #855) * Fix unwanted AES-KDF downgrade if database uses Argon2 and has CustomData * Improve code This patch is also the first major step towards solving issues #476 and #2322.
78 lines
2.5 KiB
C++
78 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2018 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSXC_DATABASESETTINGSPAGECHANGEMASTERKEY_H
|
|
#define KEEPASSXC_DATABASESETTINGSPAGECHANGEMASTERKEY_H
|
|
|
|
#include "config-keepassx.h"
|
|
#include "DatabaseSettingsWidget.h"
|
|
#include <QPointer>
|
|
|
|
class Database;
|
|
class Key;
|
|
class CompositeKey;
|
|
class ChallengeResponseKey;
|
|
class KeyComponentWidget;
|
|
class PasswordEditWidget;
|
|
class KeyFileEditWidget;
|
|
class YubiKeyEditWidget;
|
|
class QPushButton;
|
|
|
|
class DatabaseSettingsWidgetMasterKey: public DatabaseSettingsWidget
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit DatabaseSettingsWidgetMasterKey(QWidget* parent = nullptr);
|
|
Q_DISABLE_COPY(DatabaseSettingsWidgetMasterKey);
|
|
~DatabaseSettingsWidgetMasterKey() override;
|
|
|
|
void load(QSharedPointer<Database> db) override;
|
|
|
|
inline bool hasAdvancedMode() const override { return false; }
|
|
|
|
public slots:
|
|
void initialize() override;
|
|
void uninitialize() override;
|
|
bool save() override;
|
|
void discard() override;
|
|
|
|
private slots:
|
|
void showAdditionalKeyOptions();
|
|
void markDirty();
|
|
|
|
private:
|
|
void setAdditionalKeyOptionsVisible(bool show);
|
|
|
|
bool addToCompositeKey(KeyComponentWidget* widget,
|
|
QSharedPointer<CompositeKey>& newKey,
|
|
QSharedPointer<Key>& oldKey);
|
|
bool addToCompositeKey(KeyComponentWidget* widget,
|
|
QSharedPointer<CompositeKey>& newKey,
|
|
QSharedPointer<ChallengeResponseKey>& oldKey);
|
|
|
|
bool m_isDirty = false;
|
|
const QPointer<QPushButton> m_additionalKeyOptionsToggle;
|
|
const QPointer<QWidget> m_additionalKeyOptions;
|
|
const QPointer<PasswordEditWidget> m_passwordEditWidget;
|
|
const QPointer<KeyFileEditWidget> m_keyFileEditWidget;
|
|
#ifdef WITH_XC_YUBIKEY
|
|
const QPointer<YubiKeyEditWidget> m_yubiKeyEditWidget;
|
|
#endif
|
|
};
|
|
|
|
#endif //KEEPASSXC_DATABASESETTINGSPAGECHANGEMASTERKEY_H
|