mirrors/maddy
1
0
Fork 0
mirror of https://github.com/foxcpp/maddy.git synced 2025-04-05 14:07:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix/silence a couple of linter warnings

Browse source
This commit is contained in:
fox.cpp 2020-12-06 14:51:03 +03:00
parent 35ae446e72
commit cf72b11c76
No known key found for this signature in database
GPG key ID: 5B991F6215D2FCC0
4 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
framework/dns/dnssec.go
View file

@ -283,7 +283,6 @@ func (e ExtResolver) AuthLookupIPAddr(ctx context.Context, host string) (ad bool
)
if err != nil {
// Disregard the error for AAAA lookups.
resp = &dns.Msg{}
aaaaFailed = true
log.DefaultLogger.Error("Network I/O error during AAAA lookup", err, "host", host)
} else {

6
framework/dns/dnssec_test.go
View file

@ -52,7 +52,7 @@ func (s *IPAddrTestServer) Run() {
}
s.udpServ.PacketConn = pconn
s.udpServ.Handler = s
go s.udpServ.ActivateAndServe()
go s.udpServ.ActivateAndServe() //nolint:errcheck
}
func (s *IPAddrTestServer) Close() {
@ -117,7 +117,9 @@ func (s *IPAddrTestServer) ServeDNS(w dns.ResponseWriter, m *dns.Msg) {
}
}
w.WriteMsg(reply)
if err := w.WriteMsg(reply); err != nil {
panic(err)
}
}
func TestExtResolver_AuthLookupIPAddr(t *testing.T) {

2
internal/endpoint/smtp/submission.go
View file

@ -103,7 +103,7 @@ func (s *Session) submissionPrepare(msgMeta *module.MsgMetadata, header *textpro
return &exterrors.SMTPError{
Code: 554,
EnhancedCode: exterrors.EnhancedCode{5, 6, 0},
Message: fmt.Sprintf("Invalid address in From"),
Message: "Invalid address in From",
Misc: map[string]interface{}{
"modifier": "submission_prepare",
"addr": header.Get("From"),

2
internal/target/remote/security.go
View file

@ -399,7 +399,7 @@ func (c *daneDelivery) discoverTLSA(ctx context.Context, mx string) ([]dns.TLSA,
return nil, err
}
if rname == "" {
// No A/AAAA records, short-circut discovery instead of doing useless
// No A/AAAA records, short-circuit discovery instead of doing useless
// queries.
return nil, errors.New("no address associated with the host")
}