mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 04:57:37 +03:00
Code Issues Projects Releases Packages Wiki Activity
4026 commits 26 branches 102 tags 75 MiB
Commit graph

599 commits

Author SHA1 Message Date
Deluan
287079a9e4 sec(subsonic): authentication bypass in Subsonic API with non-existent username 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-02-20 19:59:29 -05:00
Kendall Garner
3179966270
fix(metrics): write system metrics on start (#3641) 
* fix(metrics): write system metrics on start

* add broken basic auth test

* refactor: simplify Prometheus instantiation

Signed-off-by: Deluan <deluan@navidrome.org>

* fix: basic authentication

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: move magic strings to constants

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: simplify prometheus http handler

Signed-off-by: Deluan <deluan@navidrome.org>

* add artist metadata to aggregrate sql

---------

Signed-off-by: Deluan <deluan@navidrome.org>
Co-authored-by: Deluan <deluan@navidrome.org>
 2025-01-11 21:02:36 -05:00
Deluan
beff1afad7 fix(subsonic): make Share's lastVisited optional 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-01-09 16:10:53 -05:00
Deluan Quintão
2d8507cfd7
fix(ui): don't hide Last.fm scrobble switch (#3561) 
Signed-off-by: Deluan <deluan@navidrome.org>
 2024-12-19 09:08:28 -05:00
Deluan Quintão
8e2052ff95
feat(Insights): add anonymous usage data collection (#3543) 
* feat(insights): initial code (WIP)

* feat(insights): add more info

* feat(insights): add fs info

* feat(insights): export insights.Data

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): more config info

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor(insights): move data struct to its own package

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor(insights): omit some attrs if empty

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): send insights to server, add option to disable

Signed-off-by: Deluan <deluan@navidrome.org>

* fix(insights): remove info about anonymous login

Signed-off-by: Deluan <deluan@navidrome.org>

* chore(insights): fix lint

Signed-off-by: Deluan <deluan@navidrome.org>

* fix(insights): disable collector if EnableExternalServices is false

Signed-off-by: Deluan <deluan@navidrome.org>

* fix(insights): fix type casting for 32bit platforms

Signed-off-by: Deluan <deluan@navidrome.org>

* fix(insights): remove EnableExternalServices from the collection (as it will always be false)

Signed-off-by: Deluan <deluan@navidrome.org>

* chore(insights): fix lint

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor(insights): rename function for consistency

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): log the data sent to the collector server

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): add last collection timestamp to the "about" dialog.

Also add opt-out info to the SignUp form

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): only sends the initial data collection after an admin user is created

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): remove dangling comment

Signed-off-by: Deluan <deluan@navidrome.org>

* feat(insights): Translate insights messages

Signed-off-by: Deluan <deluan@navidrome.org>

* fix(insights): reporting empty library

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: move URL to consts.js

Signed-off-by: Deluan <deluan@navidrome.org>

---------

Signed-off-by: Deluan <deluan@navidrome.org>
 2024-12-17 17:10:55 -05:00
Deluan
7f030b0859 fix(server): encrypt jwt secret at rest 
Signed-off-by: Deluan <deluan@navidrome.org>
 2024-12-05 21:52:15 -05:00
Deluan
627417dae3 fix(server): add disc number to fake path. 
Also revert "feat(server): enable "Report Real Path" by default"

Signed-off-by: Deluan <deluan@navidrome.org>
 2024-12-02 09:35:39 -05:00
Deluan
c1adf407a1 refactor: load translations with sync.OnceValues 
Signed-off-by: Deluan <deluan@navidrome.org>
 2024-11-18 14:07:31 +02:00
Deluan Quintão
cd0cf7c12b
feat: cache login background images (#3462) 
* feat: use direct links to unsplash for background images

Signed-off-by: Deluan <deluan@navidrome.org>

* feat: cache images from unsplash

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: use cache.HTTPClient to reduce complexity

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: remove magic numbers

Signed-off-by: Deluan <deluan@navidrome.org>

---------

Signed-off-by: Deluan <deluan@navidrome.org>
 2024-11-08 20:23:30 -05:00
Deluan Quintão
a557f37834
refactor: small improvements and clean up (#3423) 
* refactor: replace custom map functions with slice.Map

* refactor: extract StringerValue function

* refactor: removed unnecessary if

* chore: removed invalid comment

* refactor: replace more map functions

* chore: fix FFmpeg typo
 2024-10-22 22:54:31 -04:00
Kendall Garner
0a650de357
feat(subsonic): add MusicBrainz ID and Sort Name to getArtists 2024-10-22 22:00:31 -04:00
Deluan
23bebe4e06 feat(subsonic): getOpenSubsonicExtensions is now public 2024-10-21 17:21:18 -04:00
Deluan Quintão
8b5af67647
feat(subsonic): support OS clearing play queue (#3399) 2024-10-16 10:59:22 -04:00
Deluan Quintão
a9334b7787
feat(ui): show user's lastAccess (#3342) 
* feat(server): update user's lastAccess

* feat(ui): show user's lastAccess
 2024-09-30 20:46:10 -04:00
crazygolem
06c9c1e64a
feat(server): require explicitly enabling reverse proxy auth for unix sockets (#3062) 2024-09-29 13:28:44 -04:00
Deluan
5be73d404f fix(server): allow changing local login background url 2024-09-27 15:18:20 -04:00
Caio Cotts
2887cd65fc Fix wrong placement of When in test 2024-09-15 17:26:58 -04:00
Caio Cotts
8ac133027d Make the UI use the new ShareURL option 2024-09-15 17:26:58 -04:00
Caio Cotts
f0240280eb Add ShareURL configuration option 2024-09-15 17:26:58 -04:00
Kendall Garner
9f1794b97e
Only refresh smart playlist when fetching first track (#3244) 
* Only refresh smart playlist when fetching first track

* res -> w
 2024-09-10 20:18:37 -04:00
Deluan
fc5d18feb7 Change error code type to avoid integer overflow conversion warning 2024-09-01 14:49:48 -04:00
Deluan
5d81849603 Fix lint errors 2024-08-21 12:15:25 -04:00
Deluan
4044642abf Add http headers to trace log 2024-06-16 22:31:47 -04:00
Deluan
232c45bd06 Increase artist image url sizes. 
See https://support.symfonium.app/t/artist-picture-less-compressed/4447
 2024-06-10 16:33:41 -04:00
Caio Cotts
1b77830eb4 Do not use lastFM api key and secret to determine if LastFM.Enabled should be set. 2024-06-10 16:26:39 -04:00
Deluan
3252fab171 Increase artist image url sizes. 
See https://support.symfonium.app/t/artist-picture-less-compressed/4447
 2024-06-08 13:32:57 -04:00
Deluan
b4ef1b1e38 Replace gg.If with cmp.Or 2024-06-05 22:48:00 -04:00
Deluan
abe5690018 Refactor string utilities into its own package str 2024-06-05 22:09:27 -04:00
Caio Cotts
0488fb92cb
Fix image stuttering (#3035) 
* Fix image stuttering.

* Fix docker publishing for PRs

* Write tests for new square parameter.

* Simplify code for createImage.

---------

Co-authored-by: Deluan Quintão <deluan@navidrome.org>
 2024-05-24 20:19:26 -04:00
Drew Weymouth
b6fce0e686
Fix XML marshaling of OpenSubsonic structured lyrics (#3041) 2024-05-22 12:15:14 -04:00
Deluan
55bff343cd Optimize SQLite3 access. Mainly separate read access from write access. 
Based on tips from https://archive.is/Xfjh6#selection-257.0-278.0
 2024-05-21 17:19:41 -04:00
Deluan
b2ecc1d16f Fix G404 gosec lint error 2024-05-19 21:55:19 -04:00
Guilherme Souza
98218d045e
Deterministic pagination in random albums sort (#1841) 
* Deterministic pagination in random albums sort

* Reseed on first random page

* Add unit tests

* Use rand in Subsonic API

* Use different seeds per user on SEEDEDRAND() SQLite3 function

* Small refactor

* Fix id mismatch

* Add seeded random to media_file (subsonic endpoint `getRandomSongs`)

* Refactor

* Remove unneeded import

---------

Co-authored-by: Deluan <deluan@navidrome.org>
 2024-05-18 14:10:53 -04:00
Deluan
0a763b91d5 Fix lint error 2024-05-17 21:46:59 -04:00
Deluan
478c709a64 Associate main entities with library 2024-05-12 21:37:42 -04:00
Deluan
477bcaee58 Store MusicFolder as a library in DB 2024-05-12 21:37:42 -04:00
Deluan
081ef85db6 Rename MediaFolder to Library 2024-05-12 21:37:42 -04:00
Deluan
6f2643e55e Refactor to use more Go 1.22 features 2024-05-12 20:04:53 -04:00
Deluan
3463d0c208 Simplify random.Int64 usage with generics 2024-05-11 20:10:46 -04:00
Deluan
0ae2944073 Refactor random functions 2024-05-11 20:04:21 -04:00
Deluan
30ae468dc1 Uses Unix milliseconds support from standard Go lib 2024-05-11 19:50:30 -04:00
Deluan
3a2a5e961b Add samplingRate to OpenSubsonic responses 2024-05-11 17:57:45 -04:00
Deluan
ed83c22632 Do not panic if when updatePlaylist is called with a non-existent ID. 
Fix #2876
 2024-05-11 15:37:50 -04:00
Deluan
bb96d455f8 Replace sync.WaitGroup with more appropriate errgroup.Group 2024-05-10 15:27:07 -04:00
Deluan
677d9947f3 Make dependency injection more consistent 2024-05-08 22:21:38 -04:00
Deluan
dd4374cec6 Limit access to Jukebox for admins only (configurable). 
Closes #2849
 2024-05-07 19:35:43 -04:00
Deluan
aef49cb8d6 Add HTTPSecurityHeaders.CustomFrameOptionsValue option. 
Requested in https://github.com/navidrome/navidrome/issues/248#issuecomment-1783768985
 2024-05-02 12:35:16 -04:00
Deluan
2c06a4234e Fix int types in OpenSubsonic responses. 
Refer to https://support.symfonium.app/t/symfonium-sync-crashes-when-tpos-is-not-an-int/4204
 2024-05-01 13:57:11 -04:00
Deluan
27875ba2dd Load mime_types from external file 2024-04-28 12:18:24 -04:00
crazygolem
1e96b858a9
Add support for Reverse Proxy auth in Subsonic endpoints (#2558) 
* feat(subsonic): Add support for Reverse Proxy auth - #2557

Signed-off-by: Jeremiah Menétrey <superjun1@gmail.com>

* Small refactoring

---------

Signed-off-by: Jeremiah Menétrey <superjun1@gmail.com>
Co-authored-by: Deluan Quintão <deluan@navidrome.org>
 2024-04-27 13:47:42 -04:00