mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 05:07:42 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions
13812 commits 12 branches 100 tags 40 MiB
Commit graph

198 commits

Author SHA1 Message Date
Kim Alvefur
b9d4cc24df mod_storage_sql: Drop legacy index without confirmation to ease upgrades 
Deleting one index should be safe enough to do without requiring a
explicitly upgrading during downtime. People had trouble with this.
 2025-03-23 12:15:16 +01:00
Kim Alvefur
eacf72504c mod_storage_sql: Fix indentation 
Off-by-one in autoindent after `if not success then` since 3ec48555b773
 2025-03-19 16:13:32 +01:00
Kim Alvefur
c1655a181f mod_storage_sql: Fix tests for SQLite3 
Tests does not run the code that initializes `sqlite_version`
 2025-02-08 12:55:40 +01:00
Kim Alvefur
edfe2fe98c mod_storage_sql: Don't treat Enter or Ctrl-C as yes in upgrade command 
It seems to imply that No is the default, so it shouldn't continue doing
the Yes action unless you actually press Y
 2025-01-23 22:32:44 +01:00
Kim Alvefur
c8134dd9a9 mod_storage_sql: Detect SQLite3 without UPSERT (or SQLCipher 3.x) 
SQLCipher v3.4.1 (the version in Debian 12) is based on SQLite3 v3.15.2,
while UPSERT support was introduced in SQLite3 v3.24.0

This check was not needed before because we v3.24.0 has not been in a
version of Debian we support for a long, long time.

Note however that SQLCipher databases are not compatible across major
versions, upgrading from v3.x to v4.x requires executing a migration.
Attempts at making `prosodyctl mod_storage_sql upgrade` perform such a
migration has not been successful.

Executing the following in the `sqlcipher` tool should do the migration:

	PRAGMA key = '<key material>';
	PRAGMA cipher_migrate;
 2025-01-23 19:33:05 +01:00
Kim Alvefur
ede98f71e4 mod_storage_sql: Remove the word 'error' from debug messages 
The word 'error' anywhere, especially in harmless debug messages, are
too often interpreted as fatal errors my some users, so best avoid that
word. These look too scary as it is, being tracebacks.
 2025-01-08 22:30:30 +01:00
Kim Alvefur
1c4021b70f mod_storage_sql: Use UUIDv7 as keys 
Potentially allows sorting on those directly as they will be in
increasing order.
 2023-07-17 04:30:35 +02:00
Kim Alvefur
51daea2530 mod_storage_sql: Spell out missing dependencies 
Using util.dependencies appeared to cause problems with running tests in
Busted, so this also removes that and uses pcall directly.
 2023-07-22 16:15:48 +02:00
Kim Alvefur
0df158712d mod_storage_sql: Pass variables as arguments instead of upvalues 
Probably a workaround for the lack of argument passing when using xpcall
in Lua 5.1, no longer relevant.
 2023-07-22 15:22:54 +02:00
Kim Alvefur
91d95d4c33 plugins: Use boolean config method in some places 
Because it makes sense and improves feedback via logging
 2023-07-18 12:38:16 +02:00
Kim Alvefur
5d673d0620 mod_storage_sql: Use integer config option for cache size 
Missed this one, was probably only looking for get_option_number
 2023-07-18 11:53:31 +02:00
Kim Alvefur
3b448c4479 mod_storage_sql: Use config enum for 'sqlite_tune' 2023-07-18 11:53:12 +02:00
Kim Alvefur
e1b3be0015 mod_storage_sql: Allow higher precision timestamps in SQLite3 
Since it doesn't actually do strict typing :)
 2023-07-17 04:52:50 +02:00
Kim Alvefur
71ad48095d plugins: Use integer config API with interval specification where sensible 
Many of these fall into a few categories:
- util.cache size, must be >= 1
- byte or item counts that logically can't be negative
- port numbers that should be in 1..0xffff
 2023-07-17 01:38:54 +02:00
Kim Alvefur
84c161c278 mod_storage_sql: Remove completed TODO (testing UPSERT on PostgreSQL) 2023-07-12 22:51:37 +02:00
Kim Alvefur
9f0a28f1c4 mod_storage_sql: Fix column name in index check for PostgreSQL 
Forgot to change the column name in 9a7523ea45cb
 2023-06-17 13:37:33 +02:00
Kim Alvefur
935f28230a mod_storage_sql: Adjust indentation to align with surrounding code 2023-06-17 13:36:42 +02:00
Kim Alvefur
02469e4e8e mod_storage_sql: Only remove old index if it exists 
Avoids an error if the upgrade is performed twice..
 2023-06-17 00:22:45 +02:00
Kim Alvefur
a45c06b51f mod_storage_sql: Be more specific when checking for old index in SQLite3 
Prevents false positives in the odd case where something other than an
index with this name might exist.
 2023-06-17 00:00:21 +02:00
Kim Alvefur
f70ab44b4c mod_storage_sql: Improve check for old table index on PostgreSQL 
The "pg_indexes" view is much simpler to inspect than "pg_class"
 2023-06-16 23:57:15 +02:00
Kim Alvefur
b2cc309529 mod_storage_sql: Enable UPSERT with PostgreSQL 
Tested. Works.
 2023-06-16 13:03:34 +02:00
Kim Alvefur
23273ed228 mod_storage_sql: Add some TODO comments for future UPSERT work 2023-06-11 20:25:50 +02:00
Kim Alvefur
3efb1a72e7 mod_storage_sql: Do not keep track of quota when no quota is set 
No point in doing this expensive O(n) query if the result is not used
for anything.

Will still cache the total item count if an explicit query for this is
performed, then try to keep it updated with new items added. Will likely
forget eventually tho.
 2023-06-11 20:05:32 +02:00
Kim Alvefur
5d6098bc1a mod_storage_sql: Add setting to tune SQLite3 performance vs safety 
Notably the default journal_mode of DELETE is somewhat slow, some users
might want to catch up to the amazing performance of internal storage.
 2023-06-11 17:04:11 +02:00
Kim Alvefur
0b74dcbdfb mod_storage_sql: Record all SQLite3 compile options for potential use 
Knowing what features are available could be useful for future
experiments. For example, with the JSON module or full text search.
 2023-06-10 14:01:56 +02:00
Kim Alvefur
1ece33405d mod_storage_sql: Compose a keyval+ store out of keyval and map store methods 
Removes the need for the shim in storagemanager.

The methods only really access the 'store' property of the first (self)
argument, so this is safe.
 2023-06-10 16:39:48 +02:00
Kim Alvefur
77e0a63ab1 mod_storage_sql: Add UPSERT support 
Currently limited to SQLite3 for lack of testing on other databases.

Adds a migration to replace the non-UNIQUE prosody_index, renaming it
prosody_unique_index since ALTER INDEX does not seem to be portable.
 2023-06-10 15:44:09 +02:00
Kim Alvefur
98922d54b1 plugins: Prefix module imports with prosody namespace 2023-03-24 13:15:28 +01:00
Kim Alvefur
3605137656 mod_storage_sql: Remove module status on unknown 'debug' level 
Expected this to be translated to 'core', but it logs an error instead.
See previous commit.
 2023-01-31 07:52:33 +01:00
Kim Alvefur
89f652ff0b mod_storage_sql: Silence luacheck warning 2023-01-30 00:40:47 +01:00
Kim Alvefur
0147b972e0 mod_storage_sql: Record connection to database as module status 
Allows retrieving this in e.g. a health reporting module

Thanks pfak
 2023-01-30 00:38:26 +01:00
Kim Alvefur
4c14111c76 mod_storage_sql: Support SQLite3 without LuaDBI 2023-01-19 16:56:12 +01:00
Kim Alvefur
7c647e1cee Merge 0.12->trunk 2023-01-06 23:53:50 +01:00
Kim Alvefur
91a064bd49 mod_storage_sql: Fix #1639 
Patch by Peter Kieser
 2023-01-01 16:20:58 +01:00
Kim Alvefur
e9a7490f67 Merge 0.12->trunk 2022-12-29 18:28:50 +01:00
Kim Alvefur
2317f6a09f mod_storage_sql: Don't avoid initialization under prosodyctl (fix #1787) 
Fixes `prosodyctl adduser` etc.

Prior to d580e6a57cbb the line did nothing.

Sometimes storage in the prosodyctl context does cause weirdness, as it
is not in a host context, but rather a variant of global.
 2022-12-29 18:06:35 +01:00
Kim Alvefur
2dbbce2382 mod_storage_sql: Fix summary API with Postgres (fixes #1766) 
The ORDER BY and LIMIT clauses are not needed and don't even make much
sense. This part was most likely a leftover from the :find method.

Tested with sqlite and postgres 14
 2022-07-22 19:09:50 +02:00
Kim Alvefur
9f51add3a8 mod_storage_sql: Fix bypass of load procedure under prosodyctl 
There's no 'prosody.prosodyctl' property other than this one, introduced
in 6216743c188c in 2015.

Guessing that the intent was to skip this when running as a prosodyctl
command. The module.command code does its own version of this
initialization, so this seems likely.

Thanks raja for noticing
 2022-07-26 00:39:16 +02:00
Kim Alvefur
1dd9e547ce mod_storage_sql: Strip timestamp precision in queries to fix error (thanks muppeth) 
Fixes
Error in SQL transaction: Error executing statement parameters: ERROR:  invalid input syntax for integer

This was handled for INSERT in 9524bb7f3944 but not SELECT.
 2022-09-07 12:27:12 +02:00
Kim Alvefur
50304f83fd mod_storage_sql: Drop archive timestamp precision pending schema update 
The "when" column is an INTEGER which will probably be unhappy about
storing higher precision timestamps, so we keep the older behavior for
now.
 2022-08-14 17:29:39 +02:00
Kim Alvefur
9a375e4444 Merge 0.12->trunk 2022-07-29 17:10:31 +02:00
Kim Alvefur
7c8dd7ee42 Merge 0.12->trunk 2022-07-27 00:10:08 +02:00
Kim Alvefur
5251c9b686 compat: Remove handling of Lua 5.1 location of 'unpack' function 2022-07-11 19:07:38 +02:00
Kim Alvefur
2ec8fbe7e5 mod_storage_sql: Remove Lua 5.1 compatibility hack 
Part of #1600
 2022-07-02 17:30:06 +02:00
Kim Alvefur
0bb07b9711 mod_storage_sql: Return cached total where it makes sense 
This should skip the summary SQL query when not needed, ie when the
cached value can be used directly.
 2021-11-30 16:26:01 +01:00
Kim Alvefur
36bbf6b077 mod_storage_sql: Adjust handling of 'total' for multi-id queries 
Otherwise a query for a set of ids may cause that value to be cached,
despite only covering a subset.
 2021-11-30 15:58:23 +01:00
Kim Alvefur
0d9065ae80 mod_storage_sql: Fix traceback on multi-user deletion 
jid.join(true, ...) fails.

Since we don't know which users this affects, best to clear the whole
cache.
 2021-11-30 15:24:17 +01:00
Kim Alvefur
0a50cf1be4 mod_storage_sql: Expose multi-user deletion capability 
archive_store:delete(true) deletes messages for all users, which would
allow some simplification when this is supported.
 2021-11-30 01:21:02 +01:00
Kim Alvefur
d4c3f44ade mod_storage_sql: Fix for move of yes/no function (Thanks Kasim) 2021-06-21 17:31:17 +02:00
Kim Alvefur
0f0d32d335 mod_storage_sql: Implement map-like API for archives 
Used by mod_http_file_share, muc moderation, etc.

Tests tweaked because they failed on stanza internals that happen
becasue of re-serialization. Namespaces differ since inheritance is
implicit when building but explicit after parsing.
 2021-02-01 12:47:05 +01:00