mirrors/thiserror
1
0
Fork 0
mirror of https://github.com/dtolnay/thiserror.git synced 2025-04-04 13:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

Improve diagnostic on raw identifier in format string

Browse source
This commit is contained in:
David Tolnay 2024-11-04 22:03:43 -05:00
parent 58cc36e69f
commit bf6efce84d
No known key found for this signature in database
GPG key ID: F9BA143B95FF6D82
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
impl/src/fmt.rs
View file

@ -70,6 +70,9 @@ impl Display<'_> {
member
}
'a'..='z' | 'A'..='Z' | '_' => {
if read.starts_with("r#") {
continue;
}
let ident = Ident::new(take_ident(&mut read), span);
MemberUnraw::Named(IdentUnraw::new(ident))
}

17
tests/ui/raw-identifier.stderr
View file

@ -1,10 +1,13 @@
error: invalid format string: expected `}`, found `#`
--> tests/ui/raw-identifier.rs:4:9
error: invalid format string: raw identifiers are not supported
--> tests/ui/raw-identifier.rs:4:18
|
4 | #[error("error: {r#fn}")]
| ^^^^^^^^^^^^^^^ expected `}` in format string
| --^^
| |
| raw identifier used here in format string
| help: remove the `r#`
|
= note: if you intended to print `{`, you can escape it using `{{`
= note: identifiers in format strings can be keywords and don't need to be prefixed with `r#`
error: invalid format string: raw identifiers are not supported
--> tests/ui/raw-identifier.rs:11:30
@ -16,9 +19,3 @@ error: invalid format string: raw identifiers are not supported
| help: remove the `r#`
|
= note: identifiers in format strings can be keywords and don't need to be prefixed with `r#`
error[E0425]: cannot find value `r` in this scope
--> tests/ui/raw-identifier.rs:4:9
|
4 | #[error("error: {r#fn}")]
| ^^^^^^^^^^^^^^^ not found in this scope