David Tolnay
8a77dea3ae
Parse trait bound before deciding name for local binding
2024-11-08 13:11:46 -05:00
David Tolnay
24e7f87d0d
Clean up formatvar identifier construction
2024-11-08 13:07:02 -05:00
David Tolnay
337df1db6d
Move recursion checking out of bindings
2024-11-08 12:58:25 -05:00
David Tolnay
5948ee6ce4
Support generic types that need multiple bounds
2024-11-08 12:48:50 -05:00
David Tolnay
1bb7e7aa78
Check invalid Named member references before producing MemberUnraw
2024-11-08 12:30:24 -05:00
David Tolnay
6a0eb08569
Recognize infinite recursion caused by {self}
2024-11-04 22:28:23 -05:00
David Tolnay
e44fd92065
Further deconflict macro-generated format var names with user-provided ones
2024-11-04 22:09:13 -05:00
David Tolnay
bf6efce84d
Improve diagnostic on raw identifier in format string
2024-11-04 22:05:19 -05:00
David Tolnay
58cc36e69f
Improve diagnostic on {_} in format string
2024-11-04 22:04:59 -05:00
David Tolnay
4a79e0121e
Rewrite fmt expansion to exactly preserve user-provided args
2024-11-04 22:04:18 -05:00
David Tolnay
f8fd1bf196
Fix collision of numbered field references with user-written named arg
2024-11-04 21:12:25 -05:00
David Tolnay
51ccdf18f5
Slightly cleaner implementation of has_trailing_comma
2024-11-04 20:48:22 -05:00
David Tolnay
7e43dec573
Improve error message to distinguish tuple struct vs tuple variant
2024-11-04 20:11:01 -05:00
David Tolnay
3070b8b6c8
Work around rustc pre-1.74's possibly-uninitialized checker
...
error[E0381]: used binding `ahead` is possibly-uninitialized
--> impl/src/fmt.rs:187:30
|
182 | let ahead;
| ----- binding declared here but left uninitialized
183 | if *syn_full.get_or_insert_with(is_syn_full) && {
184 | ahead = input.fork();
| -----
| |
| binding initialized here in some conditions
| binding initialized here in some conditions
...
187 | input.advance_to(&ahead);
| ^^^^^^ `ahead` used here but it is possibly-uninitialized
2024-11-04 20:00:51 -05:00
David Tolnay
d3b926132b
Disable numbered access to positional args on tuples
2024-11-04 20:00:31 -05:00
David Tolnay
593317939c
Only apply inferred bounds if interpolation refers to field, not format var
2024-11-04 17:20:18 -05:00
David Tolnay
9116fdb8ea
Use IdentUnraw consistently when comparing Member
2024-11-04 17:12:08 -05:00
David Tolnay
78d6bd6fca
Add a type for representing raw-agnostic format vars
2024-11-04 15:52:16 -05:00
David Tolnay
6ddeda270e
Fix edge case of take_int and take_ident at end of string
2024-11-04 15:28:49 -05:00
David Tolnay
3814afebf4
Stick to only string manipulation in take_ident
2024-11-04 15:25:27 -05:00
David Tolnay
ef59afe2d4
Delete support for raw identifiers inside format string
2024-11-04 15:20:05 -05:00
David Tolnay
08f89925bf
Disregard equality binop in fallback parser
2024-11-04 11:46:01 -05:00
David Tolnay
b3bf7a6f69
Add logic to determine whether unnamed fmt arguments are present
2024-11-04 11:34:52 -05:00
David Tolnay
7daf1b169d
Defer is_syn_full() call until first expression
2024-11-04 11:29:37 -05:00
David Tolnay
40a53f7f33
Interleave Expr parsing and scanning better
2024-11-04 11:21:12 -05:00
David Tolnay
0ab908aab0
Ignore expected unnecessary_wraps pedantic clippy lint
...
warning: this function's return value is unnecessarily wrapped by `Result`
--> impl/src/fmt.rs:122:1
|
122 | / fn explicit_named_args(input: ParseStream) -> Result<Set<Ident>> {
123 | | let ahead = input.fork();
124 | | if let Ok(set) = try_explicit_named_args(&ahead) {
125 | | input.advance_to(&ahead);
... |
136 | | Ok(Set::new())
137 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps
= note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_wraps)]`
help: remove `Result` from the return type...
|
122 | fn explicit_named_args(input: ParseStream) -> std::collections::BTreeSet<proc_macro2::Ident> {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: ...and then change returning expressions
|
126 ~ return set;
127 | }
...
131 | input.advance_to(&ahead);
132 ~ return set;
133 | }
134 |
135 | input.parse::<TokenStream>().unwrap();
136 ~ Set::new()
|
2024-11-02 21:12:30 -07:00
David Tolnay
c357f9728e
Add infallible expr scanner fallback for scanning invalid code
2024-11-02 21:11:32 -07:00
David Tolnay
dabb96fdaf
Use syn's real expression parser if it has full syntax support
2024-11-02 20:46:25 -07:00
David Tolnay
2585669fa1
More robust scanning for fmt argument expressions
2024-11-02 09:42:34 -07:00
David Tolnay
747ce20cc2
Remove format var parsing workaround that targeted rustc 1.40 and older
2024-10-31 21:23:45 -07:00
David Tolnay
f790bee2a4
Phrase flag in terms of whether core::fmt machinery is required
2024-02-11 10:28:28 -08:00
Yuri Astrakhan
cd79876fe8
optimize by avoiding second fmt.value() call
2024-02-08 23:56:26 -05:00
David Tolnay
4b581e3fb9
Skip a redundant Member clone
2021-09-04 20:41:29 -07:00
David Tolnay
f688fd7009
Handle multiple bounds from the same format string on the same field
2021-09-04 20:00:05 -07:00
David Tolnay
cc65053651
Implied bounds for the remaining std::fmt traits
2021-09-04 19:45:32 -07:00
David Tolnay
1e6e267914
Implied bounds for Display and Error impl
2021-09-04 18:21:37 -07:00
David Tolnay
aafcf0a1b6
Fix second place that keyword fmt argument is failing
2020-11-03 16:41:37 -08:00
David Tolnay
2722f8e2c3
Fix first place that keyword fmt argument is failing
2020-11-03 16:38:35 -08:00
David Tolnay
334fed3a74
Briefer naming convention for raw identifier format vars
2020-11-03 16:27:28 -08:00
David Tolnay
dbbd0f816c
Consolidate ident lex and conversion to Ident
2020-11-03 16:26:24 -08:00
David Tolnay
227ef7df76
Replace use of str::strip_prefix
...
Strip_prefix was introduced in Rust 1.45, whereas we support older compilers.
2020-11-03 16:23:05 -08:00
ninevra
5fc018d195
Prefix raw field named params with "raw_field_"
...
Reduces likelihood of collision with user-defined named parameters.
2020-11-03 15:21:46 -08:00
ninevra
9d274d433e
Support raw idents in error() format strings
2020-11-03 14:42:35 -08:00
David Tolnay
1b40434034
Fix missing comma between named format elements
2020-03-22 23:10:01 -07:00
David Tolnay
20202db299
Remove incorrect detection of simple fmt cases
...
This was intended to detect the simple cases "{var}" and "{var:?}" and emit them
as straightforward Display::fmt and Debug::fmt method calls rather than a write
macro, but this was only to keep the generated code simple and is not important.
It was broken by the changes to how we parse the fmt attr in 1.0.7.
Fixes #53 .
2019-12-03 19:33:17 -08:00
David Tolnay
038b8d5534
Defer handling of trailing comma in display attribute
...
The previous implementation would have silently accepted invalid input
such as:
#[derive(Error, Debug)]
#[error("",,)]
pub struct Error;
2019-11-30 18:42:38 -08:00
David Tolnay
26fe392262
Only apply int shorthand for tuple fields that exist
2019-11-30 18:32:43 -08:00
David Tolnay
c05e9ed4ec
Support mixing shorthand and non-shorthand format args
2019-11-30 17:45:44 -08:00
David Tolnay
6dddf44493
Simplify with Index's new IdentFragment impl
2019-11-30 17:08:54 -08:00
David Tolnay
7f8b5784cb
Support referring to statics and consts from shorthand
2019-11-30 16:30:04 -08:00
